Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1734#issuecomment-190601248
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske closed the pull request at:
https://github.com/apache/flink/pull/1734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1734#issuecomment-190585140
You can close this one too @fhueske.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1734#issuecomment-190417170
Merging this one too!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1734#issuecomment-190272164
looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1734#issuecomment-190267290
I added a commit to catch Calcite's planner exception and extend the error
message.
---
If your project is set up for it, you can reply to this email and have your
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1734#issuecomment-190247404
Looks good, thanks!
Just one thing. If the `FlinkJoinRule` doesn't match, could we throw some
meaningful exception, e.g. "Join equality predicates should refer to
