[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-71134892 As per recommendation from @StephanEwen, will not merge this to 0.8 until we need to cherry-pick fixes related to these files. --- If your project is set up for it, you

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-71119613 Cool, thanks @StephanEwen, if no one beats me merging I will do this EOD today --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-71103567 You have my +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-71079720 Can I get +1 for this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-70954383 The problem is that if we do not merge to 0.8.x branch then if we have fixes in those file would it create weird conflict when trying to cherry-pick? --- If your project

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-70953743 Looks good to me. It does not break the API, since it only moves source code, so I do not have any objections. I would merge it into the master, though, not into 0.8.

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-70949800 If no more comment will merge this and 0.8.x branch by end of day tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-70715529 I rename the file from coGroupDataSet.scala to CoGroupDataSet.scala and crossDataSet.scala to CrossDataSet.scala to follow convention Scala file naming. And move

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-70676663 Why do you want to move them? On Jan 20, 2015 4:42 AM, "Henry Saputra" wrote: > FYI @aljoscha > > — > Reply to thi

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-70600130 FYI @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

GitHub user hsaputra opened a pull request: https://github.com/apache/flink/pull/324 Rename coGroupDataSet.scala to CoGroupDataSet.scala, and crossDataSet.scala to CrossDataSet.scala This PR contains changes to follow Scala style: -) Rename coGroupDataSet.scala to CoGroupDataSet