Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2094
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88617516
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licen
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88615926
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licen
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88616007
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licen
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88615630
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88614862
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88614874
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88614846
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87100173
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87094727
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87099565
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87096436
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -337,37 +337,43 @@ public KeyedStream(DataStre
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87098882
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87093199
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87101256
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87102206
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87095855
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r87094884
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed to t
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r86366630
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -264,6 +265,7 @@ public void getFlatFields(String fieldExpre
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84767836
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeType.java
---
@@ -265,16 +265,6 @@ public boolean hasDeterministicFieldOrde
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84768779
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to the Apache So
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84768233
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/ProductFieldAccessor.java
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apach
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84769097
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed to the Apache So
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84767248
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Softwa
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84766789
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -264,6 +265,7 @@ public void getFlatFields(String fieldExpres
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84767067
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Softwa
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84765869
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Softwa
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84767443
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Softwa
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r84767676
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +206,34 @@ public void getFlatFields(String field
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76576801
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache Sof
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76576754
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Sof
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76567285
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache So
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76567175
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache So
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040664
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -301,12 +301,12 @@ public KeyedStream(DataStrea
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040669
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/DataStreamPojoITCase.java
---
@@ -139,17 +139,6 @@ public void flatMap(Data value,
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040657
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/CaseClassTypeInfo.scala
---
@@ -236,6 +237,31 @@ abstract class CaseClassTypeInfo[T
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040641
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/ProductFieldAccessor.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040621
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Sof
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040630
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwar
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040529
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwar
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040566
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName) {
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040578
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String fieldE
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040541
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwar
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040571
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String fieldE
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040561
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName) {
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040520
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType() {
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040551
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwar
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040502
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType() {
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040516
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType() {
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040532
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwar
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040498
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicTypeInfo.java
---
@@ -171,6 +172,23 @@ public boolean isKeyType() {
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040491
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicArrayTypeInfo.java
---
@@ -121,6 +122,18 @@ public boolean isKeyType() {
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76024415
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwar
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75908195
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Sof
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75907421
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Sof
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75876606
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/DataStreamPojoITCase.java
---
@@ -139,17 +139,6 @@ public void flatMap(Data value
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75868407
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -301,12 +301,12 @@ public KeyedStream(DataStre
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75839040
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/CaseClassTypeInfo.scala
---
@@ -236,6 +237,31 @@ abstract class CaseClassTypeInfo[T
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75837546
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwa
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75836333
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/ProductFieldAccessor.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apach
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75835835
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwa
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75835061
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache So
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75834833
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache So
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75834786
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache So
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75833983
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String field
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75833200
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String field
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75832360
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String field
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75831968
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName)
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75830865
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName)
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75829026
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwa
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75828673
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwa
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75828736
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwa
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75828177
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache Softwa
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75827568
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType() {
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75827397
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType() {
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75827289
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType() {
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75826929
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicTypeInfo.java
---
@@ -171,6 +172,23 @@ public boolean isKeyType() {
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75826683
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicArrayTypeInfo.java
---
@@ -121,6 +122,18 @@ public boolean isKeyType() {
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/2094
[FLINK-3702] Make FieldAccessors support nested field expressions.
I finally had some time to complete this, sorry it took so long.
I have added `getFieldAccessor` to `TypeInformation`, which
79 matches
Mail list logo
