[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2313 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75908291 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -243,46 +247,46 @@ public static JobExecutionResult awaitJobResult(Jo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75907814 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -243,46 +247,46 @@ public static JobExecutionResult awaitJobResult(Jo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75905168 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -243,46 +247,46 @@ public static JobExecutionResult awaitJob

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75902171 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -243,46 +247,46 @@ public static JobExecutionResult awaitJobResult(Jo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75900649 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -243,46 +247,46 @@ public static JobExecutionResult awaitJob

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75676249 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75669417 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75669289 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75650523 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75650460 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75650141 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75645279 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoad

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75644258 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoad

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75644122 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoad

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75483059 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75482760 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75476846 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75474811 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75468671 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75460084 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75459375 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75452006 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75443084 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75442830 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java --- @@ -198,10 +211,47 @@ else if (message instanceof SubmitJobAndWait)

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75442857 --- Diff: flink-tests/src/test/java/org/apache/flink/test/clients/examples/JobRetrievalITCase.java --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache S

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75442774 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75308861 --- Diff: flink-tests/src/test/java/org/apache/flink/test/clients/examples/JobRetrievalITCase.java --- @@ -0,0 +1,137 @@ +/* + * Licensed to the

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75310003 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-18 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75307414 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobInfo.scala --- @@ -58,10 +62,63 @@ class JobInfo( } } -

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75307091 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/client/JobClientActorTest.java --- @@ -100,13 +101,51 @@ public void testSubmissionTimeou

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75305767 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobInfo.scala --- @@ -58,10 +62,63 @@ class JobInfo( } }

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75305261 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java --- @@ -198,10 +211,47 @@ else if (message instanceof SubmitJo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75302372 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75301960 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,162 @@ public static JobExecutionResult submitJo

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-17 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75123576 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,168 @@ public static JobExecutionResult submitJobAndWait(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-17 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r75122721 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,168 @@ public static JobExecutionResult submitJobAndWait(

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r74757794 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java --- @@ -198,10 +211,47 @@ else if (message instanceof SubmitJobAnd

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r74757666 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,168 @@ public static JobExecutionResult submitJobAnd

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r74756158 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,168 @@ public static JobExecutionResult submitJobAnd

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-07-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r72887224 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobInfo.scala --- @@ -37,8 +37,10 @@ import org.apache.flink.runtime.akka.ListeningBeh

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-07-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2313 [FLINK-4273] Modify JobClient to attach to running jobs These changes are required for FLINK-4272 (introduce a JobClient class for job control). Essentially, we want to be able to re-attach to a