[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2671 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-24 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2671#discussion_r84689568 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java --- @@ -99,8 +111,12 @@ public boo

[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2671#discussion_r84463868 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java --- @@ -99,8 +111,12 @@ public boo

[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2671#discussion_r84465826 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java --- @@ -88,9 +96,13 @@ public Trig

[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2671#discussion_r84465211 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java --- @@ -88,9 +96,13 @@ public Trig

[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2671#discussion_r84464275 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java --- @@ -45,6 +45,12 @@ pri

[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2671#discussion_r84464167 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java --- @@ -88,9 +96,13 @@ public Trig

[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-20 Thread manuzhang
GitHub user manuzhang opened a pull request: https://github.com/apache/flink/pull/2671 [FLINK-4862] fix Timer register in ContinuousEventTimeTrigger Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.