Github user ex00 closed the pull request at:
https://github.com/apache/flink/pull/3033
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r99778650
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -144,21 +150,46 @@ class DataSe
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96588722
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -46,6 +47,7 @@ class DataSetSin
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96586208
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -46,6 +47,7 @@ class DataSet
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96585254
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -46,6 +47,7 @@ class DataSetSin
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96583281
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -46,6 +47,7 @@ class DataSet
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96580679
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -46,6 +47,7 @@ class DataSetSin
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96423406
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,9 +372,163 @@ class JoinITCase(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96423692
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,9 +372,163 @@ class JoinITCase(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96423800
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,9 +372,163 @@ class JoinITCase(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96410649
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetSingleRowJoinRule.scala
---
@@ -36,17 +36,13 @@ class D
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96413995
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -46,6 +47,7 @@ class DataSet
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96409638
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/MapJoinRightRunner.scala
---
@@ -32,6 +33,17 @@ class MapJoinRightRunner[
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96408903
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/MapJoinLeftRunner.scala
---
@@ -32,6 +33,17 @@ class MapJoinLeftRunner[IN
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96419547
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -144,21 +150,46 @@ class Dat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96419377
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -144,21 +150,46 @@ class Dat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96409192
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/MapJoinLeftRunner.scala
---
@@ -32,6 +33,17 @@ class MapJoinLeftRunner[IN
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96413755
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -144,21 +150,46 @@ class Dat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96420110
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/DataSetSingleRowJoinTest.scala
---
@@ -192,4 +192,145 @@ clas
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96420458
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/DataSetSingleRowJoinTest.scala
---
@@ -192,4 +192,145 @@ clas
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96421185
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,9 +372,163 @@ class JoinITCase(
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96397396
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,9 +372,163 @@ class JoinITCase(
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96359104
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,9 +372,163 @@ class JoinITCase(
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96359044
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,9 +372,163 @@ class JoinITCase(
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96356761
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,9 +372,163 @@ class JoinITCase(
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96356416
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetJoinRule.scala
---
@@ -43,7 +43,7 @@ class DataSetJoinRule
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96356194
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -144,21 +150,46 @@ class DataSe
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r93592588
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetJoinRule.scala
---
@@ -40,10 +41,17 @@ class DataSetJoinRu
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r93469241
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetJoinRule.scala
---
@@ -40,10 +41,17 @@ class DataSetJoi
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r93472610
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetSingleRowJoinRule.scala
---
@@ -35,16 +35,7 @@ class Da
GitHub user ex00 opened a pull request:
https://github.com/apache/flink/pull/3033
[FLINK-5256] Extend DataSetSingleRowJoin to support Left and Right joins
add support outer joins with single record via DataSetSingleRowJoin
Thanks for contributing to Apache Flink. Before you
31 matches
Mail list logo
