[GitHub] flink pull request #3541: [FLINK-6032] [cep] Clean-up operator state when no...

2017-04-18 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/3541#discussion_r112071560 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/SubEvent.java --- @@ -31,6 +31,18 @@ public double getVolume() { }

[GitHub] flink pull request #3541: [FLINK-6032] [cep] Clean-up operator state when no...

2017-04-18 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/3541#discussion_r112071274 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -385,4 +393,25 @@ public int hashC

[GitHub] flink pull request #3541: [FLINK-6032] [cep] Clean-up operator state when no...

2017-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3541: [FLINK-6032] [cep] Clean-up operator state when no...

2017-03-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3541#discussion_r106152948 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java --- @@ -153,6 +153,7 @@ public void

[GitHub] flink pull request #3541: [FLINK-6032] [cep] Clean-up operator state when no...

2017-03-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3541#discussion_r106133528 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java --- @@ -153,6 +153,7 @@ public void

[GitHub] flink pull request #3541: [FLINK-6032] [cep] Clean-up operator state when no...

2017-03-15 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3541#discussion_r106133141 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java --- @@ -153,6 +153,7 @@ public

[GitHub] flink pull request #3541: [FLINK-6032] [cep] Clean-up operator state when no...

2017-03-15 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3541 [FLINK-6032] [cep] Clean-up operator state when not needed. The CEP operator now cleans the registered state for a key. This happens: 1) for the priority queue, when the queue is empty. 2) for t