[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3935 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117447913 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala --- @@ -28,7 +28,7 @@ import com.google.common.util.con

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117442464 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala --- @@ -28,7 +28,7 @@ import com.google.common.util.concurren

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117442054 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java --- @@ -146,7 +147,7 @@ public static TaskManagerCo

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441051 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -27,7 +27,7 @@ */ @PublicEvolving public class AkkaO

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441386 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobAttachmentClientActor.java --- @@ -114,7 +114,7 @@ else if (JobClientMessages.getRe

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441942 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyFactory.java --- @@ -100,7 +100,7 @@ public static Resta

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117443837 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -55,4 +55,88 @@ public static final ConfigOption AKKA_WATCH_

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441680 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobSubmissionClientActor.java --- @@ -119,7 +119,7 @@ public void handleCustomMessage(O

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441909 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java --- @@ -87,7 +87,7 @@ public static Fixe

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441984 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -114,13 +114,11 @@ public QueryableStateClient(

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-18 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117390018 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -28,31 +28,143 @@ @PublicEvolving public class AkkaOption

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117252282 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java --- @@ -92,7 +92,7 @@ public stat

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117237209 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java --- @@ -92,7 +92,7 @@ public static Fai

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117236057 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -28,31 +28,143 @@ @PublicEvolving public class AkkaOptions

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117235231 --- Diff: flink-tests/src/test/java/org/apache/flink/test/recovery/ProcessFailureCancelingITCase.java --- @@ -42,10 +41,8 @@ import org.apache.flink.run

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-17 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3935 [FLINK-6495] Migrate Akka configuration options Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your chang