Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4761
---
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154080335
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/DummyEnvironment.java
---
@@ -190,4 +191,8 @@ public InputGate getInputGate
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154067761
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
---
@@ -34,12 +31,10 @@
* The {@link Res
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154023982
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -671,7 +671,7 @@ else if (current == ExecutionState.CANCELING)
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154025597
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/TaskEventDispatcherTest.java
---
@@ -0,0 +1,168 @@
+/*
+ * Licensed to t
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154026050
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/TaskEventDispatcherTest.java
---
@@ -0,0 +1,168 @@
+/*
+ * Licensed to t
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154021028
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationHeadTask.java
---
@@ -223,8 +225,10 @@ private void readInitialSolu
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154027456
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/DummyEnvironment.java
---
@@ -190,4 +191,8 @@ public InputGate getInput
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154027358
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
---
@@ -325,9 +325,10 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154023066
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
---
@@ -34,12 +31,10 @@
* The {@link
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4761
[FLINK-7748][network] properly use the TaskEventDispatcher for subscribing
to events
## What is the purpose of the change
`ResultPartitionWriter` currently implements the `EventListener` inte
11 matches
Mail list logo