Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5087
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r156736950
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -208,27 +209,61 @@ public void setLocality(Locality loca
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r156732600
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/LogicalSlot.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache S
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r156732177
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -37,16 +41,18 @@
* If this slot is part of a {@lin
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r156731976
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -965,11 +965,20 @@ public void cancel() {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r156728375
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
---
@@ -267,10 +270,77 @@ public void testAnyPreferred
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r156727881
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java
---
@@ -294,11 +297,11 @@ public vo
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r156727267
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -331,8 +334,19 @@ public void setInitialState(TaskS
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155227397
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -208,27 +209,61 @@ public void setLocality(Locality locality) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155225733
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/LogicalSlot.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software F
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155208534
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -37,16 +41,18 @@
* If this slot is part of a {@link SharedS
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155207330
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -965,11 +965,20 @@ public void cancel() {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155018207
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
---
@@ -267,10 +270,77 @@ public void testAnyPreferredLocationC
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155016510
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
---
@@ -267,10 +270,77 @@ public void testAnyPreferredLocationC
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155015331
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java
---
@@ -294,11 +297,11 @@ public void testSc
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155012983
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -331,8 +334,19 @@ public void setInitialState(TaskStateSnaps
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r154954054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -37,16 +41,18 @@
* If this slot is part of a {@link SharedS
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5087
[FLINK-8085] Thin out LogicalSlot interface
## What is the purpose of the change
Remove isCanceled, isReleased method and decouple logical slot from
Execution by
introducing a Payl
18 matches
Mail list logo