Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182254735
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -327,19 +392,41 @@ class Aggregati
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182768726
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -327,19 +392,41 @@ class Aggregati
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182469110
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/OverAggregate.scala
---
@@ -70,7 +70,12 @@ trait OverAggregate {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182219690
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +51,96 @@ class OverWindo
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182489141
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggregat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182233134
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggregat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182753219
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,15 @@ class Aggregatio
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182218521
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggregat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182768521
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -327,19 +392,41 @@ class Aggregati
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182753514
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,15 @@ class Aggregatio
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182478446
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -93,6 +97,8 @@ class AggregationCo
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182481625
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -0,0 +1,102 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182773359
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -417,13 +530,26 @@ class Aggregati
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182496465
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggregat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182479163
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -93,6 +97,8 @@ class AggregationCo
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182226785
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggregat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r182496636
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggregat
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r18367
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,15 @@ class Aggregat
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183598006
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class OverWi
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222077
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggreg
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222573
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +51,96 @@ class OverWin
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222457
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/OverAggregate.scala
---
@@ -70,7 +70,12 @@ trait OverAggregate {
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222451
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -0,0 +1,102 @@
+/*
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222089
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggreg
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222353
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -327,19 +392,41 @@ class Aggrega
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183866776
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,15 @@ class Aggregatio
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183867019
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class OverWind
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183880939
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,15 @@ class Aggregat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184092223
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class OverWind
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184085613
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -0,0 +1,106 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184039407
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -207,112 +241,164 @@ class Aggrega
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184036079
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,36 @@ class Aggregatio
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184037303
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,36 @@ class Aggregatio
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184075230
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -481,14 +622,34 @@ class Aggregati
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184048806
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -417,13 +548,23 @@ class Aggregati
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184036382
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,36 @@ class Aggregatio
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184040192
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -0,0 +1,106 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184041605
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -207,112 +241,164 @@ class Aggrega
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184040988
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -207,112 +241,164 @@ class Aggrega
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184041109
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -207,112 +241,164 @@ class Aggrega
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184041497
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -207,112 +241,164 @@ class Aggrega
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184115947
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,36 @@ class Aggregat
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184125030
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -0,0 +1,106 @@
+/*
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184115873
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,36 @@ class Aggregat
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184405329
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class OverWind
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184405910
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class OverWind
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184428065
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class OverWi
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184429742
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class OverWi
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184419816
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -47,60 +51,51 @@ class D
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184441869
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -47,60 +51,51 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184442107
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class OverWind
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/
---
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/
[FLINK-8689][table]Add runtime support of distinct filter using MapView for
codegen
## What is the purpose of the change
- Adding in runtime support using distinct aggregation delega
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170577418
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala
---
@@ -0,0 +1,122 @@
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170577818
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,80 @@ class OverWin
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170577731
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1393,6 +1393,21 @@ object Aggreg
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170577531
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala
---
@@ -0,0 +1,122 @@
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170577325
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala
---
@@ -0,0 +1,122 @@
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170577575
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala
---
@@ -0,0 +1,122 @@
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170577434
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala
---
@@ -0,0 +1,122 @@
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170577231
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -105,11 +106,32 @@ class Aggrega
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170605004
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,80 @@ class OverWin
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170604304
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1393,6 +1393,21 @@ object Aggreg
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170603205
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala
---
@@ -0,0 +1,122 @@
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170602449
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala
---
@@ -0,0 +1,122 @@
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170828036
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1393,6 +1393,21 @@ object Aggreg
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r170828027
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala
---
@@ -0,0 +1,122 @@
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r173644062
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object Aggreg
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r173644059
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -0,0 +1,102 @@
+/*
69 matches
Mail list logo
