[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6386 ---

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204435941 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java --- @@ -504,6 +512,107 @@ public void

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204435027 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java --- @@ -504,6 +512,107 @@ public void

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204434452 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java --- @@ -323,7 +323,7 @@ public void

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204400729 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java --- @@ -504,6 +512,107 @@ public void

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204399866 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java --- @@ -504,6 +512,107 @@ public void

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204394265 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java --- @@ -384,6 +393,8 @@ private MultiTaskSlot(

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204384134 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -983,7 +983,7 @@ private void startCheckpointScheduler(final

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204373664 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java --- @@ -323,7 +323,7 @@ public void disconnectResourceManager()

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6386#discussion_r204368060 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java --- @@ -1011,7 +1011,7 @@ public void failAllocation(final

[GitHub] flink pull request #6386: [FLINK-9911][JM] Use SlotPoolGateway to call failA...

2018-07-22 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/6386 [FLINK-9911][JM] Use SlotPoolGateway to call failAllocation ## What is the purpose of the change Since the SlotPool is an actor, we must use the SlotPoolGateway to interact with