masteryhx closed pull request #23928: [FLINK-20772][State] Make
TtlValueState#update follow the description of interface about null values
URL: https://github.com/apache/flink/pull/23928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Zakelly commented on PR #23928:
URL: https://github.com/apache/flink/pull/23928#issuecomment-1857273442
@masteryhx Thanks so much for your review! I have update my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Zakelly commented on code in PR #23928:
URL: https://github.com/apache/flink/pull/23928#discussion_r1427540869
##
flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlValueStateTestContext.java:
##
@@ -21,14 +21,14 @@
import
masteryhx commented on code in PR #23928:
URL: https://github.com/apache/flink/pull/23928#discussion_r1427533090
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValueState.java:
##
@@ -48,7 +48,11 @@ public T value() throws IOException {
@Override
Zakelly commented on PR #23928:
URL: https://github.com/apache/flink/pull/23928#issuecomment-1855894096
@masteryhx Would you please to take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Zakelly commented on PR #23928:
URL: https://github.com/apache/flink/pull/23928#issuecomment-1855583922
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
flinkbot commented on PR #23928:
URL: https://github.com/apache/flink/pull/23928#issuecomment-1855354424
## CI report:
* 8b7dc770d95714c15529007ee011cd1ca2768fa3 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Zakelly opened a new pull request, #23928:
URL: https://github.com/apache/flink/pull/23928
## What is the purpose of the change
Currently, the TtlValueState#update will wrap the user value with timestamp
and proxy request to the original value state. It does not check the null
