ebdxflr commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2017413587
> > when is the next release planned?
>
> TBH, I'm not really sure. But I think we will probably release a series of
connectors that supporting `flink-1.19` in
reswqa commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2011649582
> when is the next release planned?
TBH, I'm not really sure. But I think we will probably release a series of
connectors that supporting flink-1.19 in the near
drorventura commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2011373385
when is the next release planned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
boring-cyborg[bot] commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2011167239
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message,
reswqa merged PR #53:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mtfelisb commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2009477539
> Thanks @mtfelisb, looks good to me. Could you please rebase and squash all
commits?
Thank you for the review, @reswqa! Just did it :)
--
This is an
drorventura commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2006807958
Thank you @mtfelisb
@reswqa could you please approve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mtfelisb commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1530090871
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java:
##
@@ -0,0 +1,107
drorventura commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1530068146
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java:
##
@@ -0,0
drorventura commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1530067738
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java:
##
@@ -0,0
reswqa commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1529874870
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java:
##
@@ -0,0 +1,107 @@
drorventura commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2006100743
Hi
Is this going to be merged soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
SpaceMiao commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1963974534
@mtfelisb Hi, I want read data from Kafka as byte[], but when i write these
byte[] to elasticsearch with your "Elasticsearch8AsyncSinkBuilder". Here are
some core
reta commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1487031922
##
flink-connector-elasticsearch8/pom.xml:
##
@@ -0,0 +1,141 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
mtfelisb commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1484848274
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriterITCase.java:
##
@@ -0,0
mtfelisb commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1483760795
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriterITCase.java:
##
@@ -0,0
mtfelisb commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1935170882
> > This pull request is working on every Flink version but `1.19-SNAPSHOT`
>
> I'm suspecting that's because of
Jiabao-Sun commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1482924435
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriterITCase.java:
##
@@ -0,0
Jiabao-Sun commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1934031525
> Hi, @MartijnVisser. I have a question regarding compatibility. This pull
request is working on every Flink version but `1.19-SNAPSHOT`. I've checked
[this
MartijnVisser commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1933568415
> This pull request is working on every Flink version but `1.19-SNAPSHOT`
I'm suspecting that's because of
mtfelisb commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1933166244
Hi, @MartijnVisser. I have a question regarding compatibility. This pull
request is working on every Flink version but `1.19-SNAPSHOT`. I've checked
[this
MartijnVisser commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1932071824
This PR is stale, closing this in favor of
https://github.com/apache/flink-connector-elasticsearch/pull/53
--
This is an automated message from the Apache Git
MartijnVisser closed pull request #74: [FLINK-26088][Connectors/ElasticSearch]
Add Elasticsearch 8.0 support
URL: https://github.com/apache/flink-connector-elasticsearch/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mtfelisb commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1479594864
##
flink-connector-elasticsearch8/pom.xml:
##
@@ -0,0 +1,139 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
snuyanzin commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1479350601
##
flink-connector-elasticsearch8/pom.xml:
##
@@ -0,0 +1,139 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
snuyanzin commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1479350601
##
flink-connector-elasticsearch8/pom.xml:
##
@@ -0,0 +1,139 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
snuyanzin commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1928954595
good to know, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reta commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1925311387
> Based on the info [1] it is no longer produced under Apache 2.0 license
after 7.10
The ES Java Client license is still Apache [1] (it is an exemption)
[1]
snuyanzin commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1925293405
I have a question about license
it looks like we don't have any info about Elastic 8.x in NOTICE, should we
add it or what is the best approach here?
--
This is
reta commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1924270597
@MartijnVisser @mtfelisb it looks great, I have no more comments, it would
be great to have e2e tests added but we could also do that in separate pull
request.
--
StefanXiepj commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1923495793
> @StefanXiepj Are you still active on this PR?
There are another
PR[53](https://github.com/apache/flink-connector-elasticsearch/pull/53) doing
it, i don't
EwaKabza commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1923397677
Hello,
My team cannot upgrade ES to v.8 because we need the connector. May I ask
about the status of this issue? Or maybe there are any workarounds?
--
This is
rinkako commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1862265394
> > @mtfelisb Are you still active on this PR?
>
> Hi, @MartijnVisser. Yes, I'm waiting for review. Also, I'll not implement
the `DynamicTableSink` because
mtfelisb commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1837517174
> @mtfelisb Are you still active on this PR?
Hi, @MartijnVisser. Yes, I'm waiting for review.
Also, I'll not implement the `DynamicTableSink` because @rinkako
MartijnVisser commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1827829202
@StefanXiepj Are you still active on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
MartijnVisser commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1827828796
@mtfelisb Are you still active on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
StefanXiepj commented on code in PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#discussion_r1378366427
##
flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8Sink.java:
##
@@ -0,0 +1,85 @@
liyubin117 commented on code in PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#discussion_r1378357036
##
flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8Sink.java:
##
@@ -0,0 +1,85 @@
liyubin117 commented on code in PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#discussion_r1377514898
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8SinkBaseITCase.java:
##
@@ -0,0
liyubin117 commented on code in PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#discussion_r1377503899
##
flink-connector-elasticsearch8/.gitignore:
##
@@ -0,0 +1,38 @@
+target/
+!.mvn/wrapper/maven-wrapper.jar
+!**/src/main/**/target/
reta commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1775197561
> @reta could you help with reviews if necessary?
@MartijnVisser absolutely, how would you like to proceed? I believe
@mtfelisb did a great job addressing all
MartijnVisser commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1775189892
> It's ok in my local env, both of compile and CI tests
Passed here too. @reta can you help with a review?
--
This is an automated message from the
StefanXiepj commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1775069034
> @StefanXiepj Can you first make sure that the CI passes?
>
> Edit: B too soon, looks like you hit an issue that was resolved a
while ago. Let me see if
StefanXiepj commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1775062906
> There's this PR and there's also #53 - We should try to find a way to
consolidate into one PR that can be merged
Yes, I am also waiting for the progress of
MartijnVisser commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1775000253
There's this PR and there's also
https://github.com/apache/flink-connector-elasticsearch/pull/53 - We should try
to find a way to consolidate into one PR that
MartijnVisser commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1774999640
There's now this PR by @mtfelisb and PR
https://github.com/apache/flink-connector-elasticsearch/pull/74 by @StefanXiepj
- How can we consolidate into one PR?
MartijnVisser commented on PR #74:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/74#issuecomment-1768146304
@StefanXiepj Can you first make sure that the CI passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mtfelisb commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1753824138
> hi @mtfelisb , I read the code and found that it has no implementation for
`DynamicTableSink`, hence this es8 sink cannot be used in flink-sql. Would you
have any
rinkako commented on PR #53:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1751562763
hi @mtfelisb , I read the code and found that it has no implementation for
`DynamicTableSink`, hence this es8 sink cannot be used in flink-sql. Would you
have any plan
49 matches
Mail list logo
