Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2024-01-03 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1440284283 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-12-28 Thread via GitHub
MartijnVisser commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1437683689 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-12-11 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1420783379 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-12-08 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1420783379 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-12-08 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1420783379 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-21 Thread via GitHub
grzegorz8 commented on PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#issuecomment-1821252252 > Hi @grzegorz8, thanks for your contribution. I left some comments > > but should be this PR on https://github.com/apache/flink-connector-elasticsearch ?? I

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-21 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1400851224 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-20 Thread via GitHub
MartijnVisser commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1399140949 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-20 Thread via GitHub
MartijnVisser commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1399140949 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-20 Thread via GitHub
MartijnVisser commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1399140949 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-20 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1399031136 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/elasticsearch/dialect/ElasticsearchDialect.java: ## @@ -0,0 +1,111 @@ +/* +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-20 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1399028810 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/testutils/databases/elasticsearch/ElasticsearchImages.java: ## @@ -0,0 +1,24 @@ +/* +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-20 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1399027968 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/testutils/databases/elasticsearch/ElasticsearchMetadata.java: ## @@ -0,0 +1,93 @@ +/*

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-17 Thread via GitHub
eskabetxe commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1397647438 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-10 Thread via GitHub
grzegorz8 commented on PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#issuecomment-1805376630 @eskabetxe Could you review the PR, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL