XComp merged PR #23515:
URL: https://github.com/apache/flink/pull/23515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jiabao-Sun commented on PR #23515:
URL: https://github.com/apache/flink/pull/23515#issuecomment-1769781479
Hi @XComp, backports is ready:
#23533
#23534
#23535
#23536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Jiabao-Sun commented on PR #23515:
URL: https://github.com/apache/flink/pull/23515#issuecomment-1767755901
> Can you create backports for this fix?
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
XComp commented on PR #23515:
URL: https://github.com/apache/flink/pull/23515#issuecomment-1767742697
Can you create backports for this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Jiabao-Sun commented on PR #23515:
URL: https://github.com/apache/flink/pull/23515#issuecomment-1766518801
> Sorry for not checking it earlier, but the same issue can happen in
`testCancelExecutionInNonInteractiveMode`. So, we could provide a fix to there
as well.
Thanks @XComp, but
Jiabao-Sun commented on code in PR #23515:
URL: https://github.com/apache/flink/pull/23515#discussion_r1361042492
##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java:
##
@@ -300,6 +303,8 @@ void testCancelExecutionInteractiveMode()
XComp commented on code in PR #23515:
URL: https://github.com/apache/flink/pull/23515#discussion_r1360500601
##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java:
##
@@ -311,6 +316,8 @@ void testCancelExecutionInteractiveMode()
Jiabao-Sun commented on PR #23515:
URL: https://github.com/apache/flink/pull/23515#issuecomment-1763676473
Hi @fsk119, could you help review this when you have time?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
flinkbot commented on PR #23515:
URL: https://github.com/apache/flink/pull/23515#issuecomment-1759059406
## CI report:
* acb4dfd1144735ee8d6602d363d71a086f2ac6f9 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Jiabao-Sun commented on PR #23515:
URL: https://github.com/apache/flink/pull/23515#issuecomment-1759051781
Hi @XComp, could you please help review this?
Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jiabao-Sun opened a new pull request, #23515:
URL: https://github.com/apache/flink/pull/23515
## What is the purpose of the change
[FLINK-33116][tests] Fix CliClientTest.testCancelExecutionInteractiveMode
fails with NPE
```shell
Sep 18 02:26:15 02:26:15.743 [ERROR]
11 matches
Mail list logo
