Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-06 Thread via GitHub
libenchao closed pull request #23849: [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway URL: https://github.com/apache/flink/pull/23849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-06 Thread via GitHub
libenchao commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416960738 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceStatementITCase.java: ## @@ -52,18 +59,49 @@ /** Test {@link

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-06 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416957349 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceStatementITCase.java: ## @@ -52,18 +59,49 @@ /** Test {@link

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-06 Thread via GitHub
libenchao commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416956966 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/PlanCacheManager.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-06 Thread via GitHub
libenchao commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416954073 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceStatementITCase.java: ## @@ -52,18 +59,49 @@ /** Test {@link

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-06 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416948569 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/PlanCacheManager.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-06 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416945039 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceStatementITCase.java: ## @@ -52,18 +59,49 @@ /** Test {@link

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
libenchao commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416754135 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/SessionContext.java: ## @@ -136,6 +158,10 @@ public URLClassLoader

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416588553 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider {

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416588553 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider {

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1415242114 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider {

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1415242114 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider {

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-04 Thread via GitHub
libenchao commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1414825282 ## flink-table/flink-sql-gateway/src/test/resources/sql/repeated_dql.q: ## @@ -0,0 +1,220 @@ +# statement-set.q - BEGIN STATEMENT SET, END Review Comment: You

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23849: URL: https://github.com/apache/flink/pull/23849#issuecomment-1835607763 ## CI report: * ef24fc5d7376102ac47fe8e4f12fef9af7a53682 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-11-30 Thread via GitHub
zoudan opened a new pull request, #23849: URL: https://github.com/apache/flink/pull/23849 ## What is the purpose of the change Support plan cache for DQL in SQL Gateway, so that we could reuse the plan and save time on SQL parsing, validation, and optimization. ## Brief change