Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-12-04 Thread via GitHub
echauchot merged PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-12-03 Thread via GitHub
snuyanzin commented on code in PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#discussion_r1413196788 ## pom.xml: ## @@ -558,6 +563,8 @@ under the License. US en

Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-12-01 Thread via GitHub
echauchot commented on code in PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#discussion_r1412014261 ## pom.xml: ## @@ -558,6 +563,8 @@ under the License. US en

Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-12-01 Thread via GitHub
echauchot commented on PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#issuecomment-1835994166 >> @snuyanzin can you elaborate on the use cases you have in mind for systemPropertyVariable surefire.module.config ? > The use case is testing against jdk17/21

Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-12-01 Thread via GitHub
snuyanzin commented on PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#issuecomment-1835851027 The use case is testing against jdk17/21 The issue with these jdks is that sometimes it is from one side required to add `add-opens/export` flags for tests like it

Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-11-30 Thread via GitHub
echauchot commented on PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#issuecomment-1834048030 @snuyanzin can you elaborate on the use cases you have in mind for systemPropertyVariable surefire.module.config ? -- This is an automated message from the Apache

[PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-10-18 Thread via GitHub
snuyanzin opened a new pull request, #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25 The idea is to apply same approach as for Flink main repo and it's modules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to