Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-04-08 Thread via GitHub
RocMarshal commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-2042712930 Thanks everybody related for the pr. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-04-08 Thread via GitHub
boring-cyborg[bot] commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-2042575379 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-04-08 Thread via GitHub
snuyanzin merged PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-04-08 Thread via GitHub
snuyanzin commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-2042573923 thanks @RocMarshal for the hard work thanks a lot everyone for the review -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-04-08 Thread via GitHub
Jiabao-Sun commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1448844127 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSourceOptions.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-04-08 Thread via GitHub
RocMarshal commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-2042297264 Thank you @eskabetxe @caicancai very much for the review. CC @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-03-26 Thread via GitHub
snuyanzin commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-2020733326 @davidradl @eskabetxe could you please have another look here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-03-22 Thread via GitHub
RocMarshal commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-2016325794 Thank you @snuyanzin for the review. I made some change based on your comments~ -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-03-22 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1536549280 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/reader/JdbcSourceSplitReader.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-03-22 Thread via GitHub
snuyanzin commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1535501299 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/reader/JdbcSourceSplitReader.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-03-22 Thread via GitHub
snuyanzin commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1535498978 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSourceBuilder.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-03-18 Thread via GitHub
RocMarshal commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-2005697292 Hi, @snuyanzin would you mind helping take a look ? thank you very much~ -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441484531 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441475081 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441475081 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441300360 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/reader/extractor/ResultExtractor.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441300360 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/reader/extractor/ResultExtractor.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-1876318089 Hi， @eskabetxe Thank you very much for the review. And I left some discussion items for your comments. Please let me know what's your opinion~ :) -- This is an

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441300360 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/reader/extractor/ResultExtractor.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441299767 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSourceBuilder.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441298453 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1440197286 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSourceBuilder.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-12-28 Thread via GitHub
RocMarshal commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-1870955620 Hi, @Jiabao-Sun Would you mind helping take a look on this pr ? thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-27 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1405924661 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-27 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1405924661 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-27 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1405917676 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/Utils.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397421543 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397421543 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397395729 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcInputFormat.java: ## @@ -99,7 +99,11 @@ * @see JdbcParameterValuesProvider *

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397218900 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcInputFormat.java: ## @@ -99,7 +99,11 @@ * @see JdbcParameterValuesProvider *

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-05 Thread via GitHub
boring-cyborg[bot] commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-1793683582 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-05 Thread via GitHub
RocMarshal opened a new pull request, #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78 # Main change - [FLINK-33459][Connector/JDBC] Add dependency items about flink-connector-base and testing into the pom.xml - [FLINK-33459][Connector/JDBC] Support the new source