Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2024-04-22 Thread via GitHub
MartijnVisser commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-2068667425 Most likely we'll have to rewrite/reimplement the entire Hadoop-based filesystem implementations, since they've moved from the V1 API to the V2 API for the AWS SDK. So either upgrad

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2024-04-22 Thread via GitHub
MartijnVisser commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-2068660231 > Could we resolve this by the solution See the comment above; how would you resolve the situation? -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2024-04-21 Thread via GitHub
masteryhx commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-2068360164 Hi, just kindly ping. Could we resolve this by the solution metioned by @MartijnVisser ? We tried to use positionable read with ByteBuffer on hadoop to imporve the performance but fo

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-12-28 Thread via GitHub
MartijnVisser commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-1871212810 Summary of the situation per @snuyanzin as discussed offline: > seems this [HADOOP-18382](https://issues.apache.org/jira/browse/HADOOP-18382) broke work of previous upgrades

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-12-02 Thread via GitHub
MartijnVisser commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-1837112592 I'll run the S3 tests locally before merging it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-12-01 Thread via GitHub
snuyanzin commented on code in PR #23844: URL: https://github.com/apache/flink/pull/23844#discussion_r1412350731 ## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java: ## @@ -68,7 +68,7 @@ public HadoopS3AccessHelper(S3AFile

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-12-01 Thread via GitHub
MartijnVisser commented on PR #23740: URL: https://github.com/apache/flink/pull/23740#issuecomment-1835845313 Superseded by https://github.com/apache/flink/pull/23844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-12-01 Thread via GitHub
MartijnVisser closed pull request #23740: [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 URL: https://github.com/apache/flink/pull/23740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
JingGe commented on code in PR #23844: URL: https://github.com/apache/flink/pull/23844#discussion_r1411611276 ## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java: ## @@ -84,13 +84,14 @@ public UploadPartResult uploadPart(

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-1833806488 ## CI report: * db953b7ab86a704cc8393bc6e813cf8ae310cd41 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
snuyanzin commented on code in PR #23844: URL: https://github.com/apache/flink/pull/23844#discussion_r1410685019 ## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java: ## @@ -68,7 +68,7 @@ public HadoopS3AccessHelper(S3AFile

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
snuyanzin commented on code in PR #23844: URL: https://github.com/apache/flink/pull/23844#discussion_r1410685672 ## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java: ## @@ -84,13 +84,14 @@ public UploadPartResult uploadPar

[PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
snuyanzin opened a new pull request, #23844: URL: https://github.com/apache/flink/pull/23844 ## What is the purpose of the change This is the PR superceding https://github.com/apache/flink/pull/23740 by adopting hadoop api change usage ## Brief change log * cherry-pick f

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
MartijnVisser commented on PR #23740: URL: https://github.com/apache/flink/pull/23740#issuecomment-1833315378 Feel free to ping me for a review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
MartijnVisser commented on PR #23740: URL: https://github.com/apache/flink/pull/23740#issuecomment-1833304430 > @MartijnVisser do you mind if I continue here or are you still working on this? If you could take it over, that would be great. -- This is an automated message from the

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-29 Thread via GitHub
snuyanzin commented on PR #23740: URL: https://github.com/apache/flink/pull/23740#issuecomment-1832862274 @MartijnVisser do you mind if I continue here or are you still working on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23740: URL: https://github.com/apache/flink/pull/23740#issuecomment-1816040944 ## CI report: * 843f50b982f61f84b92bead8912e35ac4b837eeb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-17 Thread via GitHub
MartijnVisser opened a new pull request, #23740: URL: https://github.com/apache/flink/pull/23740 ## What is the purpose of the change * Update Hadoop Filesystem dependencies to 3.3.6 ## Brief change log * Updated POM and NOTICE files ## Verifying this change