pnowojski opened a new pull request, #23845:
URL: https://github.com/apache/flink/pull/23845
## What is the purpose of the change
This PR adds a concept of `Span` and `TraceReporter` and uses that to report
checkpointing traces.
## Brief change log
Please check individua
flinkbot commented on PR #23845:
URL: https://github.com/apache/flink/pull/23845#issuecomment-1833924058
## CI report:
* 40ca70685630bfc2173a6375f56781edceda00d7 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
rkhachatryan commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1417402466
##
docs/content/docs/ops/traces.md:
##
@@ -0,0 +1,126 @@
+---
+title: "Metrics"
+weight: 6
+type: docs
+aliases:
+ - /ops/traces.html
+ - /apis/traces.html
+ -
rkhachatryan commented on PR #23845:
URL: https://github.com/apache/flink/pull/23845#issuecomment-1843011650
One more thing, all the documentation changes only affect the English
version.
Should we also update the Chinese version (with the same content in English)?
--
This is an automa
pnowojski commented on PR #23845:
URL: https://github.com/apache/flink/pull/23845#issuecomment-1843111206
> Should we also update the Chinese version (with the same content in
English)?
Yes, it was my implicit plan to first review the English version and after 👍
it, copy paste the ch
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1417512998
##
docs/content/docs/ops/traces.md:
##
@@ -0,0 +1,126 @@
+---
+title: "Metrics"
+weight: 6
+type: docs
+aliases:
+ - /ops/traces.html
+ - /apis/traces.html
+ - /mo
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1417516719
##
docs/content/docs/ops/traces.md:
##
@@ -0,0 +1,126 @@
+---
+title: "Metrics"
+weight: 6
+type: docs
+aliases:
+ - /ops/traces.html
+ - /apis/traces.html
+ - /mo
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1417523981
##
docs/layouts/shortcodes/generated/akka_configuration.html:
##
@@ -98,6 +80,24 @@
Duration
Timeout used for the lookup of the JobManager.
rkhachatryan commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1417895747
##
flink-metrics/flink-metrics-slf4j/src/main/java/org/apache/flink/traces/slf4j/Slf4jTraceReporter.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Softwa
rkhachatryan commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1417918412
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418691746
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418691746
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418691746
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
zentol commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418790359
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+# Tra
zentol commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418790359
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+# Tra
zentol commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418790359
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+# Tra
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on code in PR #23845:
URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358
##
docs/content/docs/deployment/config.md:
##
@@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded
performance and should be s
+#
pnowojski commented on PR #23845:
URL: https://github.com/apache/flink/pull/23845#issuecomment-1847308697
Thanks for the review, merging.
Test failure was an unrelated issue on the master branch: FLINK-33480
--
This is an automated message from the Apache Git Service.
To respond to
pnowojski merged PR #23845:
URL: https://github.com/apache/flink/pull/23845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apa
25 matches
Mail list logo
