Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-28 Thread via GitHub
qinf commented on code in PR #23867: URL: https://github.com/apache/flink/pull/23867#discussion_r1437967171 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategyTest.java: ## @@ -214,28 +266,111 @@ void testMul

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-28 Thread via GitHub
qinf commented on PR #23867: URL: https://github.com/apache/flink/pull/23867#issuecomment-1871704522 @1996fanrui Thanks for the PR, LGTM. I just have one comment, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-28 Thread via GitHub
1996fanrui commented on code in PR #23867: URL: https://github.com/apache/flink/pull/23867#discussion_r1438066538 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategyTest.java: ## @@ -214,28 +266,111 @@ void t

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-29 Thread via GitHub
RocMarshal commented on code in PR #23867: URL: https://github.com/apache/flink/pull/23867#discussion_r1438455564 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategy.java: ## Review Comment: how about

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-29 Thread via GitHub
1996fanrui commented on code in PR #23867: URL: https://github.com/apache/flink/pull/23867#discussion_r1438458380 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategy.java: ## Review Comment: Thanks @RocM

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-29 Thread via GitHub
RocMarshal commented on code in PR #23867: URL: https://github.com/apache/flink/pull/23867#discussion_r1438460593 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategy.java: ## Review Comment: @1996fanrui

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2024-01-07 Thread via GitHub
1996fanrui merged PR #23867: URL: https://github.com/apache/flink/pull/23867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-04 Thread via GitHub
flinkbot commented on PR #23867: URL: https://github.com/apache/flink/pull/23867#issuecomment-1838643861 ## CI report: * 5893482f65cac8f6c57680366a8d377bbbcaa8fe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`