Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-02-01 Thread via GitHub
XComp merged PR #24132: URL: https://github.com/apache/flink/pull/24132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-30 Thread via GitHub
XComp commented on PR #24132: URL: https://github.com/apache/flink/pull/24132#issuecomment-1916845790 Ok, looks like the timeout was caused by some changes to the MockServer (which was moved into the `kubernetes-client` repository). The mocked GET request contains some parameters. Th

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-29 Thread via GitHub
XComp commented on PR #24132: URL: https://github.com/apache/flink/pull/24132#issuecomment-1915730926 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-29 Thread via GitHub
XComp commented on PR #24132: URL: https://github.com/apache/flink/pull/24132#issuecomment-1915730800 hm, the [CI timeout](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=57072&view=logs&j=fc5181b0-e452-5c8f-68de-1097947f6483&t=995c650b-6573-581c-9ce6-7ad4cc038461&l=27

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-29 Thread via GitHub
XComp commented on PR #24132: URL: https://github.com/apache/flink/pull/24132#issuecomment-1914754366 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-29 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469397883 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-29 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467590709 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-29 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469394774 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +106,33 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-29 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469392396 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -55,17 +59,32 @@ public class KubernetesLeaderElect

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-28 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469124707 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +106,33 @@ public KubernetesLeaderEle

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-28 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469121295 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -55,17 +59,32 @@ public class KubernetesLead

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-28 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469047743 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderEle

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-28 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469043488 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderEle

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467610608 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467610608 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467590709 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467583895 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderEle

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467582561 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467574472 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderEle

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467574472 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderEle

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467558102 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467558102 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public KubernetesLeaderElector(

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-26 Thread via GitHub
XComp commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467504153 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElectorITCase.java: ## @@ -110,4 +114,67 @@ void testMultipleKubernetes

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-25 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467160375 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElectorITCase.java: ## @@ -110,4 +114,67 @@ void testMultipleKub

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-25 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467160375 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElectorITCase.java: ## @@ -110,4 +114,67 @@ void testMultipleKub

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-23 Thread via GitHub
XComp commented on PR #24132: URL: https://github.com/apache/flink/pull/24132#issuecomment-1907572028 [ci failure](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=56790) is caused by some infrastructure instability in the compile step of the c

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-23 Thread via GitHub
XComp commented on PR #24132: URL: https://github.com/apache/flink/pull/24132#issuecomment-1907572233 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24132: URL: https://github.com/apache/flink/pull/24132#issuecomment-1898519756 ## CI report: * 1193ea4f3deff5b3d7ba7510910fd77059ff46f2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-18 Thread via GitHub
XComp opened a new pull request, #24132: URL: https://github.com/apache/flink/pull/24132 tbd ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o