Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-07-11 Thread via GitHub
lincoln-lil commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1674142139 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -431,6 +431,26 @@ ANY, and(logical(LogicalTy

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-07-10 Thread via GitHub
snuyanzin merged PR #24773: URL: https://github.com/apache/flink/pull/24773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-07-04 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2208669198 > @superdiaodiao can you please rebase to the recent master's version, I think it will help with ci? OK, I will rebase. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-07-03 Thread via GitHub
snuyanzin commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2208233514 @lincoln-lil thanks for having a look please let us know if there is anything that should be fixed from your point of view I'm asking since i'm going to merge it at the end of

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-24 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2185785024 > As it was mentioned earlier there is feature freeze currently https://lists.apache.org/thread/ftj0mcs2843yrx1tog9lfhfrbzkrbfvp so need to wait OK, get your point. Thanks!

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-23 Thread via GitHub
snuyanzin commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2185697062 As it was mentioned earlier there is feature freeze currently https://lists.apache.org/thread/ftj0mcs2843yrx1tog9lfhfrbzkrbfvp so need to wait -- This is an automated message fr

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-23 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2185009821 > Yep, sorry, testing took a bit longer, than expected however it looks ok .. > UPD: currently there is a feature freeze, let's wait until it will be ended Hey, may I

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2172705717 Yep, sorry, testing took a bit longer, than expected however it looks ok >db2 https://www.ibm.com/docs/en/db2-for-zos/12?topic=functions-urlencode-urldecode >max compute https:

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-17 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2172455196 > Thanks for the contribution @superdiaodiao thanks for the review @HuangXingBo , @davidradl > > it looks ok to me, I will test it a bit more and in case of succeed will merg

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-10 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2159830832 > hi @snuyanzin @superdiaodiao do we need supports encoding args ? > db2 https://www.ibm.com/docs/en/db2-for-zos/12?topic=functions-urlencode-urldecode > max compute https://w

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-10 Thread via GitHub
liuyongvs commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2159808362 hi @snuyanzin @superdiaodiao do we need supports encoding args ? db2 https://www.ibm.com/docs/en/db2-for-zos/12?topic=functions-urlencode-urldecode max compute https://www.alibaba

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-09 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2157065404 > Thanks for the contribution @superdiaodiao > thanks for the review @HuangXingBo , @davidradl > > it looks ok to me, I will test it a bit more and in case of succeed will

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-09 Thread via GitHub
snuyanzin commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2156817722 Thanks for the contribution @superdiaodiao thanks for the review @HuangXingBo , @davidradl it looks ok to me, I will test it a bit more and in case of succeed will merge it

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-05 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2149090542 @snuyanzin @MartijnVisser @HuangXingBo please take a look~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-01 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1623199122 ## flink-python/pyflink/table/expression.py: ## @@ -1273,6 +1273,23 @@ def locate(self, s: Union[str, 'Expression[str]'], else: return _tern

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-28 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1617259220 ## flink-python/pyflink/table/expression.py: ## @@ -1273,6 +1273,23 @@ def locate(self, s: Union[str, 'Expression[str]'], else: return _ternary_

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-28 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1617259958 ## flink-python/pyflink/table/expression.py: ## @@ -1273,6 +1273,23 @@ def locate(self, s: Union[str, 'Expression[str]'], else: return _ternary_

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-28 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1617256860 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-28 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1617256004 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-28 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2135157310 @snuyanzin @MartijnVisser @HuangXingBo PLZ take a look~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-24 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611984504 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611984504 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611984504 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611921523 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611921523 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611921523 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611771105 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
MartijnVisser commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611754275 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611739983 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611415054 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
MartijnVisser commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611365062 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611361668 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611289713 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611218326 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611218326 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611157801 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-23 Thread via GitHub
HuangXingBo commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611129401 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-22 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1610884892 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-22 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1610775137 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606776660 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606752091 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606749183 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606749183 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-16 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1603144242 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-16 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1603142936 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-16 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1603139590 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-16 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1603094671 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-16 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1603093845 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-16 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1603092403 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-16 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1603091969 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599601719 ## docs/data/sql_functions.yml: ## @@ -350,6 +350,17 @@ string: - sql: LOCATE(string1, string2[, integer]) table: STRING1.locate(STRING2[, INTEGER])

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599601719 ## docs/data/sql_functions.yml: ## @@ -350,6 +350,17 @@ string: - sql: LOCATE(string1, string2[, integer]) table: STRING1.locate(STRING2[, INTEGER])

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599618108 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599601719 ## docs/data/sql_functions.yml: ## @@ -350,6 +350,17 @@ string: - sql: LOCATE(string1, string2[, integer]) table: STRING1.locate(STRING2[, INTEGER])

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599573380 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599570453 ## docs/data/sql_functions.yml: ## @@ -350,6 +350,17 @@ string: - sql: LOCATE(string1, string2[, integer]) table: STRING1.locate(STRING2[, INTEGER])

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599570079 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599518712 ## docs/data/sql_functions.yml: ## @@ -350,6 +350,17 @@ string: - sql: LOCATE(string1, string2[, integer]) table: STRING1.locate(STRING2[, INTEGER]) desc

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599518712 ## docs/data/sql_functions.yml: ## @@ -350,6 +350,17 @@ string: - sql: LOCATE(string1, string2[, integer]) table: STRING1.locate(STRING2[, INTEGER]) desc

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599510644 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-14 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599507811 ## docs/data/sql_functions.yml: ## @@ -350,6 +350,17 @@ string: - sql: LOCATE(string1, string2[, integer]) table: STRING1.locate(STRING2[, INTEGER]) desc

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2107498923 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2107400121 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598298446 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2107243083 > Thanks for your contribution @superdiaodiao , I left some comments > > also ci is failed and i tend to think it is related to your changes in python code, could you please h

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598263115 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598262984 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598262631 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
snuyanzin commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2107229466 Thanks for your contribution @superdiaodiao , I left some comments also ci is failed and i tend to think it is related to your changes in python code, could you please have a l

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598253206 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598251586 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/UrlFunctionsITCase.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598248764 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598243697 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598239270 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598238010 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598236936 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-13 Thread via GitHub
snuyanzin commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1598224511 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-12 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2106260978 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-12 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2106248298 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-12 Thread via GitHub
flinkbot commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2106247014 ## CI report: * d7b8727596cda8b1feb6edb3c465043ed764fa4c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-12 Thread via GitHub
superdiaodiao opened a new pull request, #24773: URL: https://github.com/apache/flink/pull/24773 ## What is the purpose of the change This is an implementation of URL_ENCODE and URL_DECODE 1. URL_ENCODE: Translates a string into 'application/x-www-form-urlencoded' forma