Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-09-16 Thread via GitHub
XComp commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1760917678 ## flink-tests/src/test/resources/log4j2-test.properties: ## @@ -28,7 +28,7 @@ appender.testlogger.name = TestLogger appender.testlogger.type = CONSOLE appender.testlog

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-08 Thread via GitHub
rkhachatryan merged PR #24292: URL: https://github.com/apache/flink/pull/24292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-08 Thread via GitHub
rkhachatryan commented on PR #24292: URL: https://github.com/apache/flink/pull/24292#issuecomment-1985585478 Re-ran benchmarks - no regressions found: [jmh-result-runtime.csv](https://github.com/apache/flink/files/14537980/jmh-result-runtime.csv) [jmh-result-scheduler.csv](https://git

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-06 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1514899954 ## flink-core/src/main/java/org/apache/flink/util/MdcAwareScheduledExecutorService.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-06 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1514881575 ## flink-core/src/main/java/org/apache/flink/util/MdcUtils.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-06 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1514408450 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -1662,6 +1667,7 @@ private class TaskCanceler implements Runnable { @

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-06 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1514408118 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -303,7 +308,8 @@ public void onUnknownDeploymentsOf( this.highAvai

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-06 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1514170487 ## flink-tests/pom.xml: ## @@ -44,7 +44,14 @@ under the License. - + + org.apache.logging.log4j +

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-06 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1514074926 ## flink-core/src/main/java/org/apache/flink/util/MdcAwareScheduledExecutorService.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-05 Thread via GitHub
rkhachatryan commented on PR #24292: URL: https://github.com/apache/flink/pull/24292#issuecomment-1979884146 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-05 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1513528600 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java: ## @@ -903,22 +907,28 @@ private Stream filterPartitionsRequiringRel public

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-05 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1513218720 ## flink-tests/src/test/resources/log4j2-test.properties: ## @@ -28,7 +28,7 @@ appender.testlogger.name = TestLogger appender.testlogger.type = CONSOLE appender.

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-05 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1513218720 ## flink-tests/src/test/resources/log4j2-test.properties: ## @@ -28,7 +28,7 @@ appender.testlogger.name = TestLogger appender.testlogger.type = CONSOLE appender.

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-05 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1513207066 ## flink-tests/src/test/resources/log4j2-test.properties: ## @@ -28,7 +28,7 @@ appender.testlogger.name = TestLogger appender.testlogger.type = CONSOLE appender.testlo

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-03-05 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1512543707 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java: ## @@ -1266,15 +1282,21 @@ public CompletableFuture freeSlot( @Override

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491395312 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutorService.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491387438 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutor.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491387018 ## flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491016717 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcGateway.java: ## @@ -34,4 +34,16 @@ public interface RpcGateway { * @return Fully q

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491013640 ## docs/content.zh/docs/deployment/advanced/logging.md: ## @@ -40,6 +40,21 @@ Flink 中的日志记录是使用 [SLF4J](http://www.slf4j.org/) 日志接口实 +### Structured logging +

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489262074 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/MainThreadValidatorUtil.java: ## @@ -45,11 +45,13 @@ public MainThreadValidatorUtil(RpcEndpoint en

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489259793 ## flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489259793 ## flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489259263 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcGateway.java: ## @@ -34,4 +34,16 @@ public interface RpcGateway { * @return Fully qualifi

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489257016 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutor.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489255700 ## docs/content.zh/docs/deployment/advanced/logging.md: ## @@ -40,6 +40,21 @@ Flink 中的日志记录是使用 [SLF4J](http://www.slf4j.org/) 日志接口实 +### Structured logging + +Flink

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1486799769 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java: ## @@ -1266,15 +1282,21 @@ public CompletableFuture freeSlot( @Overr

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1486809430 ## flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1486799769 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java: ## @@ -1266,15 +1282,21 @@ public CompletableFuture freeSlot( @Overr

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1486795898 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcGateway.java: ## @@ -34,4 +34,16 @@ public interface RpcGateway { * @return Fully q

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1486789947 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/MainThreadValidatorUtil.java: ## @@ -45,11 +45,13 @@ public MainThreadValidatorUtil(RpcEndpo

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1486782437 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutor.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1486776195 ## docs/content.zh/docs/deployment/advanced/logging.md: ## @@ -40,6 +40,21 @@ Flink 中的日志记录是使用 [SLF4J](http://www.slf4j.org/) 日志接口实 +### Structured logging +

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485910818 ## flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485908014 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java: ## @@ -1266,15 +1282,21 @@ public CompletableFuture freeSlot( @Override

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485904612 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcGateway.java: ## @@ -34,4 +34,16 @@ public interface RpcGateway { * @return Fully qualifi

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485902184 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/MainThreadValidatorUtil.java: ## @@ -45,11 +45,13 @@ public MainThreadValidatorUtil(RpcEndpoint en

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485888366 ## flink-core/src/main/java/org/apache/flink/util/MdcUtils.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485888366 ## flink-core/src/main/java/org/apache/flink/util/MdcUtils.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485887114 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingScheduledExecutorService.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485886746 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutorService.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485886510 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutor.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485884759 ## docs/content.zh/docs/deployment/advanced/logging.md: ## @@ -40,6 +40,21 @@ Flink 中的日志记录是使用 [SLF4J](http://www.slf4j.org/) 日志接口实 +### Structured logging + +Flink

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-10 Thread via GitHub
rkhachatryan commented on PR #24292: URL: https://github.com/apache/flink/pull/24292#issuecomment-1936944954 The failure is unrelated: FLINK-34420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-09 Thread via GitHub
rkhachatryan commented on PR #24292: URL: https://github.com/apache/flink/pull/24292#issuecomment-1936575490 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-09 Thread via GitHub
rkhachatryan commented on PR #24292: URL: https://github.com/apache/flink/pull/24292#issuecomment-1936234814 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-09 Thread via GitHub
rkhachatryan commented on PR #24292: URL: https://github.com/apache/flink/pull/24292#issuecomment-1935958746 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-08 Thread via GitHub
flinkbot commented on PR #24292: URL: https://github.com/apache/flink/pull/24292#issuecomment-1934796687 ## CI report: * 605d23d07cc51916ac746b9760a400dd363c0044 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-08 Thread via GitHub
rkhachatryan opened a new pull request, #24292: URL: https://github.com/apache/flink/pull/24292 ## What is the purpose of the change Add Flink JobID to logging MDC to make analysing the logs easier. ## Verifying this change - added `JobIdLoggingMainThreadExecu