[PR] [FLINK-34954][core] Kryo Input bug fix [flink]

2024-03-28 Thread via GitHub
qinghui-xu opened a new pull request, #24586: URL: https://github.com/apache/flink/pull/24586 Handle edge case of zero length serialized bytes correctly. ## What is the purpose of the change Bug fix in kryo (NoFetching)Input implementation to handle properly zero length

Re: [PR] [FLINK-34954][core] Kryo Input bug fix [flink]

2024-03-28 Thread via GitHub
flinkbot commented on PR #24586: URL: https://github.com/apache/flink/pull/24586#issuecomment-2024784567 ## CI report: * a37e562b54ed9ad4b9290f2f999542ea9104c65f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34954][core] Kryo Input bug fix [flink]

2024-04-05 Thread via GitHub
qinghui-xu commented on PR #24586: URL: https://github.com/apache/flink/pull/24586#issuecomment-2039567737 Hello team, Could I get a review for this, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-34954][core] Kryo Input bug fix [flink]

2024-04-19 Thread via GitHub
dannycranmer merged PR #24586: URL: https://github.com/apache/flink/pull/24586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-34954][core] Kryo Input bug fix [flink]

2024-04-29 Thread via GitHub
davidradl commented on code in PR #24586: URL: https://github.com/apache/flink/pull/24586#discussion_r1582776111 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java: ## @@ -73,17 +73,14 @@ protected int require(int required) throws KryoEx

Re: [PR] [FLINK-34954][core] Kryo Input bug fix [flink]

2024-05-21 Thread via GitHub
dmvk commented on PR #24586: URL: https://github.com/apache/flink/pull/24586#issuecomment-2122091374 Why is this not covered with a regression test? That feels rather scary in such a critical part of the stack. -- This is an automated message from the Apache Git Service. To respond to the