1996fanrui commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1612625523
##
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##
@@ -114,18 +117,26 @@ public void readBytes(byte[] bytes, int
uce commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1611505197
##
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##
@@ -114,18 +117,26 @@ public void readBytes(byte[] bytes, int offset, int
1996fanrui merged PR #24717:
URL: https://github.com/apache/flink/pull/24717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #24717:
URL: https://github.com/apache/flink/pull/24717#issuecomment-2103767266
> Sorry for the confusing sentence. I meant that skipping the `try/catch`
block would save a lot of cycles, but your change that causes it to be
(correctly) skipped when the count is
kkrugler commented on PR #24717:
URL: https://github.com/apache/flink/pull/24717#issuecomment-2103761403
Sorry for the confusing sentence. I meant that skipping the `try/catch`
block would save a lot of cycles, but your change that causes it to be
(correctly) skipped when the count is 0
1996fanrui commented on PR #24717:
URL: https://github.com/apache/flink/pull/24717#issuecomment-2103722015
> I'm leaving in 2 days for a 4+ month backpack trip (hiking the PCT)
Wow, have a nice trip!
> To respond to the particular comment on why performance changed:
>
>
kkrugler commented on PR #24717:
URL: https://github.com/apache/flink/pull/24717#issuecomment-2100600574
I'm leaving in 2 days for a 4+ month backpack trip (hiking the PCT),
otherwise what I'd do is try to hook up a test that uses JMH to accurately
assess the impact of the change. To
1996fanrui commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1593318508
##
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##
@@ -114,18 +117,26 @@ public void readBytes(byte[] bytes, int
1996fanrui commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1593316335
##
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##
@@ -114,18 +117,26 @@ public void readBytes(byte[] bytes, int
1996fanrui commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1579104254
##
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##
@@ -65,6 +65,10 @@ public boolean canReadLong() throws
1996fanrui commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1579104254
##
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##
@@ -65,6 +65,10 @@ public boolean canReadLong() throws
reswqa commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1579092286
##
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##
@@ -114,18 +121,26 @@ public void readBytes(byte[] bytes, int offset,
1996fanrui commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1579063045
##
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##
@@ -114,18 +121,26 @@ public void readBytes(byte[] bytes, int
reswqa commented on PR #24717:
URL: https://github.com/apache/flink/pull/24717#issuecomment-2076333034
Not to block this, just curious do you know why FLINK-34954 affects
performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
flinkbot commented on PR #24717:
URL: https://github.com/apache/flink/pull/24717#issuecomment-2076272429
## CI report:
* f09de068978ccc147fffc47925232b7bfeb1f584 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
15 matches
Mail list logo
