robobario opened a new pull request, #24491:
URL: https://github.com/apache/flink/pull/24491
## What is the purpose of the change
This pull request aims to make end-to-end test scripts that source
`common_s3_operations.sh` fail fast if the aws cli container fails to start. It
also ad
robobario commented on code in PR #24491:
URL: https://github.com/apache/flink/pull/24491#discussion_r1524015981
##
flink-end-to-end-tests/test-scripts/common_s3_operations.sh:
##
@@ -29,12 +29,18 @@
# AWSCLI_CONTAINER_ID
###
function aws_cli
flinkbot commented on PR #24491:
URL: https://github.com/apache/flink/pull/24491#issuecomment-1996064367
## CI report:
* 119cd86a12b4d65ed43000f58df4a423f9e2aae7 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
JingGe commented on code in PR #24491:
URL: https://github.com/apache/flink/pull/24491#discussion_r1525296378
##
flink-end-to-end-tests/test-scripts/common_s3_operations.sh:
##
@@ -58,7 +64,11 @@ function aws_cli_stop() {
if [[ $AWSCLI_CONTAINER_ID ]]; then
aws_cli_stop
fi
JingGe commented on code in PR #24491:
URL: https://github.com/apache/flink/pull/24491#discussion_r1525296378
##
flink-end-to-end-tests/test-scripts/common_s3_operations.sh:
##
@@ -58,7 +64,11 @@ function aws_cli_stop() {
if [[ $AWSCLI_CONTAINER_ID ]]; then
aws_cli_stop
fi
robobario commented on code in PR #24491:
URL: https://github.com/apache/flink/pull/24491#discussion_r1525716429
##
flink-end-to-end-tests/test-scripts/common_s3_operations.sh:
##
@@ -58,7 +64,11 @@ function aws_cli_stop() {
if [[ $AWSCLI_CONTAINER_ID ]]; then
aws_cli_stop
robobario commented on code in PR #24491:
URL: https://github.com/apache/flink/pull/24491#discussion_r1527607029
##
flink-end-to-end-tests/test-scripts/common_s3_operations.sh:
##
@@ -58,7 +64,11 @@ function aws_cli_stop() {
if [[ $AWSCLI_CONTAINER_ID ]]; then
aws_cli_stop
rmetzger merged PR #24491:
URL: https://github.com/apache/flink/pull/24491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
