Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-13 Thread via GitHub
zoltar9264 commented on PR #24928: URL: https://github.com/apache/flink/pull/24928#issuecomment-2167344359 This fix already as a part of [PR-24933](https://github.com/apache/flink/pull/24933), so close this pr. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-13 Thread via GitHub
zoltar9264 closed pull request #24928: [hotfix][checkpointing] Normalize file-merging sub dir URL: https://github.com/apache/flink/pull/24928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
zoltar9264 commented on code in PR #24928: URL: https://github.com/apache/flink/pull/24928#discussion_r1637586337 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/AcrossCheckpointFileMergingSnapshotManager.java: ## @@ -31,12 +33,13 @@ public class A

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
Zakelly commented on code in PR #24928: URL: https://github.com/apache/flink/pull/24928#discussion_r1637493879 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/AcrossCheckpointFileMergingSnapshotManager.java: ## @@ -31,12 +33,13 @@ public class Acro

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24928: URL: https://github.com/apache/flink/pull/24928#issuecomment-2163701730 ## CI report: * a0719f7e58a3666e9ea39ce673c47a58679c38e6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
zoltar9264 opened a new pull request, #24928: URL: https://github.com/apache/flink/pull/24928 ## What is the purpose of the change As title said, normalize file-merging sub dir, including subtask dir and exclusive dir. ## Brief change log *(for example:)* - *The