Zakelly merged PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.
Zakelly commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2151314927
> @Zakelly @pnowojski do you need anything else from me to progress this?
Would one of you be able to approve this PR to run through the workflow so I
can verify its good to go?
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2151090653
@Zakelly @pnowojski do you need anything else from me to progress this?
Would one of you be able to approve this PR to run through the workflow so I
can verify its good to go?
--
Zakelly commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2139458543
> @Zakelly I've pushed
[decdc8e](https://github.com/apache/flink-benchmarks/commit/decdc8e2d161584a798461b4f381adba7cee731f)
which restores the JMH defaults from 1.19. Hopefully that
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2138664126
@Zakelly I've pushed
https://github.com/apache/flink-benchmarks/pull/90/commits/decdc8e2d161584a798461b4f381adba7cee731f
which restores the JMH defaults from 1.19. Hopefully that a
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2138632929
I've confirmed the runtime duration increase comes from upgrading JMH from
1.19 to 1.21. The minimum version for async profiler looks to be JMH 1.31. So
if we want flame graphs 1.3
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2138478974
> It compiles & install flink before run benchmarks via
/mnt/jenkins/tools/hudson.tasks.Maven_MavenInstallation/M3/bin/mvn
-Dflink.version=1.20-SNAPSHOT clean install exec:exec -Pe
Zakelly commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2137299531
Here's the full log before the pipeline expired.
[jenkins.tar.gz](https://github.com/apache/flink-benchmarks/files/15484257/jenkins.tar.gz)
It compiles & install flink before r
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2137002719
> And I find the benchmark runs extremely slow with the profiler on. The ETA
is up to 8 days for full set of our daily run. So I guess this is best only
used for single tests that
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1618517159
##
benchmark.sh:
##
@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
Review Comment:
resolved with
https://github.com/apache/flink-benchmarks/pull/90/commits/74e4f4f56
Zakelly commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2136859786
And I find the benchmark runs extremely slow with the profiler on. The ETA
is up to 8 days for full set of our daily run. So I guess this is best only
used for single tests that are
Zakelly commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1618445050
##
benchmark.sh:
##
@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
Review Comment:
`chown +x` to make this executable?
##
pom.xml:
##
@@ -67,6 +67,7
showuon commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1618289766
##
README.md:
##
@@ -64,6 +64,20 @@ java -jar target/benchmarks.jar "" -lp
java -jar target/benchmarks.jar "org.apache.flink.state.benchmark.*" -p
"backendType=R
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2136485697
@Zakelly any news on the jenkins env? I'm largely hoping its a no-op there
right now.
@pnowojski readme and executable bit set. Is there anything else your
looking for?
--
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1618157436
##
benchmark.sh:
##
@@ -0,0 +1,48 @@
+#!/usr/bin/env bash
+
+JAVA_ARGS=()
+JMH_ARGS=()
+BINARY="java"
+BENCHMARK_PATTERN=
+
+while getopts ":j:c:b:e:p:a:m:h" opt
pnowojski commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2134747996
> Yes that's almost right. The profile is enabled automatically by
specifying the path the profiler shared library (as opposed to running -P
enable-async-profiler) Async profiler n
Zakelly commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2134617507
Thanks for the contribution! I'll try this out in our `jenkins` env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2134019437
> AFAIU, by default profiling is not turned on. One has to activate
enable-async-profiler profile?
Yes that's almost right. The profile is enabled automatically by specifying
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1616369948
##
pom.xml:
##
@@ -290,25 +291,31 @@ under the License.
pnowojski commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1616223910
##
benchmark.sh:
##
@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
Review Comment:
I would mark this as executable.
##
benchmark.sh:
##
@@ -0,0 +1,
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1615688702
##
pom.xml:
##
@@ -54,11 +54,11 @@ under the License.
${java.version}
1.7.36
1.2.17
- 1.19
+
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1615426480
##
benchmark.sh:
##
@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
Review Comment:
One final call out. This is not currently checked in with the executable bit
set a
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2132564249
I think the `benchmark-java17` profile could potentially be simplified to
specify a property with just the additional JVM_ARGS (possibly changing `-j` to
be single arg inline with
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1615355106
##
pom.xml:
##
@@ -345,6 +346,8 @@ under the License.
-classpath
SamBarker opened a new pull request, #90:
URL: https://github.com/apache/flink-benchmarks/pull/90
In exploring
[FLINK-35215](https://issues.apache.org/jira/browse/FLINK-35215) being able to
generate flame graphs from each benchmark run makes comparing results a lot
easier.
--
This is an
25 matches
Mail list logo
