[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596464#comment-16596464 ] ASF GitHub Bot commented on FLINK-4534: --- zentol closed pull request #4482: [FLINK-4534] Fix

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596461#comment-16596461 ] ASF GitHub Bot commented on FLINK-4534: --- azagrebin commented on issue #4482: [FLINK-4534] Fix

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583158#comment-16583158 ] Ted Yu commented on FLINK-4534: --- Sounds good. > Lack of synchronization in BucketingSink#restoreState() >

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550597#comment-16550597 ] Kostas Kloudas commented on FLINK-4534: --- Hi [~yuzhih...@gmail.com], [~gjy] and [~mingleizhang]!

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548759#comment-16548759 ] zhangminglei commented on FLINK-4534: - Hi, [~gjy] Can we use a lightweight synchronization mechanism

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547934#comment-16547934 ] Gary Yao commented on FLINK-4534: - [~yuzhih...@gmail.com] Synchronization bears a performance penalty.

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532220#comment-16532220 ] Ted Yu commented on FLINK-4534: --- The synchronization should be added - if there is no concurrent call(s),

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524649#comment-16524649 ] Gary Yao commented on FLINK-4534: - Is this really needed? Flink callbacks are generally not invoked

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514975#comment-16514975 ] Ted Yu commented on FLINK-4534: --- lgtm > Lack of synchronization in BucketingSink#restoreState() >

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431593#comment-16431593 ] ASF GitHub Bot commented on FLINK-4534: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431583#comment-16431583 ] ASF GitHub Bot commented on FLINK-4534: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304163#comment-16304163 ] Ted Yu commented on FLINK-4534: --- lgtm > Lack of synchronization in BucketingSink#restoreState() >

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131626#comment-16131626 ] ASF GitHub Bot commented on FLINK-4534: --- Github user tedyu commented on the issue:

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115329#comment-16115329 ] ASF GitHub Bot commented on FLINK-4534: --- GitHub user zhangminglei opened a pull request:

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115323#comment-16115323 ] Ted Yu commented on FLINK-4534: --- Code w.r.t. state.bucketStates.values() has been refactored since the JIRA

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115259#comment-16115259 ] mingleizhang commented on FLINK-4534: - [~tedyu] Thanks for reporting this! One thing I need confirm,

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506583#comment-15506583 ] Ted Yu commented on FLINK-4534: --- Feel free to work on this. > Lack of synchronization in

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506034#comment-15506034 ] Liwei Lin commented on FLINK-4534: -- Hi [~tedyu] do you plan to fix this? In case you don't, I might take