Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-03 Thread via GitHub
snuyanzin commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837922338 closing since finally the change introduced such ci failures was at https://github.com/apache/flink/pull/23861 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-03 Thread via GitHub
snuyanzin closed pull request #23858: [FLINK-33727][table] Use different sink names for restore tests URL: https://github.com/apache/flink/pull/23858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-03 Thread via GitHub
jnh5y commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837506076 > Are there any savepoint where currently changed names were participating? Yes. > Then how to find all? Or is it just a question in general? The savepoints are living under

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-03 Thread via GitHub
snuyanzin commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837503632 Are there any savepoint where currently changed names were participating? Then how to find all? Or is it just a question in general? -- This is an automated message from the

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-03 Thread via GitHub
snuyanzin commented on code in PR #23858: URL: https://github.com/apache/flink/pull/23858#discussion_r1413116026 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java: ## @@ -142,7 +142,7 @@ public class

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-02 Thread via GitHub
JingGe commented on code in PR #23858: URL: https://github.com/apache/flink/pull/23858#discussion_r1413009264 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java: ## @@ -142,7 +142,7 @@ public class

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-02 Thread via GitHub
flinkbot commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837279346 ## CI report: * da62de304dcaeef07bda7d8da7bfc082737b14fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`