Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r169727315
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/SnapshotDirectory.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r169725430
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStreamWithResultProvider.java
---
@@ -172,4 +167,30 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r169728016
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/SnapshotDirectory.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r169726507
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/DirectoryStateHandle.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r169727620
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/SnapshotDirectory.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371781#comment-16371781
]
ASF GitHub Bot commented on FLINK-8360:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371782#comment-16371782
]
ASF GitHub Bot commented on FLINK-8360:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371784#comment-16371784
]
ASF GitHub Bot commented on FLINK-8360:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371783#comment-16371783
]
ASF GitHub Bot commented on FLINK-8360:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371787#comment-16371787
]
ASF GitHub Bot commented on FLINK-8360:
---
Github user tillrohrmann commented on a diff in the pull
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5542#discussion_r169714628
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java
---
@@ -43,40 +40,27 @@
/**
*
[
https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371707#comment-16371707
]
ASF GitHub Bot commented on FLINK-8703:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371717#comment-16371717
]
Piotr Nowojski edited comment on FLINK-8707 at 2/21/18 5:31 PM:
I don't
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5551
[FLINK-8736][network] fix memory segment offsets for slices of slices being
wrong
## What is the purpose of the change
[FLINK-8588] introduced memory segment offsets to the `Buffer` classes
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/5541
---
[
https://issues.apache.org/jira/browse/FLINK-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371735#comment-16371735
]
ASF GitHub Bot commented on FLINK-8728:
---
Github user tillrohrmann closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371734#comment-16371734
]
ASF GitHub Bot commented on FLINK-8728:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371789#comment-16371789
]
ASF GitHub Bot commented on FLINK-8718:
---
Github user aljoscha commented on the issue:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5545
I'm not sure we can do this change since it breaks compatibility for
savepoints because previous versions of Flink hat some `maxParallelism` setting
for sources which would be incompatible with the
[
https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371780#comment-16371780
]
ASF GitHub Bot commented on FLINK-8360:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371785#comment-16371785
]
ASF GitHub Bot commented on FLINK-8360:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371786#comment-16371786
]
ASF GitHub Bot commented on FLINK-8360:
---
Github user tillrohrmann commented on a diff in the pull
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5552#discussion_r169738273
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/LegacyStatefulJobSavepointMigrationITCase.java
---
@@ -0,0 +1,663 @@
+/*
Aljoscha Krettek created FLINK-8735:
---
Summary: Add savepoint migration ITCase that covers operator state
Key: FLINK-8735
URL: https://issues.apache.org/jira/browse/FLINK-8735
Project: Flink
Nico Kruber created FLINK-8736:
--
Summary: Memory segment offsets for slices of slices are wrong
Key: FLINK-8736
URL: https://issues.apache.org/jira/browse/FLINK-8736
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371709#comment-16371709
]
ASF GitHub Bot commented on FLINK-8734:
---
GitHub user NicoK opened a pull request:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5497
---
[
https://issues.apache.org/jira/browse/FLINK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371718#comment-16371718
]
ASF GitHub Bot commented on FLINK-8736:
---
GitHub user NicoK opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-8728.
Resolution: Won't Do
We cannot fail immediately, because there might still be other
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r169726050
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/DirectoryKeyedStateHandle.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r169724637
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -2123,9
Nico Kruber created FLINK-8734:
--
Summary: SpillableSubpartition does not update byte statistics
when spilled by a SpillableSubpartitionView
Key: FLINK-8734
URL: https://issues.apache.org/jira/browse/FLINK-8734
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5534
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5539
---
Nico Kruber created FLINK-8737:
--
Summary: Creating a union of UnionGate instances will fail with
UnsupportedOperationException when retrieving buffers
Key: FLINK-8737
URL:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5535
---
[
https://issues.apache.org/jira/browse/FLINK-8713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371702#comment-16371702
]
ASF GitHub Bot commented on FLINK-8713:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5413
---
[
https://issues.apache.org/jira/browse/FLINK-8713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-8713.
---
Resolution: Fixed
master: 7410491bd68eed2deec0e334bd811471621ff1ae
>
[
https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371703#comment-16371703
]
ASF GitHub Bot commented on FLINK-8703:
---
Github user asfgit closed the pull request at:
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5550
[FLINK-8734][network] fix partition bytes counting and re-enable in tests
## What is the purpose of the change
With [FLINK-8583], `SpillableSubpartition` does not update byte statistics
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5541
Unfortunately, we cannot fail immediately, because there might still be
`TaskExecutors` which have not registered at the `ResourceManager`.
---
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/5553
[FLINK-8735] Add new StatefulJobSavepointMigrationITCase (release-1.4)
Sister PR to #5552 for the release-1.4 branch.
You can merge this pull request into a Git repository by running:
$ git
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371797#comment-16371797
]
ASF GitHub Bot commented on FLINK-8735:
---
Github user aljoscha commented on the issue:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5552#discussion_r169740338
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java
---
@@ -0,0 +1,658 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371868#comment-16371868
]
ASF GitHub Bot commented on FLINK-8735:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371865#comment-16371865
]
ASF GitHub Bot commented on FLINK-8735:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371876#comment-16371876
]
ASF GitHub Bot commented on FLINK-8735:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5552#discussion_r169745602
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/LegacyStatefulJobSavepointMigrationITCase.java
---
@@ -0,0 +1,663 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371962#comment-16371962
]
ASF GitHub Bot commented on FLINK-8729:
---
GitHub user zentol opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371882#comment-16371882
]
chris snow edited comment on FLINK-8543 at 2/21/18 7:42 PM:
So all files being
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5552#discussion_r169741385
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java
---
@@ -0,0 +1,658 @@
+/*
+ *
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5552#discussion_r169743891
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java
---
@@ -0,0 +1,658 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bowen Li updated FLINK-8719:
Summary: add README for flink-contrib to clarify its purpose (was: add
module description for
[
https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371855#comment-16371855
]
chris snow commented on FLINK-8543:
---
Does Flink running on EMR using S3 have the same issue? If not,
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371869#comment-16371869
]
ASF GitHub Bot commented on FLINK-8735:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371796#comment-16371796
]
ASF GitHub Bot commented on FLINK-8735:
---
GitHub user aljoscha opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371807#comment-16371807
]
ASF GitHub Bot commented on FLINK-8645:
---
Github user StephanEwen commented on the issue:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5552
The sister PR for `release-1.4` is #5553 .
---
[
https://issues.apache.org/jira/browse/FLINK-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-8729:
Component/s: Build System
> Migrate JSONGenerator from Sling to Jackson
>
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5528
Merged in 74c5570c9fa94d35e47899b0dcdc74a5d18750f6
---
[
https://issues.apache.org/jira/browse/FLINK-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-8738.
---
> Converge runtime dependency versions for 'scala-lang' and for
> 'com.typesafe:config'
>
Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/5528
---
[
https://issues.apache.org/jira/browse/FLINK-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-8696.
-
Resolution: Fixed
Fixed via d61664ca64bcb82c4e8ddf03a2ed38fe8edafa98
> Remove JobManager local
[
https://issues.apache.org/jira/browse/FLINK-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-8738.
-
Resolution: Fixed
Fixed in a844cd89207747a27535e8cb7cd8d6f4a332d8ed
> Converge runtime
[
https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372016#comment-16372016
]
ASF GitHub Bot commented on FLINK-6489:
---
Github user StephanEwen closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372015#comment-16372015
]
ASF GitHub Bot commented on FLINK-6489:
---
Github user StephanEwen commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-6489.
---
> Rework 'start-local.bat' to 'start-local-cluster.bat'
>
[
https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-6489.
-
Resolution: Fixed
Fix Version/s: 1.5.0
Fixed in c68f95c3e5e4fa0bce39915238209b238a8036a9
[
https://issues.apache.org/jira/browse/FLINK-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-8696.
---
> Remove JobManager local mode from the Unix Shell Scripts
>
Stephan Ewen created FLINK-8738:
---
Summary: Converge runtime dependency versions for 'scala-lang' and
for 'com.typesafe:config'
Key: FLINK-8738
URL: https://issues.apache.org/jira/browse/FLINK-8738
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371843#comment-16371843
]
ASF GitHub Bot commented on FLINK-8735:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371866#comment-16371866
]
ASF GitHub Bot commented on FLINK-8735:
---
Github user zentol commented on a diff in the pull request:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5544
Looks good to me.
Would be nice to have another opinion on the config key names. After all, I
just suggested my personal opinion...
---
[
https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371976#comment-16371976
]
Steve Loughran commented on FLINK-8543:
---
bq. So all files being accompanied by .valid-length is
[
https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371882#comment-16371882
]
chris snow commented on FLINK-8543:
---
So all files being accompanied by .valid-length is expected
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5554
[FLINK-8729][streaming] Refactor JSONGenerator to use jackson
## What is the purpose of the change
This PR ports the `JSONGenerator` to rely on jackson instead of
`org.apache.sling`.
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371795#comment-16371795
]
ASF GitHub Bot commented on FLINK-8735:
---
GitHub user aljoscha opened a pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5552#discussion_r169742676
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java
---
@@ -0,0 +1,658 @@
+/*
+ *
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/5552
[FLINK-8735] Add new StatefulJobSavepointMigrationITCase
R: @kl0u, and this is also relevant for your related PR that adds support
for broadcast state. I think you would have to build on this new
[
https://issues.apache.org/jira/browse/FLINK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371867#comment-16371867
]
ASF GitHub Bot commented on FLINK-8735:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5552#discussion_r169734512
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java
---
@@ -0,0 +1,658 @@
+/*
+ *
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5552#discussion_r169741935
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java
---
@@ -0,0 +1,658 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371870#comment-16371870
]
Steve Loughran commented on FLINK-8543:
---
There's no truncate operation in the S3 protocol; so not in
[
https://issues.apache.org/jira/browse/FLINK-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372028#comment-16372028
]
Stephan Ewen commented on FLINK-8707:
-
If I understood the description by [~imogard] correct, then
[
https://issues.apache.org/jira/browse/FLINK-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372076#comment-16372076
]
ASF GitHub Bot commented on FLINK-8718:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5545
Shouldn't it always be possible to merge n key groups into a single key
group? Maybe this could be the backwards compatibility path.
Moreover, which sources use keyed state? Don't
301 - 387 of 387 matches
Mail list logo
