Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2347
Merging this after a Checkstyle fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75122721
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,168 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r75123833
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,31 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2340
Thanks for addressing my comments! Looks very good. I'm sorry I asked
whether you have tested the changes. It may seem natural to you but trust me
that is not always the case :)
Me
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75123576
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,168 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2317
Woops. Didn't end up merging #2320 so this got overlooked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2317#discussion_r75126672
--- Diff: flink-dist/src/main/flink-bin/yarn-bin/yarn-session.sh ---
@@ -52,5 +52,5 @@ log_setting="-Dlog.file="$log"
-Dlog4j.configuration=file:&
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2317
Rebased and ready to go. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2114
Hi @thormanrd! Thanks for your PR. As Robert and Stephan already pointed
out, it contains a lot of reformats which are generally encouraged. They make
the pull request's essentials hard to revie
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75269835
--- Diff: flink-dist/pom.xml ---
@@ -113,8 +113,13 @@ under the License.
flink-metrics-jmx
${project.version
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75269975
--- Diff: flink-mesos/pom.xml ---
@@ -0,0 +1,294 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75270753
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/cli/FlinkMesosSessionCli.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75271531
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75271636
--- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/Utils.java ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75272075
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75272248
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75274022
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75275043
--- Diff: flink-mesos/pom.xml ---
@@ -0,0 +1,294 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75275735
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosConfigKeys.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75276016
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75276925
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75279529
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75280315
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75281657
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/RegisteredMesosWorkerNode.scala
---
@@ -0,0 +1,33
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75282003
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75282731
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/StandaloneMesosWorkerStore.java
---
@@ -0,0 +1,87
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75283539
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java
---
@@ -0,0 +1,290
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75283689
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75283918
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75284993
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/SchedulerProxy.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75285550
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/SchedulerProxy.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75285623
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/SchedulerProxy.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75285727
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/TaskSchedulerBuilder.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75295468
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosArtifactServer.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75295536
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosArtifactServer.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75296348
--- Diff: flink-mesos/src/main/resources/log4j.properties ---
@@ -0,0 +1,27
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75296757
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/runtime/clusterframework/ContaineredJobManager.scala
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75297945
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/ConnectionMonitor.scala
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75298678
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -0,0 +1,349 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75299022
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -0,0 +1,349 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75300491
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/TaskMonitor.scala
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75300879
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/Tasks.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75301383
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/Tasks.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75303392
--- Diff:
flink-mesos/src/test/scala/org/apache/flink/mesos/scheduler/LaunchCoordinatorTest.scala
---
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2315
Thank you for your work @EronWright. Finally could go through the code.
All in all, very impressive as the first step of the Mesos integration! I think
this PR is in a mergeable state if some minor
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75307414
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobInfo.scala
---
@@ -58,10 +62,63 @@ class JobInfo
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75442774
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75442857
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/clients/examples/JobRetrievalITCase.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75442830
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java
---
@@ -198,10 +211,47 @@ else if (message instanceof SubmitJobAndWait
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75443084
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2313
Thanks for the review @tillrohrmann. Yes, the plan is to have a `JobClient`
API class (the existing JobClient class will be renamed) which uses the
SubmissionContext to supervise submitted jobs or
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75459375
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2313
@tillrohrmann I've refactored the JobClientActor to include the common code
in `JobClientActorBase` and have implementations for submitting/attaching in
`JobSubmissionClientActor
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75468671
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2313
@tillrohrmann Pinging the actor now to check if it is still alive. Also
added another test case for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75474811
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75482760
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,162 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2313
I've made the last changes concerning the lazy reconstruction of the class
loader we discussed. Rebased to master. Should be good to go now.
---
If your project is set up for it, you can reply to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75641421
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75641515
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosConfigKeys.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75641703
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/cli/FlinkMesosSessionCli.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75642452
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75642882
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/ConnectionMonitor.scala
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75644911
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75644987
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75645192
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75645973
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75646080
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75646889
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75646940
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647172
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647510
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647749
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647841
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647928
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647937
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647940
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647899
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75648030
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75647950
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75648199
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75648406
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75648837
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75648889
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75649283
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2400
Thank you for the pull request @wangzhijiang999! Looks good. I just had
some minor remarks on the Scala-->Java conversion.
---
If your project is set up for it, you can reply to this email and h
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75650141
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75650460
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75650523
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75669289
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75669417
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75676249
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2313
Updated according to our comment discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2400
Hi @wangzhijiang999! `ActorSystem` and `LeaderRetrievalService` should only
every appear in the factory (startTaskManagerComponentsAndActor) which bring up
the TaskExecutor component. The TaskExecutor
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75680482
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75680765
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75680917
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public class
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
Hi @vijikarthi! Sorry for the late reply. I intend to merge this as soon as
possible. When I run the secure test cases from IntelliJ I get
>java.lang.NoClassDefFoundError: jdbm/helper/CachePol
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
YARNSessionFIFOSecuredITCase gives me the following:
>17:49:58,097 INFO SecurityLogger.org.apache.hadoop.ipc.Server
- Auth successful for appattempt_1471880990715_0001_000
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
`RollingFileSink`
```
---
T E S T S
---
Running
1 - 100 of 1927 matches
Mail list logo
