[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-23 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71178244 Hadoops `FileOutputFormat` has the following method ```java public static String getUniqueName(JobConf conf, String name) { int partition = conf.getInt

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72314532 Without the change, I'm getting the following error, even though my KeyExtractor implements ResultTypeQueryable: ```java Exception in thread main

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72315355 Do you want to fix it or should I do it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72316077 Cool, thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-12 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/301 [FLINK-1389] Allow changing the filenames of the files created when writing to a directory ... You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-09 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/292 [FLINK-1295][FLINK-883] Allow to deploy 'job only' YARN cluster. Add tests to YARN - users can now also deploy Flink on YARN for executing a single job. - the flink-yarn project has been moved

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-69896090 The second option (env) is probably better because people will see the method when their IDE suggests method names. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1495][yarn] Make Akka timeout configura...

2015-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/377#issuecomment-73530921 Thank you. I'll merge it once the master is building again ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1492] Fix exceptions on blob store shut...

2015-02-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/376#issuecomment-73667317 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-02-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/236#discussion_r24402955 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -169,4 +186,113 @@ public ExecutionConfig disableObjectReuse

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-02-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/236#discussion_r24402907 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/KryoSerializer.java --- @@ -82,29 +75,15

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-02-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/236#discussion_r24403132 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -169,4 +186,113 @@ public ExecutionConfig disableObjectReuse

[GitHub] flink pull request: [FLINK-1417] Automatically register types with...

2015-02-13 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/393 [FLINK-1417] Automatically register types with Kryo This pull request also contains code from old pull requests for FLINK-1391, FLINK-1392, FLINK-1395. You can merge this pull request

[GitHub] flink pull request: [FLINK-1510] Make AvroInputFormat splittable

2015-02-11 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/382 [FLINK-1510] Make AvroInputFormat splittable I'm currently working on testing the format on a cluster. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request: [FLINK-1495][yarn] Make Akka timeout configura...

2015-02-09 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/377 [FLINK-1495][yarn] Make Akka timeout configurable in YARN client. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink yarn_timeouts

[GitHub] flink pull request: Port FLINK-1391 and FLINK-1392 to release-0.8...

2015-02-09 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Port FLINK-1391 and FLINK-1392 to release-0.8...

2015-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/364#issuecomment-73510972 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1492] Fix exceptions on blob store shut...

2015-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/376#issuecomment-73500870 This change is also in 0.8 so do we need to apply the fix there as well for the upcoming 0.8.1 release? --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/318#issuecomment-73504622 I've merged it to the 0.8 branch. I forgot to close the PR, could you do it manually? Thank you. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1391] Register common Avro types at Kry...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/386#issuecomment-74080897 Merged to release-0.8 in: http://git-wip-us.apache.org/repos/asf/flink/commit/10f89c73 --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [builds] Print Java process stack traces of st...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/389#issuecomment-74079695 Very nicely implemented! My bash scripts are certainly uglier ;) +1 for merging it --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-1391] Register common Avro types at Kry...

2015-02-12 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1391] Register common Avro types at Kry...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/386#issuecomment-74068908 Ah no. Its not a good idea ;) We don't see that the user is using an Avro POJO when we use the POJO serializer. So we have to register the types always

[GitHub] flink pull request: [FLINK-1436] refactor CLiFrontend to provide m...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/331#issuecomment-74072237 Good work. Thank you. I think its time for your first push to master ;) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1391] Register common Avro types at Kry...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/386#issuecomment-74068511 Yep. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-1436] refactor CLiFrontend to provide m...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/331#issuecomment-74072268 Remember to include This closes #311 ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-1531] Fixes KryoSerializer's EOFExcepti...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/391#issuecomment-74097085 Looks good +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1531] Fixes KryoSerializer's EOFExcepti...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/391#issuecomment-74099311 We should also put the fix into the release-0.8 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1179] Add button to JobManager web inte...

2015-02-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/374#issuecomment-74310825 I'll probably merge this change tomorrow because I'm working on a bigger change on the web frontend. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/363#issuecomment-73024197 I vote for keeping @aljoscha's original approach. Users might not notice the different interfaces there, so the Hadoop in the method name makes it more explicit

[GitHub] flink pull request: [FLINK-1669] [wip] Test for streaming recovery...

2015-03-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/496#issuecomment-82878482 Maybe, the `execution-retries.delay` is set too high? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1679] rename degree of parallelism to p...

2015-03-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/488#issuecomment-82825369 Thank you for the huge change! Our users will appreciate the more concise naming and improved documentation. +1 to merge --- If your project is set up

[GitHub] flink pull request: [FLINK-1720] Integrate ScalaDoc into JavaDoc

2015-03-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/497#discussion_r26671432 --- Diff: pom.xml --- @@ -416,6 +416,65 @@ under the License. iddocs-and-source/id build

[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...

2015-03-22 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/506#issuecomment-84687727 Change looks good. I miss some javadocs on the user facing methods ;) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1342] Fix filtering of usercode from qu...

2015-03-16 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/486 [FLINK-1342] Fix filtering of usercode from quickstart With this change, we'll not just exclude everything from the org.apache.flink groupid. This has caused many troubles to users because

[GitHub] flink pull request: Cleanup of low level Kafka consumer (Persisten...

2015-03-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/474#issuecomment-81792049 There are no tests for the Kafka connectors. The code is not working. I've fixed an issue with the classloading already: https://github.com/rmetzger/flink

[GitHub] flink pull request: Cleanup of low level Kafka consumer (Persisten...

2015-03-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/474#issuecomment-81813382 I think we should add a integration test with a local kafka cluster: https://github.com/sakserv/hadoop-mini-clusters --- If your project is set up for it, you can reply

[GitHub] flink pull request: modify the getlogger of the class

2015-03-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/490#issuecomment-82269385 Thanks for the pull request. Looks good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: Cleanup of low level Kafka consumer (Persisten...

2015-03-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/474#issuecomment-82621443 First of all: Great work @gaborhermann! The whole Kafka connector code is well written and contains logic for a lot of cases. I think it was already quite some work

[GitHub] flink pull request: [FLINK-441] Rename Pact* and Nephele* classes ...

2015-03-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/492#issuecomment-82576423 Why aren't we renaming the `flink-compiler` module into `flink-optimizer`? Its an internal module only, so users won't see what we reorganized our code internally

[GitHub] flink pull request: [FLINK-441] Rename Pact* and Nephele* classes ...

2015-03-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/492#issuecomment-82579347 I think it is fine if we mention in the release notes that the name has changed. All the quickstart pom users won't be affected. --- If your project is set up

[GitHub] flink pull request: Improvements to Kafka Source/Sink some bugfi...

2015-03-19 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/500#discussion_r26742487 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -182,7 +182,6 @@ protected void fillInType(TypeInformationT typeInfo

[GitHub] flink pull request: Improvements to Kafka Source/Sink some bugfi...

2015-03-19 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/500#discussion_r26762000 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/pom.xml --- @@ -46,9 +53,13 @@ under the License. dependency

[GitHub] flink pull request: [FLINK-1695] Kick off of Flink's machine learn...

2015-03-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/479#issuecomment-82392282 merge it. To get some bonus points, include the JIRA id with the commits --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1667] [runtime] Add test for recovery a...

2015-03-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/467#issuecomment-77912062 Nice test ;) +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/426#issuecomment-77912526 @teabot: We've created this JIRA for the feature you've suggested: https://issues.apache.org/jira/browse/FLINK-1665 --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1514][Gelly] Add a Gather-Sum-Apply ite...

2015-03-09 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/408#discussion_r26066814 --- Diff: flink-staging/flink-gelly/pom.xml --- @@ -52,4 +52,35 @@ under the License. scopetest/scope /dependency

[GitHub] flink pull request: [FLINK-1629][FLINK-1630][FLINK-1547] Rework Fl...

2015-03-09 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/468 [FLINK-1629][FLINK-1630][FLINK-1547] Rework Flink on YARN The main change here is a reworked container scheduling logic in the YARN ApplicationMaster. This commit is changing: [FLINK

[GitHub] flink pull request: [FLINK-1605] Bundle all hadoop dependencies an...

2015-03-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/454#issuecomment-77921349 The pull request has been rebased to master. I'm looking for some feedback for this change. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: Add support for building Flink with Scala 2.11

2015-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/477#discussion_r26220968 --- Diff: flink-scala/pom.xml --- @@ -236,4 +230,23 @@ under the License. /plugins /build + profiles

[GitHub] flink pull request: [FLINK-1219] Add support for Apache Tez as exe...

2015-03-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/189#issuecomment-78025522 The documentation is very well written. I've tried the pull request on a Hortonworks Sandbox with HDP 2.2. They have Tez 0.5.2.2.2.0.0 installed

[GitHub] flink pull request: [FLINK-1605] Bundle all hadoop dependencies an...

2015-03-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/454#issuecomment-78047279 Thank you for reviewing the change. * The exclusions for the `flink-clients` were indeed wrong. Good catch! * It doesn't make much sense to set a main class

[GitHub] flink pull request: Kick off of Flink's machine learning library

2015-03-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/479#issuecomment-78440416 Is there a JIRA associated with this PR? Once the issues with the documentation are resolved, I'd say its good to merge. --- If your project is set up for it, you

[GitHub] flink pull request: Add support for building Flink with Scala 2.11

2015-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/477#issuecomment-78311798 The reason why I asked regarding Scala 2.11.6 was because this version is shown on the scala-lang website next to the download button. Also, on maven central, you get

[GitHub] flink pull request: Add support for building Flink with Scala 2.11

2015-03-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/477#issuecomment-78317231 I'll ask on the ML --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-03-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/442#discussion_r26285316 --- Diff: flink-contrib/src/main/java/org/apache/flink/contrib/tweetinputformat/io/SimpleTweetInputFormat.java --- @@ -0,0 +1,67 @@ +package

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-03-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/442#discussion_r26289003 --- Diff: flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java --- @@ -0,0 +1,76 @@ +package org.apache.flink.contrib

[GitHub] flink pull request: Add auto-parallelism to Jobs (0.8 branch)

2015-03-06 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/410#issuecomment-77530332 Hey, Flink already supports running multiple jobs in parallel. If you have 50 slots available, you can run two jobs requiring 25 slots. The webfrontend

[GitHub] flink pull request: [FLINK-1514][Gelly] Add a Gather-Sum-Apply ite...

2015-03-08 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/408#discussion_r26005153 --- Diff: flink-staging/flink-gelly/pom.xml --- @@ -52,4 +52,35 @@ under the License. scopetest/scope /dependency

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-03-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/442#discussion_r26300021 --- Diff: flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java --- @@ -0,0 +1,76 @@ +package org.apache.flink.contrib

[GitHub] flink pull request: [FLINK-1629][FLINK-1630][FLINK-1547] Rework Fl...

2015-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/468#issuecomment-78242400 TODO: add documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Add support for building Flink with Scala 2.11

2015-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/477#discussion_r26195550 --- Diff: flink-scala/pom.xml --- @@ -236,4 +230,23 @@ under the License. /plugins /build + profiles

[GitHub] flink pull request: Add support for building Flink with Scala 2.11

2015-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/477#discussion_r26195970 --- Diff: pom.xml --- @@ -599,6 +599,38 @@ under the License. profiles profile + idscala-2.10/id

[GitHub] flink pull request: Add support for building Flink with Scala 2.11

2015-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/477#issuecomment-78234335 Why are you using Scala 2.11.4? The mentioned bug seems to be fixed in 2.11.6. Why aren't we adding a `_2.11` suffix to the Scala 2.11 Flink builds? Otherwise

[GitHub] flink pull request: [FLINK-1605] Bundle all hadoop dependencies an...

2015-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/454#issuecomment-78235211 Thanks for the review. I'll address your comments and then merge it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: Kick off of Flink's machine learning library

2015-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/479#discussion_r26205510 --- Diff: docs/_layouts/default.html --- @@ -23,16 +23,25 @@ meta http-equiv=X-UA-Compatible content=IE=edge meta name=viewport content

[GitHub] flink pull request: [FLINK-1605] Bundle all hadoop dependencies an...

2015-03-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/454#issuecomment-78889015 Hey Henry, I'm sorry that the change is making your builds so much slower. My linux machine needs 5 minutes to build the current master. I suspect

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-78858625 You can still use the `-a` and `-j` arguments. But its certainly nicer to just specify the name of the jar file and the arguments. +1 to merge. --- If your

[GitHub] flink pull request: Add support for building Flink with Scala 2.11

2015-03-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/477#issuecomment-78953629 I manually deployed the current master to apache's snapshot repository because travis has failed to upload it. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-03-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/442#discussion_r26288947 --- Diff: flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java --- @@ -0,0 +1,76 @@ +package org.apache.flink.contrib

[GitHub] flink pull request: [FLINK-1676] Rework ExecutionConfig.enableForc...

2015-03-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/473#discussion_r26170417 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java --- @@ -310,6 +310,9 @@ public int getFieldIndex(String fieldName

[GitHub] flink pull request: [FLINK-1567] [gelly] improvements to the gelly...

2015-03-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/469#issuecomment-78012225 Hey, it seems like the issue number is not matching ;) FLINK-1567 is Add option to switch between Avro and Kryo serialization for GenericTypes --- If your project

[GitHub] flink pull request: [FLINK-1676] Rework ExecutionConfig.enableForc...

2015-03-12 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/473 [FLINK-1676] Rework ExecutionConfig.enableForceKryo() Please note that we are now using the PojoComparator with the GenericTypeInfo (Kryo or Avro) if ExecutionConfig.enableForceKryo() is set

[GitHub] flink pull request: [FLINK-1687] [streaming] Syncing streaming sou...

2015-03-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/521#issuecomment-85412269 Okay, cool. Let us know when the pull request is ready for another round of reviews. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1775] BarrierBuffer fix to avoid end of...

2015-03-25 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/534#discussion_r27100141 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/streamvertex/StreamVertex.java --- @@ -283,16

[GitHub] flink pull request: [FLINK-1501] Add metrics library for monitorin...

2015-03-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/421#issuecomment-86440012 No, there are no objections. I'll rebase this pull request to the current master and merge it later today. I think the next steps are: - Get the CPU

[GitHub] flink pull request: [FLINK-1769] Fix deploy bug caused by ScalaDoc...

2015-03-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/535#issuecomment-86389760 Looks good. We should merge this rather soon because the SNAPSHOT deployment is blocked by this. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1633][gelly] Added getTriplets() method...

2015-03-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/452#issuecomment-87600209 @vasia: I think the error is not related to the PR and it only happened in one out of 10 builds. Its not good that it failed but it should not block you from merging

[GitHub] flink pull request: [FLINK-1501] Add metrics library for monitorin...

2015-03-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/421#issuecomment-87781100 Cool. I'm available between 16:30 - 20:30 India Time Zone (UTC+05:30). Is that possible for you? --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/542#issuecomment-87780049 A user I'm talking with offline depends on these changes. I'm currently hardening the tests on Travis, once that's done I'll merge the changes (probably in the next

[GitHub] flink pull request: [FLINK-1501] Add metrics library for monitorin...

2015-03-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/421#issuecomment-87798034 Confirmed ;) Looking forward talking to you tomorrow. My google hangout id is metrob...@gmail.com. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/542#issuecomment-87840336 I know that the PR is touching many components. I'll try to split up my work into smaller parts. In this case I didn't expect in the beginning that I need to change

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/542#issuecomment-87967427 Thank you very much for the review Henry! I addressed your feedback where applicable. I'll merge the change now. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/542#discussion_r27456302 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/FlinkYarnCluster.java --- @@ -106,70 +111,129 @@ public FlinkYarnCluster(final YarnClient yarnClient

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/542#discussion_r27456202 --- Diff: flink-test-utils/src/main/java/org/apache/flink/test/util/TestEnvironment.java --- @@ -80,7 +80,7 @@ public String getExecutionPlan() throws

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/542#discussion_r27456299 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -265,12 +266,32 @@ protected int run(String[] args

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/542#discussion_r27456233 --- Diff: flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java --- @@ -89,15 +89,20 @@ public void setPrintStatusDuringExecution(boolean

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/542#discussion_r27456244 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -569,15 +590,33 @@ protected int executeProgram(PackagedProgram program

[GitHub] flink pull request: [FLINK-1771] Add support for submitting single...

2015-03-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/542#discussion_r27456228 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/operators/translation/CustomPartitioningGroupingTupleTest.scala --- @@ -18,12 +18,12

[GitHub] flink pull request: Add --abbrev-ref to get the right branch name ...

2015-03-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/548#issuecomment-88071167 Looks good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1792] TM Monitoring: CPU utilization, h...

2015-04-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/553#discussion_r27551487 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -129,6 +129,10 @@ class TaskManager(val connectionInfo

[GitHub] flink pull request: [FLINK-1792] TM Monitoring: CPU utilization, h...

2015-04-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/553#issuecomment-88387132 Thank you for the contribution. I'll have a look at the changes. The integration test of your change (https://travis-ci.org/apache/flink/builds/56641563) has

[GitHub] flink pull request: [FLINK-1792] TM Monitoring: CPU utilization, h...

2015-04-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/553#issuecomment-88418659 The memory statistics get pretty big when the chart is enabled as well. Can you hide the string-based statistics when the graph is activated? http://i.imgur.com

[GitHub] flink pull request: [FLINK-1800][docs] Add beta badge to component...

2015-04-01 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/555 [FLINK-1800][docs] Add beta badge to components in flink-staging You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink1800

[GitHub] flink pull request: [FLINK-1589] Add option to pass configuration ...

2015-04-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/427#issuecomment-88453493 If there are no objections, I'm going to merge the PR in the next 24 hours. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1811] Allow passing custom buffer sizes...

2015-04-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/558#discussion_r27567913 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/iterator

[GitHub] flink pull request: [FLINK-1811] Allow passing custom buffer sizes...

2015-04-01 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/558 [FLINK-1811] Allow passing custom buffer sizes and timeouts to Persisten... ...tKafkaSource You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink pull request: [FLINK-1811] Allow passing custom buffer sizes...

2015-04-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/558#issuecomment-88482551 Thanks for the review @uce. I'll update the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1811] Allow passing custom buffer sizes...

2015-04-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/558#issuecomment-88493994 I'updated the PR. Once Travis is green, I'll merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1717] Adds support for libSVM/SVMLight ...

2015-04-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/543#issuecomment-88505717 Go ahead, the changes look good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

<    1   2   3   4   5   6   7   8   9   10   >