[GitHub] flink pull request: [FLINK-2008][FLINK-2296] Fix checkpoint commit...

2015-07-09 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/895#discussion_r34262145 --- Diff: flink-tests/src/test/resources/log4j-test.properties --- @@ -18,7 +18,7 @@ # Set root logger level to OFF to not flood build logs

[GitHub] flink pull request: [doc] Fix wordcount example in YARN setup

2015-07-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/897#issuecomment-120279506 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2008][FLINK-2296] Fix checkpoint commit...

2015-07-09 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/895 [FLINK-2008][FLINK-2296] Fix checkpoint committing KafkaITCase [wip] You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink2008

[GitHub] flink pull request: [FLINK-2337] Multiple SLF4J bindings using Sto...

2015-07-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/903#issuecomment-120702067 +1 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-120702048 Are there any other possible options for the options field except for the parallelism? I think users might be confused how the options and arguments differ

[GitHub] flink pull request: Bumped the docker container to the latest vers...

2015-11-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1366#issuecomment-157504656 thank you for the contribution, the change looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: Bumped the docker container to the latest vers...

2015-11-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1366#issuecomment-157506571 Did you test the change? I've tried it but got the following error ``` Removing intermediate container 0b4ba3a6115e Step 3 : RUN mkdir

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-157833952 There is a readme: https://github.com/apache/flink/tree/master/flink-runtime-web --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1342#discussion_r44767927 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -249,7 +249,15 @@ if [ -n "$HADOOP_HOME" ]; then

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-156388624 Thank you for addressing my concerns so quickly +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156450181 here is the jar file: https://transfer.sh/KNAnm/flink0.10-scala2.11-1.0-snapshot.jar it has been build from here: https://github.com/rmetzger/scratch/tree

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156432901 I think we need to improve a bit on the error messages. This is what I got for submitting a job without arguments on the web interface: ``` Error

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156433498 Even with all the fields filled, it was not starting: http://i.imgur.com/5WXKw9N.png the log file also contained no helpful information --- If your project

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-156423600 Amazing, thank you. I'm going to merge you change as soon as Travis gives me green light ;) I've squashed and rebased your commit and will push it probably

[GitHub] flink pull request: [FLINK-2326] Write yarn properties file to tem...

2015-08-26 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1062 [FLINK-2326] Write yarn properties file to temp directory Flink's YARN client is writing a `.yarn-properties` file to the `conf/` directory containing the JobManager's host and port. It seems

[GitHub] flink pull request: [FLINK-2582] [docs] Add documentation how to b...

2015-08-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1070#issuecomment-135501709 Looks good, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2543] Fix user object deserialization f...

2015-08-28 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1048#issuecomment-135770247 That sounds very good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2543] Fix user object deserialization f...

2015-08-28 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1048#issuecomment-135812417 Sending a stringified exception is not an option between jm and client because the user might rely on the exception in the RemoteExecEnv. --- If your project is set

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136129581 Thanks a lot for the contribution. Can you add a test case for the method to make sure the issue is not re-introduced again when somebody else is changing the code

[GitHub] flink pull request:

2015-08-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/commit/554b77bcd9ed66d57d99d4990774a43f35f6a835#commitcomment-12965859 Currently, flink-runtime has a dependency on Hadoop, so I can assume its always available. Even for a binary Flink release

[GitHub] flink pull request: [FLINK-2512] [bugfix] Used a concurrent list i...

2015-08-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1058#issuecomment-134980282 Are you sure this is a fix for FLINK-2512 ? I don't see how this change is fixing any issue. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2555] Properly pass security credential...

2015-08-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1038#issuecomment-134584589 I agree. Lets file a JIRA and do it separately, as this is probably a bigger task. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2555] Properly pass security credential...

2015-08-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1038#issuecomment-134531698 @mxm: I removed the comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2555] Properly pass security credential...

2015-08-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1038#issuecomment-135013779 Thanks alot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078423 --- Diff: flink-staging/flink-hcatalog/pom.xml --- @@ -34,17 +34,64 @@ under the License. packagingjar/packaging + repositories

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078384 --- Diff: flink-staging/flink-hcatalog/pom.xml --- @@ -34,17 +34,64 @@ under the License. packagingjar/packaging + repositories

[GitHub] flink pull request: [FLINK-2326] Write yarn properties file to tem...

2015-08-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1062#issuecomment-135372331 The travis build passed btw. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2326] Write yarn properties file to tem...

2015-08-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1062#issuecomment-135371903 Can you check the logs of `application_1440646275804_0005`? They are located in `target/yarn-...`. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2326] Write yarn properties file to tem...

2015-08-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1062#issuecomment-135363533 Lets first wait for the builds to pass. The errors are actually not unrelated to my change. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2543] Fix user object deserialization f...

2015-08-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1048#issuecomment-135363969 I addressed all PR comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2555] Properly pass security credential...

2015-08-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1038#issuecomment-135343326 I'm manually closing this pull request. It has been merged by @uce. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2555] Properly pass security credential...

2015-08-27 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/1038 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2386] Add new Kafka Consumer for Flink ...

2015-08-27 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/1055 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2386] Add new Kafka Consumer for Flink ...

2015-08-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1055#issuecomment-135327605 Thank you for merging it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1076#issuecomment-136339437 Make sure it does not break with @tillrohrmann's recent merge ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2372] Add new FlinkKafkaProducer

2015-08-31 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1082 [FLINK-2372] Add new FlinkKafkaProducer This pull request is reworking Flink's KafkaSink. I've renamed the class to `FlinkKafkaProducer` to match it with `FlinkKafkaConsumer`. It uses

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-08-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/948#issuecomment-136377793 Thank you for the response. I was asking because I think its a requirement that the JobManager is running as a mesos task in the cluster as well. But as far as I

[GitHub] flink pull request: [FLINK-2372] Add new FlinkKafkaProducer

2015-09-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1082#issuecomment-13154 Thank you for the feedback. I will address the concerns. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-2372] Add new FlinkKafkaProducer

2015-09-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1082#issuecomment-136669637 I updated the PR and rebased to master (which is adding some commits from the future (at least from GitHubs perspective) ) --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-02 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r38511039 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -411,6 +411,23 @@ class TaskManager

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-02 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r38511106 --- Diff: docs/apis/cli.md --- @@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs. -s,--scheduled

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-07 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38844802 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-07 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38844654 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-07 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38844529 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-07 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r38856545 --- Diff: docs/apis/cli.md --- @@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs. -s,--scheduled

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-07 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r38863585 --- Diff: docs/apis/cli.md --- @@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs. -s,--scheduled

[GitHub] flink pull request: [FLINK-2003] [docs] Building on some encrypted...

2015-09-07 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1100#issuecomment-138313755 Thank you for opening a new pull request. +1 to merge (@ merging committer: please rename the commit to include the JIRA id ;) ) --- If your project is set

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138600722 Thanks a lot for opening the pull request. Can you change the behavior of this a little bit to make the `-n` argument a required argument again? (if the config

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-03 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1084#issuecomment-137390414 I'm currently trying out the module. Some comments: - Why do we name the module `flink-connector-hdfs`. I think a name such as `flink-connector-filesystems

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-03 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1084#discussion_r38627730 --- Diff: docs/apis/streaming_guide.md --- @@ -1836,6 +1837,110 @@ More about information about Elasticsearch can be found [here](https://elastic.c

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1084#discussion_r38435351 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-hdfs/pom.xml --- @@ -0,0 +1,107 @@ + + +http

[GitHub] flink pull request: [FLINK-2607][quickstart] ignore signature file...

2015-09-02 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1085#issuecomment-137095491 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1674] Add test with nested avro type

2015-09-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1091#issuecomment-137679740 Thank you for the contribution. We'll soon review your pull request. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2386] Add new Kafka Consumer for Flink ...

2015-08-25 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1055 [FLINK-2386] Add new Kafka Consumer for Flink 0.9.1 This is PR https://github.com/apache/flink/pull/1039 against the **release-0.9** branch! You can merge this pull request into a Git repository

[GitHub] flink pull request: [FLINK-2386] Add new KafkaConsumer, based on K...

2015-08-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1039#issuecomment-134584442 I addressed @hsaputra's comments rebased to the latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-09-08 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/948#discussion_r38957167 --- Diff: flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/SchedulerUtils.scala --- @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-09-08 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/948#issuecomment-138640533 I'm trying out the code again in GCE ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2097] Implement job session management

2015-09-08 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/858#discussion_r38951273 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/jobmanager/JobManagerFailsITCase.scala --- @@ -53,41 +54,41 @@ class

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-09-08 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/948#discussion_r38958292 --- Diff: flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/SchedulerUtils.scala --- @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-09-08 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/948#issuecomment-138649089 it seems that the taskmanagers are failing and the scheduler keeps scheduling new ones: http://i.imgur.com/iZiYa4u.png --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2408] Define all maven properties outsi...

2015-09-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/941#issuecomment-139186364 I will rebase and merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2639] Add repository for hdp specific j...

2015-09-10 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1113 [FLINK-2639] Add repository for hdp specific jetty to 'vendor-repos' profile This adds a second hortonworks repository to the `vendor-repos` profile. Certain HDP-specific Hadoop releases depend

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-139194317 > The cancel only sets an internal variable. That is probably true for all sources that Flink provides. But the interface for sources is a public

[GitHub] flink pull request: [FLINK-2631] [streaming] Fixes the StreamFold ...

2015-09-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1101#issuecomment-139178919 +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: FLINK-1737: Kronecker product

2015-09-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1078#issuecomment-138825531 Thanks a lot for the pull request. Sorry that nobody looked at it yet. It seems that all committers are currently very busy. I'm sure somebody will give you soon

[GitHub] flink pull request: FLINK-1737: Kronecker product

2015-09-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1078#issuecomment-138826497 Your build is failing due to scalastyle checks ``` [INFO] [INFO] --- maven-failsafe-plugin:2.17:verify (default) @ flink-ml --- [INFO] Failsafe

[GitHub] flink pull request: [FLINK-2600] Enable test rerun for Elasticsear...

2015-09-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1108#issuecomment-138820891 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-2632] Web Client does not respect the c...

2015-09-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1114#issuecomment-139223104 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138885088 I agree with your proposal! If `yarn.defaultNumberOfTaskManagers` is set to an invalid value, we should make `-n` required. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2654][flink-java] Add JavaDoc to Parame...

2015-09-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1116#discussion_r39173067 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -136,15 +157,35 @@ public static ParameterTool

[GitHub] flink pull request: [FLINK-2654][flink-java] Add JavaDoc to Parame...

2015-09-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1116#issuecomment-139280931 Thanks a lot for adding the Javadocs to the class. Good work! I have some comments in the diff. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2654][flink-java] Add JavaDoc to Parame...

2015-09-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1116#discussion_r39173366 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -234,6 +295,10 @@ public long getLong(String key

[GitHub] flink pull request: [FLINK-2654][flink-java] Add JavaDoc to Parame...

2015-09-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1116#discussion_r39173008 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -124,6 +138,13 @@ else if(arg.startsWith

[GitHub] flink pull request: [FLINK-2654][flink-java] Add JavaDoc to Parame...

2015-09-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1116#discussion_r39173169 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -124,6 +138,13 @@ else if(arg.startsWith

[GitHub] flink pull request: [FLINK-2654][flink-java] Add JavaDoc to Parame...

2015-09-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1116#discussion_r39172874 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -124,6 +138,13 @@ else if(arg.startsWith

[GitHub] flink pull request: [FLINK-2617] Added static mutexes for configur...

2015-09-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/#issuecomment-138928137 +1 Looks good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

2015-09-10 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1117 [FLINK-2656] Fix behavior of FlinkKafkaConsumer for out of range offsets You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink

[GitHub] flink pull request: [FLINK-2665] [api-breaking] [runtime] Makes Ex...

2015-09-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1128#issuecomment-140153585 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1134#issuecomment-140663091 Big change, but I didn't spot anything suspicious. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140730955 There is a test failure ``` StormWrapperSetupHelperTest.testCreateTopologyContext:190 » ClassCast class su... ``` --- If your project is set up

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1084#issuecomment-140732373 I think the pull request has grown quite a lot. I think we should merge it now and then improve it from there. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2640][yarn] integrate off-heap configur...

2015-09-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1132#issuecomment-140748694 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1084#discussion_r39624668 --- Diff: .travis.yml --- @@ -19,9 +19,9 @@ matrix: - jdk: "oraclejdk7" # this will also deploy a uberjar to s3 at some point

[GitHub] flink pull request: [FLINK-2200] Add Flink with Scala 2.11 in Mave...

2015-09-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/885#issuecomment-140731019 I agree. We need to use the script. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1135#discussion_r39624182 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1084#discussion_r39640862 --- Diff: .travis.yml --- @@ -19,9 +19,9 @@ matrix: - jdk: "oraclejdk7" # this will also deploy a uberjar to s3 at some point

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

2015-09-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1117#discussion_r39251890 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

2015-09-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1117#issuecomment-139491178 Sorry Henry. I've updated the description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

2015-09-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1117#issuecomment-139529893 Thank you for the review. I'll merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-141016403 Sorry for the late response, I didn't see this new pull request. The failed test is okay. The test is known for being unstable. --- If your project is set up

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-141019208 For others who follow this PR, there was already some discussion on this change here: https://github.com/apache/flink/pull/1107 --- If your project is set up

[GitHub] flink pull request: [FLINK-2357] Add the new web dashboard and mon...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1139#issuecomment-141035558 I agree with this approach, so +1 to merge ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2357] Add the new web dashboard and mon...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1139#issuecomment-141050563 Another follow-up todo is adding support for yarn: ``` 11:31:01,955 ERROR org.apache.flink.runtime.jobmanager.JobManager - WebServer could

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1121#discussion_r39725184 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -130,6 +130,15 @@ state.backend: jobmanager

[GitHub] flink pull request: [FLINK-2357] Add the new web dashboard and mon...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1139#issuecomment-141018736 Very nice. I tried the new interface locally, and it seems to work. I suspect these values are still test values? http://i.imgur.com/d9ZRR7g.png

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1121#discussion_r39725238 --- Diff: flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java --- @@ -111,6 +111,20 @@ public void testClientStartup

[GitHub] flink pull request: [FLINK-2689] [runtime] Fix reuse of null objec...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1136#issuecomment-141168778 Hi @srowen, thank you for notifying us. We were trying out https://github.com/databricks/spark-pr-dashboard on Google App Engine (because we are also getting more

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1134#issuecomment-141167625 Hey @rxin, I'm really sorry that this happened. Max told me that he stopped the application on AppEngine as soon as he learned that the tool is not working as expected

[GitHub] flink pull request: [FLINK-2641] integrate off-heap memory configu...

2015-09-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1125#issuecomment-140029908 The pull request should also update the documentation. In particular these configuration values affect the documentation in many places. --- If your project is set up

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/593#discussion_r40493024 --- Diff: flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java --- @@ -51,12 +50,25 @@ public void

<    3   4   5   6   7   8   9   10   11   12   >