[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-554897893 Failed tests are unrelated to this PR, and not reproduced in my local env.

[jira] [Commented] (HBASE-23269) Hbase crashed due to two versions of regionservers when rolling upgrading

[ https://issues.apache.org/jira/browse/HBASE-23269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976335#comment-16976335 ] HBase QA commented on HBASE-23269: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #840: HBASE-23269:Hbase crashed due to two versions of regionservers when r…

Apache-HBase commented on issue #840: HBASE-23269:Hbase crashed due to two versions of regionservers when r… URL: https://github.com/apache/hbase/pull/840#issuecomment-554897058 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] xujianzhen opened a new pull request #840: HBASE-23269:Hbase crashed due to two versions of regionservers when r…

xujianzhen opened a new pull request #840: HBASE-23269:Hbase crashed due to two versions of regionservers when r… URL: https://github.com/apache/hbase/pull/840 HBASE-23269:Hbase crashed due to two versions of regionservers when rolling upgrading

[GitHub] [hbase] Apache-HBase commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

Apache-HBase commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-554888674 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #817: HBASE-23278 Add a table-level compaction progress display on the UI (for branch-1)

Apache-HBase commented on issue #817: HBASE-23278 Add a table-level compaction progress display on the UI (for branch-1) URL: https://github.com/apache/hbase/pull/817#issuecomment-554884031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554873190 @Apache9 Can you please take a look now, moved into replication peer

[jira] [Comment Edited] (HBASE-22978) Online slow response log

[ https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970182#comment-16970182 ] Viraj Jasani edited comment on HBASE-22978 at 11/18/19 6:19 AM: Please

[jira] [Resolved] (HBASE-23301) Generate CHANGES.md and RELEASENOTES.md for 2.1.8

[ https://issues.apache.org/jira/browse/HBASE-23301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23301. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to branch-2.1. Thanks [~zghao] for

[GitHub] [hbase] Apache9 merged pull request #839: HBASE-23301 Generate CHANGES.md and RELEASENOTES.md for 2.1.8

Apache9 merged pull request #839: HBASE-23301 Generate CHANGES.md and RELEASENOTES.md for 2.1.8 URL: https://github.com/apache/hbase/pull/839 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on issue #839: HBASE-23301 Generate CHANGES.md and RELEASENOTES.md for 2.1.8

Apache-HBase commented on issue #839: HBASE-23301 Generate CHANGES.md and RELEASENOTES.md for 2.1.8 URL: https://github.com/apache/hbase/pull/839#issuecomment-554862640 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976297#comment-16976297 ] HBase QA commented on HBASE-23309: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976295#comment-16976295 ] HBase QA commented on HBASE-23309: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976276#comment-16976276 ] HBase QA commented on HBASE-23309: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

Apache-HBase commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554846914 :broken_heart: **-1 overall** | Vote |

[GitHub] [hbase] Apache-HBase commented on issue #817: HBASE-23278 Add a table-level compaction progress display on the UI (for branch-1)

Apache-HBase commented on issue #817: HBASE-23278 Add a table-level compaction progress display on the UI (for branch-1) URL: https://github.com/apache/hbase/pull/817#issuecomment-554841623 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] JeongDaeKim commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#discussion_r347191344 ## File path:

[GitHub] [hbase] JeongDaeKim commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#discussion_r347190247 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #839: HBASE-23301 Generate CHANGES.md and RELEASENOTES.md for 2.1.8

Apache-HBase commented on issue #839: HBASE-23301 Generate CHANGES.md and RELEASENOTES.md for 2.1.8 URL: https://github.com/apache/hbase/pull/839#issuecomment-554831345 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 opened a new pull request #839: HBASE-23301 Generate CHANGES.md and RELEASENOTES.md for 2.1.8

Apache9 opened a new pull request #839: HBASE-23301 Generate CHANGES.md and RELEASENOTES.md for 2.1.8 URL: https://github.com/apache/hbase/pull/839 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on issue #838: Adding tests for WALCellFilter to cover all the scenarios

Apache-HBase commented on issue #838: Adding tests for WALCellFilter to cover all the scenarios URL: https://github.com/apache/hbase/pull/838#issuecomment-554829209 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Resolved] (HBASE-23306) Add sanity check for Admin#deleteTables and other operations

[ https://issues.apache.org/jira/browse/HBASE-23306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Kesharwani resolved HBASE-23306. -- Resolution: Not A Bug The submitted behavior is working as expected hence marking

[GitHub] [hbase] Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554828314 In ReplicationPeerConfig we have a configuration field, which can be used I

[jira] [Commented] (HBASE-23306) Add sanity check for Admin#deleteTables and other operations

[ https://issues.apache.org/jira/browse/HBASE-23306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976245#comment-16976245 ] Rahul Kesharwani commented on HBASE-23306: -- Thanks, [~wchevreuil] for explanation and

[GitHub] [hbase] sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554827477 @Apache9 I see what you mean, and make sense to me. I can make a

[GitHub] [hbase] Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554826836 A replication peer could also have configurations I think?

[jira] [Reopened] (HBASE-23301) Generate CHANGES.md and RELEASENOTES.md for 2.1.8

[ https://issues.apache.org/jira/browse/HBASE-23301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-23301: --- > Generate CHANGES.md and RELEASENOTES.md for 2.1.8 > -

[GitHub] [hbase] sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554825360 @Apache9 I am not sure if adding this in Configuration will help us:

[jira] [Updated] (HBASE-23301) Generate CHANGES.md and RELEASENOTES.md for 2.1.8

[ https://issues.apache.org/jira/browse/HBASE-23301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23301: -- Fix Version/s: 2.1.8 > Generate CHANGES.md and RELEASENOTES.md for 2.1.8 >

[jira] [Updated] (HBASE-23301) Generate CHANGES.md and RELEASENOTES.md for 2.1.8

[ https://issues.apache.org/jira/browse/HBASE-23301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23301: -- Component/s: documentation > Generate CHANGES.md and RELEASENOTES.md for 2.1.8 >

[jira] [Resolved] (HBASE-23301) Generate CHANGES.md and RELEASENOTES.md for 2.1.8

[ https://issues.apache.org/jira/browse/HBASE-23301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23301. --- Resolution: Fixed For generating changes. > Generate CHANGES.md and RELEASENOTES.md for 2.1.8 >

[GitHub] [hbase] Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554823872 I mean can we add a configuration for this flag?

[GitHub] [hbase] sandeepvinayak edited a comment on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak edited a comment on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554823546 @Apache9 That's correct, if hbase wants to use this flag in

[GitHub] [hbase] sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554823546 @Apache9 That's correct, if hbase wants to use this flag in all the

[GitHub] [hbase] Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554821495 This means you need to change the code of HBase right itelf and rebuild

[GitHub] [hbase] sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554821242 For example

[GitHub] [hbase] sandeepvinayak edited a comment on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak edited a comment on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554820318 @Apache9 Just like I set the flag in test ```java

[GitHub] [hbase] sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554820318 @Apache9 Just like I set the flag in test ```java

[GitHub] [hbase] infraio commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

infraio commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347177698 ## File path:

[jira] [Work started] (HBASE-23301) Generate CHANGES.md and RELEASENOTES.md for 2.1.8

[ https://issues.apache.org/jira/browse/HBASE-23301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23301 started by Duo Zhang. - > Generate CHANGES.md and RELEASENOTES.md for 2.1.8 >

[jira] [Assigned] (HBASE-23301) Generate CHANGES.md and RELEASENOTES.md for 2.1.8

[ https://issues.apache.org/jira/browse/HBASE-23301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23301: - Assignee: Duo Zhang > Generate CHANGES.md and RELEASENOTES.md for 2.1.8 >

[GitHub] [hbase] infraio commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

infraio commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347177615 ## File path:

[GitHub] [hbase] infraio commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

infraio commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347177592 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs

Apache-HBase commented on issue #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs URL: https://github.com/apache/hbase/pull/722#issuecomment-554814327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

Apache9 commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554814262 I think usually the filter chain is set up by configuration? Then how do you

[GitHub] [hbase] sandeepvinayak closed pull request #838: Adding tests for WALCellFilter to cover all the scenarios

sandeepvinayak closed pull request #838: Adding tests for WALCellFilter to cover all the scenarios URL: https://github.com/apache/hbase/pull/838 This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (HBASE-23310) Add tests for WALCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal resolved HBASE-23310. - Resolution: Duplicate Added as a part of HBASE-23309 > Add tests for WALCellFilter >

[jira] [Updated] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Attachment: HBASE-23309.branch-2.patch > Add support in ChainWalEntryFilter to filter Entry if

[jira] [Updated] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Attachment: HBASE-23309.branch-1.patch > Add support in ChainWalEntryFilter to filter Entry if

[GitHub] [hbase] Apache-HBase commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

Apache-HBase commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-554806538 :broken_heart: **-1 overall** | Vote |

[jira] [Updated] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Attachment: HBASE-23309.patch Status: Patch Available (was: In Progress) > Add support

[jira] [Updated] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Description: ChainWalEntryFilter applies the filter on entry followed by filter on cells.  If

[jira] [Updated] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Summary: Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through

[jira] [Updated] (HBASE-23309) Entries get replicated even though all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Description: ChainWalEntryFilter applies the filter on entry followed by filter on cells.  If

[jira] [Commented] (HBASE-23309) Entries get replicated even though all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976204#comment-16976204 ] Sandeep Pal commented on HBASE-23309: -

[jira] [Updated] (HBASE-23309) Entries get replicated even though all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Issue Type: Improvement (was: Bug) > Entries get replicated even though all cells get filtered

[jira] [Work started] (HBASE-23309) Entries get replicated even though all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23309 started by Sandeep Pal. --- > Entries get replicated even though all cells get filtered through >

[jira] [Commented] (HBASE-23310) Add tests for WALCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976195#comment-16976195 ] Sandeep Pal commented on HBASE-23310: - [https://github.com/apache/hbase/pull/838] > Add tests for

[GitHub] [hbase] sandeepvinayak opened a new pull request #838: Adding tests for WALCellFilter to cover all the scenarios

sandeepvinayak opened a new pull request #838: Adding tests for WALCellFilter to cover all the scenarios URL: https://github.com/apache/hbase/pull/838 Scenarios to cover the WALCellFilter: 1. Filter some cells walcellfiter 2. Filter all cells 3. Filter some cells walcellfilter but

[GitHub] [hbase] ankitsinghal commented on issue #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs

ankitsinghal commented on issue #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs URL: https://github.com/apache/hbase/pull/722#issuecomment-554798490 @brfrn169 , have taken the review comments in the latest push. Let me know how it looks?

[jira] [Created] (HBASE-23310) Add tests for WALCellFilter

Sandeep Pal created HBASE-23310: --- Summary: Add tests for WALCellFilter Key: HBASE-23310 URL: https://issues.apache.org/jira/browse/HBASE-23310 Project: HBase Issue Type: Improvement

[jira] [Updated] (HBASE-23309) Entries get replicated even though all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Description: ChainWalEntryFilter applies the filter on entry followed by filter on cells.  If

[GitHub] [hbase] sandeepvinayak opened a new pull request #837: Fixing the ChainWalEntryFilter to filter the whole entry if all cells get filtered

sandeepvinayak opened a new pull request #837: Fixing the ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837 Fixing the ChainWalEntryFilter to filter the whole entry if all cell get filtered. Also, adding test cases for

[jira] [Updated] (HBASE-23309) Entries get replicated even though all cells get filtered through WalCellFilter

[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-23309: Description: ChainWalEntryFilter applies the filter on entry followed by filter on cells.  If

[jira] [Commented] (HBASE-23308) Review of NullPointerExceptions

[ https://issues.apache.org/jira/browse/HBASE-23308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976173#comment-16976173 ] HBase QA commented on HBASE-23308: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #836: HBASE-23308: Review of NullPointerExceptions

Apache-HBase commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554791271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Created] (HBASE-23309) Entries get replicated even though all cells get filtered through WalCellFilter

Sandeep Pal created HBASE-23309: --- Summary: Entries get replicated even though all cells get filtered through WalCellFilter Key: HBASE-23309 URL: https://issues.apache.org/jira/browse/HBASE-23309

[GitHub] [hbase] belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions

belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554781113 Please node that I changed a couple of NPE to be IllegalStateException (Guava Preconditions#checkState) as these are more appropriate

[GitHub] [hbase] belugabehr edited a comment on issue #836: HBASE-23308: Review of NullPointerExceptions

belugabehr edited a comment on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554781113 Please note that I changed a couple of NPE to be IllegalStateException (Guava Preconditions#checkState) as these are more

[GitHub] [hbase] karthikhw commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond

karthikhw commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834#discussion_r347149839 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRequestsPerSecondMetric.java

[GitHub] [hbase] karthikhw commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond

karthikhw commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834#discussion_r347149839 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRequestsPerSecondMetric.java

[GitHub] [hbase] belugabehr commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions

belugabehr commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#discussion_r347149074 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@

[GitHub] [hbase] belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions

belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554768282 @saintstack Hey, sorry, didn't see that you reviewed this code already so I tried to put in a force-push to keep things cleaner. Ended up

[GitHub] [hbase] belugabehr commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions

belugabehr commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#discussion_r347148986 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java ## @@ -187,10

[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore

[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976057#comment-16976057 ] Hudson commented on HBASE-19450: Results for branch master [build #1539 on

[jira] [Commented] (HBASE-23289) Update links to Hadoop wiki in code and book

[ https://issues.apache.org/jira/browse/HBASE-23289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976032#comment-16976032 ] HBase QA commented on HBASE-23289: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated

wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#discussion_r347131612 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated

wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#discussion_r347130863 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated

wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#discussion_r347130863 ## File path:

[jira] [Commented] (HBASE-23306) Add sanity check for Admin#deleteTables and other operations

[ https://issues.apache.org/jira/browse/HBASE-23306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975968#comment-16975968 ] Wellington Chevreuil commented on HBASE-23306: -- Apart from _ listTableNames_, all these

[jira] [Updated] (HBASE-23102) Improper Usage of Map putIfAbsent

[ https://issues.apache.org/jira/browse/HBASE-23102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23102: - Fix Version/s: 3.0.0 Resolution: Fixed Status: Resolved (was:

[GitHub] [hbase] wchevreuil merged pull request #828: HBASE-23102: Improper Usage of Map putIfAbsent

wchevreuil merged pull request #828: HBASE-23102: Improper Usage of Map putIfAbsent URL: https://github.com/apache/hbase/pull/828 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975942#comment-16975942 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #182 on

[GitHub] [hbase] chenxu14 commented on a change in pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table

chenxu14 commented on a change in pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table URL: https://github.com/apache/hbase/pull/831#discussion_r347123564 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java

[jira] [Commented] (HBASE-23297) [RSGROUP] build RegionPlan per group not per table

[ https://issues.apache.org/jira/browse/HBASE-23297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975941#comment-16975941 ] chenxu commented on HBASE-23297: ya, it's an improvement, the orginal balanceRSGroup will have a final