[GitHub] [hbase] Apache-HBase commented on issue #902: HBASE-23369 Auto-close 'unknown' Regions reported as OPEN on RegionSe…

2019-12-10 Thread GitBox
Apache-HBase commented on issue #902: HBASE-23369 Auto-close 'unknown' Regions reported as OPEN on RegionSe… URL: https://github.com/apache/hbase/pull/902#issuecomment-564396695 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356418306 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -3

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356415242 ## File path: hbase-shell/src/main/ruby/shell/commands/regioninfo.rb ## @@ -0,0 +1,43 @@ +# +# Li

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356415005 ## File path: hbase-shell/src/main/ruby/shell/commands/regioninfo.rb ## @@ -0,0 +1,43 @@ +# +# Li

[GitHub] [hbase] saintstack commented on issue #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on issue #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#issuecomment-564392786 Thanks for review @busbey and @Apache9 New patch coming that addresses most of @busbey remarks. -

[GitHub] [hbase] Apache-HBase commented on issue #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-10 Thread GitBox
Apache-HBase commented on issue #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#issuecomment-564391805 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Com

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356414281 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356413666 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356413304 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356412846 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -6

[jira] [Commented] (HBASE-23360) [CLI] Fix help command "set_quota"

2019-12-10 Thread Karthik Palanisamy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993220#comment-16993220 ] Karthik Palanisamy commented on HBASE-23360: [~busbey] Can we push this smal

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356412656 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -3

[jira] [Commented] (HBASE-23304) Implement RPCs needed for master based registry

2019-12-10 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993206#comment-16993206 ] HBase QA commented on HBASE-23304: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[GitHub] [hbase] Apache-HBase commented on issue #904: HBASE-23304: RPCs needed for client meta information lookup

2019-12-10 Thread GitBox
Apache-HBase commented on issue #904: HBASE-23304: RPCs needed for client meta information lookup URL: https://github.com/apache/hbase/pull/904#issuecomment-564387399 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356409532 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -346,1

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356379257 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -3

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401486 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356399650 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356406568 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java #

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356408051 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356408435 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java #

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401355 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401076 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordi

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356400203 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java ## @@ -19

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356403979 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java ## @@ -307

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401512 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356402058 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java ## @@

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401455 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356407527 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356399689 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java ## @@ -86

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401416 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356404492 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOut

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356404105 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/HFileLink.java ## @@ -42

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356404616 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheFactory.java ###

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356399626 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356407861 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356406751 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356404353 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOut

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356400457 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java #

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356406100 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356406787 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356400528 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java #

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401184 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordi

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401333 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356408206 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java #

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401465 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401152 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordi

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401436 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356407736 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356401305 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordin

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356406136 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356407797 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356407410 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356408716 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java #

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356399534 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java ##

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356399679 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java ## @@ -69

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356405876 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java ## @@

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356405455 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java

[GitHub] [hbase] busbey commented on issue #928: HBASE-23549 Document steps to disable MOB for a column family

2019-12-10 Thread GitBox
busbey commented on issue #928: HBASE-23549 Document steps to disable MOB for a column family URL: https://github.com/apache/hbase/pull/928#issuecomment-564381955 the checkstyle and whitespace stuff is from #785 and the unit test failures are not related. -

[GitHub] [hbase] busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil

2019-12-10 Thread GitBox
busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912#discussion_r356396164 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java ## @@ -138,20 +137,26 @@ public

[GitHub] [hbase] busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil

2019-12-10 Thread GitBox
busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912#discussion_r356398464 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java ## @@ -965,11 +964,10 @@ public

[GitHub] [hbase] busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil

2019-12-10 Thread GitBox
busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912#discussion_r356397018 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java ## @@ -546,19 +544,19 @@ public

[GitHub] [hbase] busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil

2019-12-10 Thread GitBox
busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912#discussion_r356398148 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java ## @@ -940,7 +939,7 @@ protected

[GitHub] [hbase] busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil

2019-12-10 Thread GitBox
busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912#discussion_r356397891 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java ## @@ -771,7 +770,7 @@ static pu

[GitHub] [hbase] Apache-HBase commented on issue #924: HBASE-23555 TestQuotaThrottle is broken

2019-12-10 Thread GitBox
Apache-HBase commented on issue #924: HBASE-23555 TestQuotaThrottle is broken URL: https://github.com/apache/hbase/pull/924#issuecomment-564374005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hbase] Apache-HBase commented on issue #928: HBASE-23549 Document steps to disable MOB for a column family

2019-12-10 Thread GitBox
Apache-HBase commented on issue #928: HBASE-23549 Document steps to disable MOB for a column family URL: https://github.com/apache/hbase/pull/928#issuecomment-564368347 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[jira] [Commented] (HBASE-23379) Clean Up FSUtil getRegionLocalityMappingFromFS

2019-12-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993171#comment-16993171 ] Hudson commented on HBASE-23379: Results for branch branch-2.1 [build #1737 on

[jira] [Commented] (HBASE-23376) NPE happens while replica region is moving

2019-12-10 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993147#comment-16993147 ] Duo Zhang commented on HBASE-23376: --- OK, will take a look soon today. IIRC there are s

[GitHub] [hbase] saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
saintstack commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356379257 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -3

[jira] [Commented] (HBASE-23376) NPE happens while replica region is moving

2019-12-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993144#comment-16993144 ] Michael Stack commented on HBASE-23376: --- [~Ddupg] +1 Could still NPE though, right

[jira] [Commented] (HBASE-23553) Snapshot referenced data files are deleted in some case

2019-12-10 Thread Yi Mei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993143#comment-16993143 ] Yi Mei commented on HBASE-23553: Pushed to master, branch-2, branch-2.2 The pacth has s

[GitHub] [hbase] Apache-HBase commented on issue #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
Apache-HBase commented on issue #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#issuecomment-564344381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356366437 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -346,1

[GitHub] [hbase] ndimiduk commented on issue #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-10 Thread GitBox
ndimiduk commented on issue #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#issuecomment-564337707 This version reverts the "controversial" changes from `AssignmentManager`. The changes remaini

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356362451 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ##

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356361454 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -346,1

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356361764 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -346,1

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356364580 ## File path: hbase-shell/src/main/ruby/shell/commands/regioninfo.rb ## @@ -0,0 +1,43 @@ +# +# Licens

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356363681 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ##

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356362018 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -622,9

[GitHub] [hbase] mymeiyi merged pull request #922: HBASE-23553 Snapshot referenced data files are deleted in some case

2019-12-10 Thread GitBox
mymeiyi merged pull request #922: HBASE-23553 Snapshot referenced data files are deleted in some case URL: https://github.com/apache/hbase/pull/922 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356363954 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@

[GitHub] [hbase] busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility

2019-12-10 Thread GitBox
busbey commented on a change in pull request #923: HBASE-23554 Encoded regionname to regionname utility URL: https://github.com/apache/hbase/pull/923#discussion_r356361192 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -346,1

[GitHub] [hbase] bharathv commented on a change in pull request #904: HBASE-23304: RPCs needed for client meta information lookup

2019-12-10 Thread GitBox
bharathv commented on a change in pull request #904: HBASE-23304: RPCs needed for client meta information lookup URL: https://github.com/apache/hbase/pull/904#discussion_r356360385 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClientMetaServiceRPCs.jav

[GitHub] [hbase] bharathv commented on a change in pull request #904: HBASE-23304: RPCs needed for client meta information lookup

2019-12-10 Thread GitBox
bharathv commented on a change in pull request #904: HBASE-23304: RPCs needed for client meta information lookup URL: https://github.com/apache/hbase/pull/904#discussion_r356363305 ## File path: hbase-protocol-shaded/src/main/protobuf/Master.proto ## @@ -1200,3 +1200,47 @@

[GitHub] [hbase] Apache-HBase commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells

2019-12-10 Thread GitBox
Apache-HBase commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-564334002 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:---

[jira] [Commented] (HBASE-23377) Balancer should skip disabled tables's regions

2019-12-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993109#comment-16993109 ] Hudson commented on HBASE-23377: Results for branch branch-2.2 [build #720 on b

[GitHub] [hbase] bharathv commented on a change in pull request #872: HBASE-23333 Provide call context around timeouts and other failure scenarios

2019-12-10 Thread GitBox
bharathv commented on a change in pull request #872: HBASE-2 Provide call context around timeouts and other failure scenarios URL: https://github.com/apache/hbase/pull/872#discussion_r354687211 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/Call.java #

[jira] [Commented] (HBASE-23377) Balancer should skip disabled tables's regions

2019-12-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993106#comment-16993106 ] Hudson commented on HBASE-23377: Results for branch branch-2 [build #2381 on bu

[jira] [Commented] (HBASE-23281) Track meta region changes on masters

2019-12-10 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993105#comment-16993105 ] Bharath Vissapragada commented on HBASE-23281: -- [~ndimiduk] Sorry, I was wa

[jira] [Comment Edited] (HBASE-23281) Track meta region changes on masters

2019-12-10 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993105#comment-16993105 ] Bharath Vissapragada edited comment on HBASE-23281 at 12/11/19 1:04 AM: --

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356352368 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordi

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356352038 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/example/TableHFileArchiveTrac

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356352548 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordi

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356354063 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordi

[GitHub] [hbase] busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module

2019-12-10 Thread GitBox
busbey commented on a change in pull request #916: HBASE-23382: Clean up Logging for Some of hbase-server Module URL: https://github.com/apache/hbase/pull/916#discussion_r356354250 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordi

[GitHub] [hbase] Apache-HBase commented on issue #913: HBASE-23381: Improve Logging in HBase Commons Package

2019-12-10 Thread GitBox
Apache-HBase commented on issue #913: HBASE-23381: Improve Logging in HBase Commons Package URL: https://github.com/apache/hbase/pull/913#issuecomment-564326631 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:

[jira] [Commented] (HBASE-23381) Improve Logging in HBase Commons Package

2019-12-10 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993089#comment-16993089 ] HBase QA commented on HBASE-23381: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Updated] (HBASE-23120) Fix ref guide - Release process

2019-12-10 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-23120: --- Fix Version/s: (was: 2.2.3) 2.2.4 > Fix ref guide - Release process >

[jira] [Updated] (HBASE-22640) Random init hstore lastFlushTime

2019-12-10 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22640: --- Fix Version/s: (was: 2.2.3) 2.2.4 > Random init hstore lastFlushTime

  1   2   3   >