[jira] [Resolved] (HBASE-23987) NettyRpcClientConfigHelper will not share event loop by default which is incorrect

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23987. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~stack] for r

[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-599015485 Thanks Nick Please review the patch @ndimiduk @saintstack

[GitHub] [hbase] Apache9 merged pull request #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

2020-03-13 Thread GitBox
Apache9 merged pull request #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288#issuecomment-599010550 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hbase] Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288#issuecomment-599009740 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hbase] Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288#issuecomment-599009559 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[jira] [Commented] (HBASE-23955) Have test runs use less resources

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059172#comment-17059172 ] Duo Zhang commented on HBASE-23955: --- https://github.com/apache/hbase/pull/1288 > Have

[jira] [Commented] (HBASE-23955) Have test runs use less resources

2020-03-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059170#comment-17059170 ] Michael Stack commented on HBASE-23955: --- How about this? {code} diff --git a/hba

[GitHub] [hbase] Apache9 opened a new pull request #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

2020-03-13 Thread GitBox
Apache9 opened a new pull request #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288 …efault which is incorrect This is an automated message from the A

[jira] [Commented] (HBASE-23955) Have test runs use less resources

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059167#comment-17059167 ] Duo Zhang commented on HBASE-23955: --- Created HBASE-23987. Patch will be read soon. >

[jira] [Commented] (HBASE-23955) Have test runs use less resources

2020-03-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059166#comment-17059166 ] Michael Stack commented on HBASE-23955: --- Thanks [~zhangduo] This bit: - ret

[jira] [Work started] (HBASE-23987) NettyRpcClientConfigHelper will not share event loop by default which is incorrect

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23987 started by Duo Zhang. - > NettyRpcClientConfigHelper will not share event loop by default which is > incorre

[jira] [Created] (HBASE-23987) NettyRpcClientConfigHelper will not share event loop by default which is incorrect

2020-03-13 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-23987: - Summary: NettyRpcClientConfigHelper will not share event loop by default which is incorrect Key: HBASE-23987 URL: https://issues.apache.org/jira/browse/HBASE-23987 Project:

[jira] [Resolved] (HBASE-23955) Have test runs use less resources

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23955. --- Resolution: Duplicate Oh, posted on the wrong issue... > Have test runs use less resources > --

[jira] [Commented] (HBASE-23955) Have test runs use less resources

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059164#comment-17059164 ] Duo Zhang commented on HBASE-23955: --- This is easy to introduce too many open files in

[jira] [Commented] (HBASE-23955) Have test runs use less resources

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059163#comment-17059163 ] Duo Zhang commented on HBASE-23955: --- Hi sir, the implementation of NettyRpcClientConfi

[jira] [Commented] (HBASE-23967) Improve the accuracy of the method sizeToString

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059161#comment-17059161 ] Hudson commented on HBASE-23967: Results for branch branch-2.1 [build #1834 on

[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-598998996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-598996755 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:

[jira] [Updated] (HBASE-23986) Bump hadoop-two.version to 2.10.0 on master and branch-2

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23986: -- Description: See this discussion on mailing list > Bump hadoop-two.version to 2.10.0 on master and bra

[jira] [Updated] (HBASE-23986) Bump hadoop-two.version to 2.10.0 on master and branch-2

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23986: -- Description: See this discussion on mailing list https://lists.apache.org/thread.html/rbab2e79f25b38c

[jira] [Created] (HBASE-23986) Bump hadoop-two.version to 2.10.0 on master and branch-2

2020-03-13 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-23986: - Summary: Bump hadoop-two.version to 2.10.0 on master and branch-2 Key: HBASE-23986 URL: https://issues.apache.org/jira/browse/HBASE-23986 Project: HBase Issue Type

[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-598994263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hbase] Apache9 commented on a change in pull request #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value

2020-03-13 Thread GitBox
Apache9 commented on a change in pull request #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#discussion_r392545075 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ass

[jira] [Commented] (HBASE-23982) Shell tests broken

2020-03-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059145#comment-17059145 ] Duo Zhang commented on HBASE-23982: --- You need to check the output to find out the real

[GitHub] [hbase] Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#issuecomment-598992197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-598992263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hbase] Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#issuecomment-598991980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hbase] Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan URL: https://github.com/apache/hbase/pull/1208#issuecomment-598991818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-598991733 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:

[jira] [Commented] (HBASE-23985) [flakey test] TestZooKeeper

2020-03-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059143#comment-17059143 ] Nick Dimiduk commented on HBASE-23985: -- Ugh, this test has a [long history|https:/

[jira] [Commented] (HBASE-23985) [flakey test] TestZooKeeper

2020-03-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059142#comment-17059142 ] Nick Dimiduk commented on HBASE-23985: -- Attaching log file from the run. Perhaps n

[GitHub] [hbase] Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#issuecomment-598990829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HBASE-23985) [flakey test] TestZooKeeper

2020-03-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23985: - Attachment: TEST-org.apache.hadoop.hbase.TestZooKeeper.xml > [flakey test] TestZooKeeper > -

[jira] [Created] (HBASE-23985) [flakey test] TestZooKeeper

2020-03-13 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-23985: Summary: [flakey test] TestZooKeeper Key: HBASE-23985 URL: https://issues.apache.org/jira/browse/HBASE-23985 Project: HBase Issue Type: Test Compon

[GitHub] [hbase] Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan URL: https://github.com/apache/hbase/pull/1208#issuecomment-598985699 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[jira] [Updated] (HBASE-23983) Spotbugs warning complain on master build

2020-03-13 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-23983: -- Status: Patch Available (was: In Progress) > Spotbugs warning complain on master build >

[GitHub] [hbase] HorizonNet opened a new pull request #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value

2020-03-13 Thread GitBox
HorizonNet opened a new pull request #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287 This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-598983102 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:

[jira] [Work started] (HBASE-23983) Spotbugs warning complain on master build

2020-03-13 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23983 started by Jan Hentschel. - > Spotbugs warning complain on master build > ---

[jira] [Created] (HBASE-23984) [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown

2020-03-13 Thread Michael Stack (Jira)
Michael Stack created HBASE-23984: - Summary: [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown Key: HBASE-23984 URL: https://issues.apache.org/jira/browse/HBASE-23984 Project: HBase

[jira] [Created] (HBASE-23983) Spotbugs warning complain on master build

2020-03-13 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-23983: - Summary: Spotbugs warning complain on master build Key: HBASE-23983 URL: https://issues.apache.org/jira/browse/HBASE-23983 Project: HBase Issue Type: Impro

[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598979839 @virajjasani Sorry, yes, the utility method to which I refer is [`HBaseCommonTestingUtility#waitFor`](https://github.

[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-598978728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-598978127 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-598973110 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hbase] Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan URL: https://github.com/apache/hbase/pull/1208#issuecomment-598972819 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[jira] [Commented] (HBASE-23967) Improve the accuracy of the method sizeToString

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059125#comment-17059125 ] Hudson commented on HBASE-23967: Results for branch branch-2.2 [build #815 on b

[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598959781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598957434 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-598933669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-598931253 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:

[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-59889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:

[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598892947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[jira] [Updated] (HBASE-23887) BlockCache performance improve

2020-03-13 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Description: НГHi! I first time here, correct me please if something wrong. I want propose h

[GitHub] [hbase] virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598854018 Spotbug in this build has nothing to do with this patch: ``` Return value of putIfAbsent is ignored, but node

[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598877228 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598874977 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[GitHub] [hbase] virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790942 btw I am returning true in `waitFor()` because `confirmPayloadParams` is anyways going to throw AssertError if mat

[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#issuecomment-598866258 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[jira] [Commented] (HBASE-23295) hbase-connectors HBaseContext should use most recent delegation token

2020-03-13 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058998#comment-17058998 ] Sakthi commented on HBASE-23295: Closing out the jira. > hbase-connectors HBaseContext

[jira] [Resolved] (HBASE-23295) hbase-connectors HBaseContext should use most recent delegation token

2020-03-13 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi resolved HBASE-23295. Resolution: Fixed > hbase-connectors HBaseContext should use most recent delegation token > --

[jira] [Updated] (HBASE-23295) hbase-connectors HBaseContext should use most recent delegation token

2020-03-13 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-23295: --- Fix Version/s: connector-1.0.1 > hbase-connectors HBaseContext should use most recent delegation token > ---

[jira] [Commented] (HBASE-23077) move entirely to spotbugs

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058983#comment-17058983 ] Hudson commented on HBASE-23077: Results for branch branch-2 [build #2551 on bu

[jira] [Commented] (HBASE-23861) Reconcile Hadoop version

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058984#comment-17058984 ] Hudson commented on HBASE-23861: Results for branch branch-2 [build #2551 on bu

[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#issuecomment-59886 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[jira] [Commented] (HBASE-23967) Improve the accuracy of the method sizeToString

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058985#comment-17058985 ] Hudson commented on HBASE-23967: Results for branch branch-2 [build #2551 on bu

[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598854018 Spotbug in this build has nothing to do with this patch: ``` Return value of putIfAbsent is ignored, but node is reus

[jira] [Updated] (HBASE-23982) Shell tests broken

2020-03-13 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-23982: -- Issue Type: Bug (was: Improvement) > Shell tests broken > -- > >

[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#issuecomment-598823501 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[jira] [Created] (HBASE-23982) Shell tests broken

2020-03-13 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-23982: - Summary: Shell tests broken Key: HBASE-23982 URL: https://issues.apache.org/jira/browse/HBASE-23982 Project: HBase Issue Type: Improvement Compon

[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598816816 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[GitHub] [hbase] jojochuang commented on issue #1284: HBASE-22103. HDFS-13209 in Hadoop 3.3.0 breaks asyncwal.

2020-03-13 Thread GitBox
jojochuang commented on issue #1284: HBASE-22103. HDFS-13209 in Hadoop 3.3.0 breaks asyncwal. URL: https://github.com/apache/hbase/pull/1284#issuecomment-598811004 @Apache9 would you like to review this one? Thanks This is an

[jira] [Commented] (HBASE-23861) Reconcile Hadoop version

2020-03-13 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058903#comment-17058903 ] Wei-Chiu Chuang commented on HBASE-23861: - I think it depends on the support mat

[jira] [Updated] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:

2020-03-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23977: - Fix Version/s: 2.3.0 3.0.0 Affects Version/s: 2.3.0

[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598796148 > There's a utility method `waitUntil` that lets you wait for a condition to occur, or timeout. Check it's return value fo

[jira] [Commented] (HBASE-23861) Reconcile Hadoop version

2020-03-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058868#comment-17058868 ] Viraj Jasani commented on HBASE-23861: -- oops, yes if transitive dependency is chang

[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790942 btw I am returning true in `waitFor()` because `confirmPayloadParams` is anyways going to throw AssertError if match is no

[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790294 > Maybe try inserting an intentional delay into the machinery around the ringbuffer, so as to tease out a timing bug?

[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598783297 Maybe try inserting an intentional delay into the machinery around the ringbuffer, so as to tease out a timing bug?

[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598783017 There's a utility method `waitUntil` that lets you wait for a condition to occur, or timeout. Check it's return value for the

[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598782970 Yeah agree, let me quickly try it. Thanks @saintstack Th

[jira] [Commented] (HBASE-23861) Reconcile Hadoop version

2020-03-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058852#comment-17058852 ] Nick Dimiduk commented on HBASE-23861: -- If this changes the transitive dependencies

[jira] [Work started] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:

2020-03-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23977 started by Viraj Jasani. > [Flakey Tests] > TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confi

[jira] [Commented] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:

2020-03-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058849#comment-17058849 ] Viraj Jasani commented on HBASE-23977: -- [~stack] Please review [https://github.com/

[GitHub] [hbase] virajjasani opened a new pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder

2020-03-13 Thread GitBox
virajjasani opened a new pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-23970) TestUsersOperationsWithSecureHadoop fails when an existing ticket is present

2020-03-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058842#comment-17058842 ] Nick Dimiduk commented on HBASE-23970: -- I authenticate myself to a kerberos authori

[jira] [Commented] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:

2020-03-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058838#comment-17058838 ] Michael Stack commented on HBASE-23977: --- Thank you [~vjasani]. If you want me to t

[jira] [Commented] (HBASE-23841) Remove deprecated methods from Scan

2020-03-13 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058780#comment-17058780 ] Jan Hentschel commented on HBASE-23841: --- [~zhangduo] Already working on resolving

[jira] [Assigned] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:

2020-03-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-23977: Assignee: Viraj Jasani > [Flakey Tests] > TestSlowLogRecorder.testOnlieSlowLogConsumpti

[jira] [Commented] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:

2020-03-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058771#comment-17058771 ] Viraj Jasani commented on HBASE-23977: -- Let me take this up. Thanks [~stack] > [Fl

[jira] [Resolved] (HBASE-23967) Improve the accuracy of the method sizeToString

2020-03-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-23967. -- Fix Version/s: 2.2.5 2.1.10 1.7.0 2.3.

[GitHub] [hbase] virajjasani merged pull request #1273: HBASE-23967 Improve the accuracy of the method sizeToString

2020-03-13 Thread GitBox
virajjasani merged pull request #1273: HBASE-23967 Improve the accuracy of the method sizeToString URL: https://github.com/apache/hbase/pull/1273 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf

2020-03-13 Thread GitBox
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#issuecomment-598706498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[jira] [Commented] (HBASE-23979) Disable TestSlowLogRecorder until parent addressed

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058669#comment-17058669 ] Hudson commented on HBASE-23979: Results for branch master [build #1665 on buil

[jira] [Commented] (HBASE-23978) Dockerfiles reusing stale apt sources info

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058668#comment-17058668 ] Hudson commented on HBASE-23978: Results for branch master [build #1665 on buil

[jira] [Commented] (HBASE-23077) move entirely to spotbugs

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058670#comment-17058670 ] Hudson commented on HBASE-23077: Results for branch master [build #1665 on buil

[jira] [Commented] (HBASE-23847) Remove deprecated setStartRow(byte[]) from Scan

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058671#comment-17058671 ] Hudson commented on HBASE-23847: Results for branch master [build #1665 on buil

[jira] [Commented] (HBASE-23971) protoc warns: "no protobuf syntax specified"

2020-03-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058667#comment-17058667 ] Hudson commented on HBASE-23971: Results for branch master [build #1665 on buil

[GitHub] [hbase-connectors] LB-Yu opened a new pull request #63: Solve the ambiguous reference for scala 2.12

2020-03-13 Thread GitBox
LB-Yu opened a new pull request #63: Solve the ambiguous reference for scala 2.12 URL: https://github.com/apache/hbase-connectors/pull/63 When the `hbase-spark` module is compiled under the scala 2.12 environment, the following error appears in line 216 of the `org.apache.hadoop.hbase.spa

  1   2   >