[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-07 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r436490904 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java ## @@ -58,8 +60,8 @@ protected void scheduleFlush(String encoded

[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-07 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r436490171 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -180,18 +181,18 @@ public void run() { WAL wal =

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436489350 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -3921,4 +3996,85 @@ public MetaRegionLocationCache getMetaRegio

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436487856 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -3537,4 +3538,30 @@ public static RSGroupInfo toG

[jira] [Updated] (HBASE-24516) Parameter pass incorrectly when refactor SecureBulkLoadClient

2020-06-07 Thread Qilin Cao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qilin Cao updated HBASE-24516: -- Attachment: HBASE-24516.branch-2.2.patch Status: Patch Available (was: Open) commit a patch!

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436486065 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -868,8 +879,71 @@ protected void initializeZKBasedSystemTrackers

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436485635 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java ## @@ -1763,4 +1765,44 @@ default void preHasUserPermissi

[jira] [Created] (HBASE-24516) Parameter pass incorrectly when refactor SecureBulkLoadClient

2020-06-07 Thread Qilin Cao (Jira)
Qilin Cao created HBASE-24516: - Summary: Parameter pass incorrectly when refactor SecureBulkLoadClient Key: HBASE-24516 URL: https://issues.apache.org/jira/browse/HBASE-24516 Project: HBase Issu

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436485144 ## File path: hbase-protocol-shaded/src/main/protobuf/server/master/Master.proto ## @@ -1284,4 +1307,16 @@ service ClientMetaService { * Get current met

[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-07 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r436484665 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -2457,8 +2463,13 @@ public FlushResultImpl flushcache(boolea

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-640401063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436483372 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -1105,23 +1097,7 @@ public void run(PRESP resp) {

[jira] [Updated] (HBASE-24459) Move the locateMeta logic from AsyncMetaRegionTableLocator to ConnectionRegistry

2020-06-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24459: -- Summary: Move the locateMeta logic from AsyncMetaRegionTableLocator to ConnectionRegistry (was: Make

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436482090 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistry.java ## @@ -31,11 +30,6 @@ @InterfaceAudience.Private interfac

[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-07 Thread GitBox
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-640396023 @saintstack IMO, the flushing caused by logRoller is different with other cases, it is related to data consistent, should not be specified by user. In fact, for now we wil

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436477988 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java ## @@ -44,25 +51,51 @@ @InterfaceAudience.Private class A

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436477476 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncMetaTableRegionLocator.java ## @@ -0,0 +1,152 @@ +/** + * Licensed to the Apac

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436475983 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/AsyncMetaTableAccessor.java ## @@ -170,26 +170,27 @@ /** * Used to get all region

[jira] [Commented] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-07 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127918#comment-17127918 ] Guanghao Zhang commented on HBASE-24359: {quote}If there is some new configs bee

[jira] [Updated] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-07 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24359: --- Release Note: Introduce a new config hbase.replication.drop.on.deleted.columnfamily, default

[jira] [Commented] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-07 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127913#comment-17127913 ] Anoop Sam John commented on HBASE-24359: If there is some new configs been intro

[GitHub] [hbase] Apache-HBase commented on pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1782: URL: https://github.com/apache/hbase/pull/1782#issuecomment-640380861 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-640380291 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1782: URL: https://github.com/apache/hbase/pull/1782#issuecomment-640378598 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38

[jira] [Updated] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-07 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24359: --- Fix Version/s: 2.3.0 > Optionally ignore edits for deleted CFs for replication. > --

[jira] [Updated] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-07 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24359: --- Priority: Major (was: Minor) > Optionally ignore edits for deleted CFs for replication. > -

[jira] [Resolved] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-07 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24359. Resolution: Fixed Pushed to branch-2.3+. Thanks [~Ddupg] for contributing. > Optionally i

[GitHub] [hbase] infraio merged pull request #1855: HBASE-24359 Optionally ignore edits for deleted CFs for replication

2020-06-07 Thread GitBox
infraio merged pull request #1855: URL: https://github.com/apache/hbase/pull/1855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] saintstack commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-07 Thread GitBox
saintstack commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r436450913 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/FlushPolicy.java ## @@ -46,4 +49,16 @@ protected void configureForRegion(H

[jira] [Commented] (HBASE-24382) Flush partial stores of region filtered by seqId when archive wal due to too many wals

2020-06-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127865#comment-17127865 ] Michael Stack commented on HBASE-24382: --- >From PR, on why this feature: "It is fro

[jira] [Assigned] (HBASE-24444) Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster

2020-06-07 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 reassigned HBASE-2: --- Assignee: (was: wenfeiyi666) > Should shutdown mini cluster after class in TestMetaAssi

[GitHub] [hbase] saintstack commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
saintstack commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r436432869 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/AsyncMetaTableAccessor.java ## @@ -170,26 +170,27 @@ /** * Used to get all reg

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-640346997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache-HBase commented on pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1782: URL: https://github.com/apache/hbase/pull/1782#issuecomment-640339671 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 46

[jira] [Commented] (HBASE-24513) The default readRpcTimeout and writeRpcTimeout is incorrectly calculated in AsyncConnectionConfiguration

2020-06-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127841#comment-17127841 ] Hudson commented on HBASE-24513: Results for branch branch-2 [build #2695 on bu

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-06-07 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127837#comment-17127837 ] Bharath Vissapragada commented on HBASE-23887: -- Firstly, thanks for doing t

[jira] [Resolved] (HBASE-24515) batch Increment/Append fails when retrying the RPC

2020-06-07 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki resolved HBASE-24515. -- Hadoop Flags: Reviewed Resolution: Fixed > batch Increment/Append fails when ret

[jira] [Updated] (HBASE-24515) batch Increment/Append fails when retrying the RPC

2020-06-07 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24515: - Fix Version/s: 2.2.6 2.1.10 2.4.0

[jira] [Commented] (HBASE-24515) batch Increment/Append fails when retrying the RPC

2020-06-07 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127835#comment-17127835 ] Toshihiro Suzuki commented on HBASE-24515: -- Pushed to master, branch-2, branch-

[jira] [Resolved] (HBASE-24506) async client deadlock

2020-06-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24506. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.2+. Thanks all for reviewing. Th

[GitHub] [hbase] bharathv commented on a change in pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-07 Thread GitBox
bharathv commented on a change in pull request #1257: URL: https://github.com/apache/hbase/pull/1257#discussion_r436423732 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java ## @@ -153,6 +153,18 @@ private static final String LRU_MA

[GitHub] [hbase] zhaoyim commented on pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2020-06-07 Thread GitBox
zhaoyim commented on pull request #746: URL: https://github.com/apache/hbase/pull/746#issuecomment-640320816 @saintstack Sorry! I missed this issue. Sure! I will go through the commit then do the update based on Dou's comments This week. Thanks for reminder! -

[GitHub] [hbase] Apache9 merged pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache9 merged pull request #1858: URL: https://github.com/apache/hbase/pull/1858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] brfrn169 merged pull request #1864: HBASE-24515 batch Increment/Append fails when retrying the RPC

2020-06-07 Thread GitBox
brfrn169 merged pull request #1864: URL: https://github.com/apache/hbase/pull/1864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-06-07 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127809#comment-17127809 ] Bharath Vissapragada commented on HBASE-23887: -- [~pustota] Thanks for all t

[GitHub] [hbase] bharathv commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
bharathv commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436409895 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -253,52 +268,38 @@ public void operationComplete(Future

[jira] [Commented] (HBASE-24513) The default readRpcTimeout and writeRpcTimeout is incorrectly calculated in AsyncConnectionConfiguration

2020-06-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127806#comment-17127806 ] Hudson commented on HBASE-24513: Results for branch branch-2.2 [build #887 on b

[GitHub] [hbase] Apache-HBase commented on pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1858: URL: https://github.com/apache/hbase/pull/1858#issuecomment-640252687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1858: URL: https://github.com/apache/hbase/pull/1858#issuecomment-640252043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 52

[GitHub] [hbase] Apache-HBase commented on pull request #1864: HBASE-24515 batch Increment/Append fails when retrying the RPC

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1864: URL: https://github.com/apache/hbase/pull/1864#issuecomment-640251667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16

[GitHub] [hbase] Apache-HBase commented on pull request #1864: HBASE-24515 batch Increment/Append fails when retrying the RPC

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1864: URL: https://github.com/apache/hbase/pull/1864#issuecomment-640249956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[jira] [Commented] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in old

2020-06-07 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127707#comment-17127707 ] Anoop Sam John commented on HBASE-23340: Can u attach the patch? > hmaster /hb

[GitHub] [hbase] Apache-HBase commented on pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1822: URL: https://github.com/apache/hbase/pull/1822#issuecomment-640236123 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22

[GitHub] [hbase] Apache-HBase commented on pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1822: URL: https://github.com/apache/hbase/pull/1822#issuecomment-640236026 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] Apache-HBase commented on pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1822: URL: https://github.com/apache/hbase/pull/1822#issuecomment-640235619 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] Apache-HBase commented on pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1858: URL: https://github.com/apache/hbase/pull/1858#issuecomment-640235516 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache9 commented on pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache9 commented on pull request #1858: URL: https://github.com/apache/hbase/pull/1858#issuecomment-640232998 Set up a 5 nodes cluster with the latest branch-2.2 code. Run `./bin/hbase pe --nomapred --presplit=5 randomWrite 10` To generated test data. Run `./bin/hbase

[GitHub] [hbase] bsglz commented on a change in pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-07 Thread GitBox
bsglz commented on a change in pull request #1822: URL: https://github.com/apache/hbase/pull/1822#discussion_r436371430 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java ## @@ -40,15 +42,18 @@ */ @InterfaceAudience.Publi

[GitHub] [hbase] bsglz commented on a change in pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-07 Thread GitBox
bsglz commented on a change in pull request #1822: URL: https://github.com/apache/hbase/pull/1822#discussion_r436371430 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java ## @@ -40,15 +42,18 @@ */ @InterfaceAudience.Publi

[GitHub] [hbase] Apache9 commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436370826 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -73,40 +79,77 @@ private static final Logger LOG = L

[GitHub] [hbase] Apache9 commented on pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache9 commented on pull request #1858: URL: https://github.com/apache/hbase/pull/1858#issuecomment-640229473 > Can we make sure we have a test that asserts are enabled that will also run when we run whatever tests we expect to exercise this code path to catch an assert failure should som

[GitHub] [hbase] virajjasani commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-07 Thread GitBox
virajjasani commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-640225612 @gkanade Can you please check test failure locally? I am not getting NPE on master branch. However, last couple of builds have consistent failures: ``` java.lang.NullPoin

[jira] [Commented] (HBASE-24496) The tab of Base Stats not actived by default in table.jsp

2020-06-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127664#comment-17127664 ] Hudson commented on HBASE-24496: Results for branch master [build #1750 on buil

[jira] [Commented] (HBASE-24510) Remove HBaseTestCase and GenericTestUtils

2020-06-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127663#comment-17127663 ] Hudson commented on HBASE-24510: Results for branch master [build #1750 on buil

[GitHub] [hbase] virajjasani commented on a change in pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-07 Thread GitBox
virajjasani commented on a change in pull request #1822: URL: https://github.com/apache/hbase/pull/1822#discussion_r436367455 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java ## @@ -40,15 +42,18 @@ */ @InterfaceAudience

[GitHub] [hbase] Apache-HBase commented on pull request #1864: HBASE-24515 batch Increment/Append fails when retrying the RPC

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1864: URL: https://github.com/apache/hbase/pull/1864#issuecomment-640224707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-640217506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-640216113 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s

[GitHub] [hbase] brfrn169 commented on a change in pull request #1864: HBASE-24515 batch Increment/Append fails when retrying the RPC

2020-06-07 Thread GitBox
brfrn169 commented on a change in pull request #1864: URL: https://github.com/apache/hbase/pull/1864#discussion_r436359832 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -794,6 +792,29 @@ private Result increment(final HR

[jira] [Resolved] (HBASE-24513) The default readRpcTimeout and writeRpcTimeout is incorrectly calculated in AsyncConnectionConfiguration

2020-06-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24513. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.2+. Thanks [~janh] for reviewing.

[GitHub] [hbase] Apache9 merged pull request #1863: HBASE-24513 The default readRpcTimeout and writeRpcTimeout is incorre…

2020-06-07 Thread GitBox
Apache9 merged pull request #1863: URL: https://github.com/apache/hbase/pull/1863 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache9 commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache9 commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436346597 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -253,52 +268,38 @@ public void operationComplete(Future

[GitHub] [hbase] Apache9 commented on pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
Apache9 commented on pull request #1858: URL: https://github.com/apache/hbase/pull/1858#issuecomment-640189751 > Can we make sure we have a test that asserts are enabled that will also run when we run whatever tests we expect to exercise this code path to catch an assert failure should som

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-640185668 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32

[jira] [Comment Edited] (HBASE-24446) Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127558#comment-17127558 ] Viraj Jasani edited comment on HBASE-24446 at 6/7/20, 9:30 AM: ---

[jira] [Commented] (HBASE-24446) Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127558#comment-17127558 ] Viraj Jasani commented on HBASE-24446: -- I have reverted the applied commit from bra

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-06-07 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127551#comment-17127551 ] Danil Lipovoy commented on HBASE-23887: --- Another one test - I wanted to see how to

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-640181582 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-06-07 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: image-2020-06-07-12-07-30-307.png > BlockCache performance improve by reduce evict

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-06-07 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: image-2020-06-07-12-07-24-903.png > BlockCache performance improve by reduce evict

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-06-07 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: wave.png > BlockCache performance improve by reduce eviction rate > --

[GitHub] [hbase] virajjasani commented on a change in pull request #1864: HBASE-24515 batch Increment/Append fails when retrying the RPC

2020-06-07 Thread GitBox
virajjasani commented on a change in pull request #1864: URL: https://github.com/apache/hbase/pull/1864#discussion_r436339955 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -794,6 +792,29 @@ private Result increment(final

[GitHub] [hbase] virajjasani commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
virajjasani commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436337656 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -253,52 +268,38 @@ public void operationComplete(Fut

[GitHub] [hbase] virajjasani commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
virajjasani commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436337656 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -253,52 +268,38 @@ public void operationComplete(Fut

[GitHub] [hbase] virajjasani commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-07 Thread GitBox
virajjasani commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436336655 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -153,35 +200,30 @@ private void scheduleRelogin(Thro

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-07 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-640175173 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30