[GitHub] [hbase] ramkrish86 commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-22 Thread GitBox
ramkrish86 commented on a change in pull request #2021: URL: https://github.com/apache/hbase/pull/2021#discussion_r459224188 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -58,31 +58,31 @@ protected static final String

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-22 Thread GitBox
ramkrish86 commented on a change in pull request #2021: URL: https://github.com/apache/hbase/pull/2021#discussion_r459223780 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -58,31 +58,31 @@ protected static final String

[GitHub] [hbase] gkanade opened a new pull request #2125: null check for writer if not initialized yet during syncrunner run

2020-07-22 Thread GitBox
gkanade opened a new pull request #2125: URL: https://github.com/apache/hbase/pull/2125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2124: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2124: URL: https://github.com/apache/hbase/pull/2124#issuecomment-662818684 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662816300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-22 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163212#comment-17163212 ] wenfeiyi666 commented on HBASE-24665: - [~zhangduo] and [~zghao], please review, thanks. > all wal

[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-662813745 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24526) Deadlock executing assign meta procedure

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163209#comment-17163209 ] Michael Stack commented on HBASE-24526: --- Update: I've put aside trying to find the issue we saw on

[GitHub] [hbase] Apache-HBase commented on pull request #2122: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2122: URL: https://github.com/apache/hbase/pull/2122#issuecomment-662811987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2123: HBASE-24738 [Shell] processlist command fails with ERROR: Unexpected end of file from server when SSL enabled

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2123: URL: https://github.com/apache/hbase/pull/2123#issuecomment-662811329 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2123: HBASE-24738 [Shell] processlist command fails with ERROR: Unexpected end of file from server when SSL enabled

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2123: URL: https://github.com/apache/hbase/pull/2123#issuecomment-662808030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2123: HBASE-24738 [Shell] processlist command fails with ERROR: Unexpected end of file from server when SSL enabled

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2123: URL: https://github.com/apache/hbase/pull/2123#issuecomment-662811010 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-24632) Enable procedure-based log splitting as default in hbase3

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163200#comment-17163200 ] Michael Stack edited comment on HBASE-24632 at 7/23/20, 4:00 AM: - I was

[jira] [Commented] (HBASE-24632) Enable procedure-based log splitting as default in hbase3

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163200#comment-17163200 ] Michael Stack commented on HBASE-24632: --- I was going to push this as default in hbase-2.4 and on

[GitHub] [hbase] infraio opened a new pull request #2124: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-22 Thread GitBox
infraio opened a new pull request #2124: URL: https://github.com/apache/hbase/pull/2124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] infraio commented on pull request #2124: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-22 Thread GitBox
infraio commented on pull request #2124: URL: https://github.com/apache/hbase/pull/2124#issuecomment-662809521 PR for branch-2. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] pankaj72981 commented on pull request #2123: HBASE-24738 [Shell] processlist command fails with ERROR: Unexpected end of file from server when SSL enabled

2020-07-22 Thread GitBox
pankaj72981 commented on pull request #2123: URL: https://github.com/apache/hbase/pull/2123#issuecomment-662807014 @bitoffdev please review. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] taklwu commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
taklwu commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662806848 thanks @Apache9 we can switch to use standard `SCP` instead, for this case running `SCP` should be the same. The only difference is `HBCKSCP` may rescan the meta table (slower)

[GitHub] [hbase] pankaj72981 opened a new pull request #2123: HBASE-24738 [Shell] processlist command fails with ERROR: Unexpected end of file from server when SSL enabled

2020-07-22 Thread GitBox
pankaj72981 opened a new pull request #2123: URL: https://github.com/apache/hbase/pull/2123 Uncommented the code to handle the SSL scenario. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] infraio opened a new pull request #2122: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-22 Thread GitBox
infraio opened a new pull request #2122: URL: https://github.com/apache/hbase/pull/2122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23634: -- Fix Version/s: (was: 2.4.0) > Enable "Split WAL to HFile" by default >

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163177#comment-17163177 ] Michael Stack commented on HBASE-23634: ---   {quote}1、before compaction, large number of small

[GitHub] [hbase] Apache-HBase commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662791330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
Apache9 commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662787462 I haven't looked at the patch yet, but what I want to say is that, it is not a good idea to use HBCK stuff in automatic fail recovery. The design of HBCK is that, the operation

[GitHub] [hbase] Apache-HBase commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662784028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163163#comment-17163163 ] Michael Stack commented on HBASE-24749: --- {quote}and if any HFile is being written successfully

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163154#comment-17163154 ] Duo Zhang commented on HBASE-11288: --- I have to explain a bit here so people will not misunderstand me.

[GitHub] [hbase] Apache-HBase commented on pull request #2121: Backport "HBASE-24295 [Chaos Monkey] abstract logging through the class hierarchy" and addendum to branch-1

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2121: URL: https://github.com/apache/hbase/pull/2121#issuecomment-662768059 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662762955 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on pull request #2121: Backport "HBASE-24295 [Chaos Monkey] abstract logging through the class hierarchy" and addendum to branch-1

2020-07-22 Thread GitBox
ndimiduk commented on pull request #2121: URL: https://github.com/apache/hbase/pull/2121#issuecomment-662755944 The backport of HBASE-24295 as discussed on HBASE-24662. This is an automated message from the Apache Git

[GitHub] [hbase] ndimiduk opened a new pull request #2121: Backport "HBASE-24295 [Chaos Monkey] abstract logging through the class hierarchy" and addendum to branch-1

2020-07-22 Thread GitBox
ndimiduk opened a new pull request #2121: URL: https://github.com/apache/hbase/pull/2121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Reopened] (HBASE-24295) [Chaos Monkey] abstract logging through the class hierarchy

2020-07-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24295: -- Reopen for branch-1 backport. > [Chaos Monkey] abstract logging through the class hierarchy >

[GitHub] [hbase] Apache-HBase commented on pull request #2119: Backport "HBASE-24696 Include JVM information on Web UI under "Software Attributes"" to branch-2.2

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2119: URL: https://github.com/apache/hbase/pull/2119#issuecomment-662751827 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-22 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163136#comment-17163136 ] Tak-Lon (Stephen) Wu commented on HBASE-24749: -- Thanks Stack, HBASE-14090 and their [design

[jira] [Commented] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-22 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163124#comment-17163124 ] Mingliang Liu commented on HBASE-24692: --- [~ndimiduk] Feel free to re-assign if you have a plan.

[jira] [Commented] (HBASE-24734) Wrong comparator opening Region when 'split-to-WAL' enabled.

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163123#comment-17163123 ] Michael Stack commented on HBASE-24734: --- This is a super rare bug. Happens in the verify of the

[jira] [Commented] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163121#comment-17163121 ] Hudson commented on HBASE-22146: Results for branch branch-2.2 [build #917 on

[jira] [Commented] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163119#comment-17163119 ] Nick Dimiduk commented on HBASE-24692: -- I looked over this with a JS/CSS programmer friend. First

[GitHub] [hbase] taklwu commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
taklwu commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662730825 while waiting for the unit tests runs, I want to bring up two extra topics and may follow on new JIRA(s) 1. We reverted a

[GitHub] [hbase] Apache-HBase commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662729548 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] taklwu commented on a change in pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
taklwu commented on a change in pull request #2113: URL: https://github.com/apache/hbase/pull/2113#discussion_r459100872 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRecreateCluster.java ## @@ -0,0 +1,185 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] taklwu commented on a change in pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
taklwu commented on a change in pull request #2113: URL: https://github.com/apache/hbase/pull/2113#discussion_r459100536 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRecreateCluster.java ## @@ -0,0 +1,185 @@ +/** Review comment: fixed,

[jira] [Assigned] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-22 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York reassigned HBASE-24749: - Assignee: Tak-Lon (Stephen) Wu > Direct insert HFiles and Persist in-memory HFile tracking >

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-22 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163074#comment-17163074 ] Zach York commented on HBASE-24749: --- Hmm, perhaps a flush of the root table could include the

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163069#comment-17163069 ] Michael Stack commented on HBASE-24749: --- On where to write ROOT hfile list, when no zk, I suppose

[jira] [Commented] (HBASE-21721) reduce write#syncs() times

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163054#comment-17163054 ] Michael Stack commented on HBASE-21721: --- {quote}As I read this change, if a difference between

[jira] [Commented] (HBASE-21721) reduce write#syncs() times

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163041#comment-17163041 ] Michael Stack commented on HBASE-21721: ---     As I read this change, if a difference between

[jira] [Commented] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163036#comment-17163036 ] Nick Dimiduk commented on HBASE-24696: -- 2.2 and 2.1 backport PRs are up and waiting on precommit

[GitHub] [hbase] ndimiduk commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch

2020-07-22 Thread GitBox
ndimiduk commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r459047138 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java ## @@ -85,6 +90,12 @@ public void sync(boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2118: HBASE-24758 Avoid flooding replication source RSes logs when no sinks…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2118: URL: https://github.com/apache/hbase/pull/2118#issuecomment-662653363 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk opened a new pull request #2120: Backport "HBASE-24696 Include JVM information on Web UI under "Software Attributes"" to branch-2.1

2020-07-22 Thread GitBox
ndimiduk opened a new pull request #2120: URL: https://github.com/apache/hbase/pull/2120 Signed-off-by: Viraj Jasani Signed-off-by: Nick Dimiduk This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #2118: HBASE-24758 Avoid flooding replication source RSes logs when no sinks…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2118: URL: https://github.com/apache/hbase/pull/2118#issuecomment-662634420 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk opened a new pull request #2119: Backport "HBASE-24696 Include JVM information on Web UI under "Software Attributes"" to branch-2.2

2020-07-22 Thread GitBox
ndimiduk opened a new pull request #2119: URL: https://github.com/apache/hbase/pull/2119 Signed-off-by: Viraj Jasani Signed-off-by: Nick Dimiduk This is an automated message from the Apache Git Service. To respond to

[jira] [Reopened] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24696: -- Oops. We missed 2.2.x. Reopening. > Include JVM information on Web UI under "Software

[jira] [Commented] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163016#comment-17163016 ] Nick Dimiduk commented on HBASE-24696: -- [~liuml07], [~vjasani] thank you both! > Include JVM

[GitHub] [hbase] taklwu edited a comment on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
taklwu edited a comment on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662590771 Thanks Josh, and honestly I didn't know the logic till now. And here is the finding for both situations you're concerning: first case 1. hbase:meta has

[GitHub] [hbase] joshelser commented on a change in pull request #2094: HBASE-24680 Refactor the checkAndMutate code on the server side

2020-07-22 Thread GitBox
joshelser commented on a change in pull request #2094: URL: https://github.com/apache/hbase/pull/2094#discussion_r458952500 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java ## @@ -759,12 +810,150 @@ default boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2055: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length(addendum)

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2055: URL: https://github.com/apache/hbase/pull/2055#issuecomment-662606021 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] taklwu edited a comment on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
taklwu edited a comment on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662590771 Thanks Josh, and honestly I didn't know the logic till now. And here is the finding for both sitation you're concerning: first case 1. hbase:meta has

[GitHub] [hbase] taklwu edited a comment on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
taklwu edited a comment on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662590771 Thanks Josh, and honestly I didn't know the logic till now. And here is the finding for both sitation you're concerning: first case 1. hbase:meta has

[GitHub] [hbase] liuml07 commented on pull request #2117: HBASE-24696 Include JVM information on Web UI under "Software Attributes"

2020-07-22 Thread GitBox
liuml07 commented on pull request #2117: URL: https://github.com/apache/hbase/pull/2117#issuecomment-662591070 Thank you @virajjasani ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] taklwu commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-22 Thread GitBox
taklwu commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662590771 Thanks Josh, and honestly I didn't know the logic till now. And here is the finding: > 1. hbase:meta has assigned regions to a set of RegionServers rs1 2. All

[GitHub] [hbase] Apache-HBase commented on pull request #2055: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length(addendum)

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2055: URL: https://github.com/apache/hbase/pull/2055#issuecomment-662569286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162937#comment-17162937 ] Michael Stack commented on HBASE-11288: --- {quote}I seem to have made a mistake and thought that

[jira] [Comment Edited] (HBASE-24757) ReplicationSink should limit the batch size for batch mutations based on hbase.rpc.rows.warning.threshold

2020-07-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162919#comment-17162919 ] Viraj Jasani edited comment on HBASE-24757 at 7/22/20, 4:30 PM:

[GitHub] [hbase] virajjasani commented on a change in pull request #2118: HBASE-24758 Avoid flooding replication source RSes logs when no sinks…

2020-07-22 Thread GitBox
virajjasani commented on a change in pull request #2118: URL: https://github.com/apache/hbase/pull/2118#discussion_r458921944 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java ## @@ -127,6

[GitHub] [hbase] virajjasani commented on a change in pull request #2118: HBASE-24758 Avoid flooding replication source RSes logs when no sinks…

2020-07-22 Thread GitBox
virajjasani commented on a change in pull request #2118: URL: https://github.com/apache/hbase/pull/2118#discussion_r458920644 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkManager.java ## @@ -150,9 +151,14 @@ public

[GitHub] [hbase] joshelser commented on a change in pull request #2118: HBASE-24758 Avoid flooding replication source RSes logs when no sinks…

2020-07-22 Thread GitBox
joshelser commented on a change in pull request #2118: URL: https://github.com/apache/hbase/pull/2118#discussion_r458916606 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java ## @@ -127,6 +127,7

[jira] [Commented] (HBASE-24757) ReplicationSink should limit the batch size for batch mutations based on hbase.rpc.rows.warning.threshold

2020-07-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162919#comment-17162919 ] Viraj Jasani commented on HBASE-24757: -- HBASE-18027 is about limiting size limit for replication

[GitHub] [hbase] Apache-HBase commented on pull request #2118: HBASE-24758 Avoid flooding replication source RSes logs when no sinks…

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2118: URL: https://github.com/apache/hbase/pull/2118#issuecomment-662540504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24757) ReplicationSink should limit the batch size for batch mutations based on hbase.rpc.rows.warning.threshold

2020-07-22 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162908#comment-17162908 ] Wellington Chevreuil commented on HBASE-24757: -- Wasn't this supposedly addressed by

[GitHub] [hbase] wchevreuil opened a new pull request #2118: HBASE-24758 Avoid flooding replication source RSes logs when no sinks…

2020-07-22 Thread GitBox
wchevreuil opened a new pull request #2118: URL: https://github.com/apache/hbase/pull/2118 … are available This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (HBASE-24758) Avoid flooding replication source RSes logs when no sinks are available

2020-07-22 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-24758: Summary: Avoid flooding replication source RSes logs when no sinks are available Key: HBASE-24758 URL: https://issues.apache.org/jira/browse/HBASE-24758

[jira] [Assigned] (HBASE-24757) ReplicationSink should limit the batch size for batch mutations based on hbase.rpc.rows.warning.threshold

2020-07-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24757: Assignee: Viraj Jasani > ReplicationSink should limit the batch size for batch mutations

[jira] [Created] (HBASE-24757) ReplicationSink should limit the batch size for batch mutations based on hbase.rpc.rows.warning.threshold

2020-07-22 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-24757: Summary: ReplicationSink should limit the batch size for batch mutations based on hbase.rpc.rows.warning.threshold Key: HBASE-24757 URL:

[GitHub] [hbase] Apache-HBase commented on pull request #2055: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length(addendum)

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2055: URL: https://github.com/apache/hbase/pull/2055#issuecomment-662502589 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2055: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length(addendum)

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2055: URL: https://github.com/apache/hbase/pull/2055#issuecomment-662479415 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2055: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length(addendum)

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2055: URL: https://github.com/apache/hbase/pull/2055#issuecomment-662475702 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24662) Update DumpClusterStatusAction to notice changes in region server count

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162824#comment-17162824 ] Hudson commented on HBASE-24662: Results for branch master [build #1791 on

[jira] [Commented] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162825#comment-17162825 ] Hudson commented on HBASE-22146: Results for branch master [build #1791 on

[jira] [Commented] (HBASE-24555) Clear the description of hbase.hregion.max.filesize

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162820#comment-17162820 ] Hudson commented on HBASE-24555: Results for branch master [build #1791 on

[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162823#comment-17162823 ] Hudson commented on HBASE-24718: Results for branch master [build #1791 on

[jira] [Commented] (HBASE-24743) Reject to add a peer which replicate to itself earlier

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162822#comment-17162822 ] Hudson commented on HBASE-24743: Results for branch master [build #1791 on

[jira] [Commented] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162821#comment-17162821 ] Hudson commented on HBASE-24696: Results for branch master [build #1791 on

[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162803#comment-17162803 ] Hudson commented on HBASE-24718: Results for branch branch-2 [build #2756 on

[jira] [Commented] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162802#comment-17162802 ] Hudson commented on HBASE-22146: Results for branch branch-2 [build #2756 on

[jira] [Commented] (HBASE-24662) Update DumpClusterStatusAction to notice changes in region server count

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162801#comment-17162801 ] Hudson commented on HBASE-24662: Results for branch branch-2 [build #2756 on

[jira] [Commented] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162793#comment-17162793 ] Hudson commented on HBASE-24696: Results for branch branch-2.3 [build #189 on

[jira] [Commented] (HBASE-24662) Update DumpClusterStatusAction to notice changes in region server count

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162794#comment-17162794 ] Hudson commented on HBASE-24662: Results for branch branch-2.3 [build #189 on

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162795#comment-17162795 ] Hudson commented on HBASE-24742: Results for branch branch-2.3 [build #189 on

[jira] [Commented] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162796#comment-17162796 ] Hudson commented on HBASE-22146: Results for branch branch-2.3 [build #189 on

[jira] [Commented] (HBASE-24710) Incorrect checksum calculation in saveVersion.sh

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162792#comment-17162792 ] Hudson commented on HBASE-24710: Results for branch branch-2.3 [build #189 on

[jira] [Commented] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2020-07-22 Thread mokai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162775#comment-17162775 ] mokai commented on HBASE-24755: --- [~pankajkumar]  Error message can be enhanced "Server is not an online

[jira] [Updated] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2020-07-22 Thread mokai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mokai updated HBASE-24755: -- Issue Type: Bug (was: Improvement) > [LOG][RSGroup]Error message is confusing while adding a offline RS to

[GitHub] [hbase] Apache-HBase commented on pull request #2038: HBASE-24687 MobFileCleanerChore uses a new Connection for each table …

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2038: URL: https://github.com/apache/hbase/pull/2038#issuecomment-662422210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2038: HBASE-24687 MobFileCleanerChore uses a new Connection for each table …

2020-07-22 Thread GitBox
Apache-HBase commented on pull request #2038: URL: https://github.com/apache/hbase/pull/2038#issuecomment-662419194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-24756) Backport HBASE-24336 to branch-2.2

2020-07-22 Thread Pankaj Kumar (Jira)
Pankaj Kumar created HBASE-24756: Summary: Backport HBASE-24336 to branch-2.2 Key: HBASE-24756 URL: https://issues.apache.org/jira/browse/HBASE-24756 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2020-07-22 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162733#comment-17162733 ] Pankaj Kumar commented on HBASE-24755: -- {quote}Move a offine RS from default RSGroup to another

[jira] [Created] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2020-07-22 Thread mokai (Jira)
mokai created HBASE-24755: - Summary: [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup Key: HBASE-24755 URL: https://issues.apache.org/jira/browse/HBASE-24755 Project: HBase

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-22 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-662385535 @Apache9 Ping. This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   >