[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-743965688 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-743963740 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] Apache-HBase commented on pull request #2766: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2766: URL: https://github.com/apache/hbase/pull/2766#issuecomment-743960733 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44

[GitHub] [hbase] Apache-HBase commented on pull request #2766: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2766: URL: https://github.com/apache/hbase/pull/2766#issuecomment-743960664 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s

[GitHub] [hbase] shahrs87 commented on a change in pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

shahrs87 commented on a change in pull request #2745: URL: https://github.com/apache/hbase/pull/2745#discussion_r541849196 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java ## @@ -479,4 +488,59 @@ public void testRegionLockI

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-743950848 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51

[GitHub] [hbase] Apache-HBase commented on pull request #2766: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2766: URL: https://github.com/apache/hbase/pull/2766#issuecomment-743948185 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13

[GitHub] [hbase] Apache-HBase commented on pull request #2774: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

Apache-HBase commented on pull request #2774: URL: https://github.com/apache/hbase/pull/2774#issuecomment-743945099 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s

[GitHub] [hbase] Apache-HBase commented on pull request #2774: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

Apache-HBase commented on pull request #2774: URL: https://github.com/apache/hbase/pull/2774#issuecomment-743945033 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37

[GitHub] [hbase] Apache-HBase commented on pull request #2767: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2767: URL: https://github.com/apache/hbase/pull/2767#issuecomment-743943915 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 14m 34s

[jira] [Commented] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in old

[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248504#comment-17248504 ] Bo Cui commented on HBASE-23340: [~zhangduo][~vjasani] thanks for review [~zhangduo] i

[GitHub] [hbase] cuibo01 opened a new pull request #2774: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

cuibo01 opened a new pull request #2774: URL: https://github.com/apache/hbase/pull/2774 …ication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in oldWALs too large (more than 2TB) -

[GitHub] [hbase] Apache-HBase commented on pull request #2766: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2766: URL: https://github.com/apache/hbase/pull/2766#issuecomment-743941793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 26

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

anoopsjohn commented on a change in pull request #2745: URL: https://github.com/apache/hbase/pull/2745#discussion_r541831201 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java ## @@ -479,4 +488,59 @@ public void testRegionLoc

[GitHub] [hbase] Apache-HBase commented on pull request #2773: Hbase 25389

Apache-HBase commented on pull request #2773: URL: https://github.com/apache/hbase/pull/2773#issuecomment-743939925 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 7

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-743938169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[jira] [Commented] (HBASE-25334) TestRSGroupsFallback.testFallback is flaky

[ https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248497#comment-17248497 ] Xiaolin Ha commented on HBASE-25334: I looked through the branch-2 and branch-2.4 fa

[jira] [Updated] (HBASE-25334) TestRSGroupsFallback.testFallback is flaky

[ https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25334: --- Attachment: image-2020-12-13-10-15-55-445.png > TestRSGroupsFallback.testFallback is flaky > ---

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-743935924 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 43

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-743932749 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s

[GitHub] [hbase] GeorryHuang commented on pull request #2772: HBASE-25387 TagRewriteCell's getSerializedSize() method gets the size…

GeorryHuang commented on pull request #2772: URL: https://github.com/apache/hbase/pull/2772#issuecomment-743932179 Did we implement any reading back logic to detect there are tags on a cell? Currently every reading back logic relies on SerializedSize of Cell and the SerializedSize never in

[GitHub] [hbase] GeorryHuang commented on pull request #2772: HBASE-25387 TagRewriteCell's getSerializedSize() method gets the size…

GeorryHuang commented on pull request #2772: URL: https://github.com/apache/hbase/pull/2772#issuecomment-743931808 When tag length == 0, the contents of TagRewriteCell written to stream and ByteBuffer are inconsistent，which ByteBuffer missing one tag length. -

[GitHub] [hbase] Apache-HBase commented on pull request #2773: Hbase 25389

Apache-HBase commented on pull request #2773: URL: https://github.com/apache/hbase/pull/2773#issuecomment-743931773 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[GitHub] [hbase] GeorryHuang commented on pull request #2772: HBASE-25387 TagRewriteCell's getSerializedSize() method gets the size…

GeorryHuang commented on pull request #2772: URL: https://github.com/apache/hbase/pull/2772#issuecomment-743931670 > This needs a thorough check. When we write to Hfile stream, if the top level says write tags as true, we have to write the tags length even if it is 0. In a stream we might

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-743925336 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-743923008 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 45

[GitHub] [hbase] Apache-HBase commented on pull request #2766: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2766: URL: https://github.com/apache/hbase/pull/2766#issuecomment-743921155 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35

[GitHub] [hbase] Apache-HBase commented on pull request #2773: Hbase 25389

Apache-HBase commented on pull request #2773: URL: https://github.com/apache/hbase/pull/2773#issuecomment-743920569 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14

[GitHub] [hbase] Apache-HBase commented on pull request #2773: Hbase 25389

Apache-HBase commented on pull request #2773: URL: https://github.com/apache/hbase/pull/2773#issuecomment-743916237 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59

[jira] [Assigned] (HBASE-25390) CopyTable and Coprocessor based export tool should backup and restore cell tags.

[ https://issues.apache.org/jira/browse/HBASE-25390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah reassigned HBASE-25390: Assignee: Rushabh Shah > CopyTable and Coprocessor based export tool should backup and re

[jira] [Commented] (HBASE-25390) CopyTable and Coprocessor based export tool should backup and restore cell tags.

[ https://issues.apache.org/jira/browse/HBASE-25390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248478#comment-17248478 ] Rushabh Shah commented on HBASE-25390: -- Cc [~anoop.hbase] who gave the idea of open

[jira] [Created] (HBASE-25390) CopyTable and Coprocessor based export tool should backup and restore cell tags.

Rushabh Shah created HBASE-25390: Summary: CopyTable and Coprocessor based export tool should backup and restore cell tags. Key: HBASE-25390 URL: https://issues.apache.org/jira/browse/HBASE-25390 Proj

[jira] [Comment Edited] (HBASE-25334) TestRSGroupsFallback.testFallback is flaky

[ https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248477#comment-17248477 ] Michael Stack edited comment on HBASE-25334 at 12/12/20, 10:21 PM: ---

[jira] [Commented] (HBASE-25334) TestRSGroupsFallback.testFallback is flaky

[ https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248477#comment-17248477 ] Michael Stack commented on HBASE-25334: --- Any chance of a version for banch-2 [~Xia

[GitHub] [hbase] Apache-HBase commented on pull request #2773: Hbase 25389

Apache-HBase commented on pull request #2773: URL: https://github.com/apache/hbase/pull/2773#issuecomment-743911658 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #2773: Hbase 25389

Apache-HBase commented on pull request #2773: URL: https://github.com/apache/hbase/pull/2773#issuecomment-743911644 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] shahrs87 commented on a change in pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

shahrs87 commented on a change in pull request #2745: URL: https://github.com/apache/hbase/pull/2745#discussion_r541789215 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java ## @@ -479,4 +488,59 @@ public void testRegionLockI

[GitHub] [hbase] saintstack opened a new pull request #2773: Hbase 25389

saintstack opened a new pull request #2773: URL: https://github.com/apache/hbase/pull/2773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-743910332 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47

[jira] [Commented] (HBASE-25389) [Flakey Tests] branch-2 TestMetaShutdownHandler

[ https://issues.apache.org/jira/browse/HBASE-25389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248472#comment-17248472 ] Michael Stack commented on HBASE-25389: --- Linking to an old HBASE-19940 that was re

[jira] [Created] (HBASE-25389) [Flakey Tests] branch-2 TestMetaShutdownHandler

Michael Stack created HBASE-25389: - Summary: [Flakey Tests] branch-2 TestMetaShutdownHandler Key: HBASE-25389 URL: https://issues.apache.org/jira/browse/HBASE-25389 Project: HBase Issue Type:

[jira] [Commented] (HBASE-25386) Move hbase-downstreamer under hbase-connectors

[ https://issues.apache.org/jira/browse/HBASE-25386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248469#comment-17248469 ] Michael Stack commented on HBASE-25386: --- bq. personally I think its own repo would

[jira] [Updated] (HBASE-25388) Replacing Producer implementation with an extension of MockProducer on testing side in hbase-connectors

[ https://issues.apache.org/jira/browse/HBASE-25388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-25388: -- Fix Version/s: connector-1.0.1 Resolution: Fixed Status: Resolved (was: Patc

[GitHub] [hbase-connectors] petersomogyi merged pull request #76: HBASE-25388 Using an extension of MockProducer on testing side

petersomogyi merged pull request #76: URL: https://github.com/apache/hbase-connectors/pull/76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] lokiore commented on a change in pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

lokiore commented on a change in pull request #2299: URL: https://github.com/apache/hbase/pull/2299#discussion_r541777881 ## File path: hbase-it/src/main/java/org/apache/hadoop/hbase/chaos/ChaosService.java ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundati

[jira] [Assigned] (HBASE-25388) Replacing Producer implementation with an extension of MockProducer on testing side in hbase-connectors

[ https://issues.apache.org/jira/browse/HBASE-25388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reassigned HBASE-25388: - Assignee: Andras Katona > Replacing Producer implementation with an extension of MockPr

[jira] [Commented] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in old

[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248453#comment-17248453 ] Hudson commented on HBASE-23340: Results for branch master [build #157 on build

[jira] [Commented] (HBASE-25370) Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage

[ https://issues.apache.org/jira/browse/HBASE-25370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248452#comment-17248452 ] Hudson commented on HBASE-25370: Results for branch master [build #157 on build

[GitHub] [hbase] Apache-HBase commented on pull request #2748: HBASE-25373 Remove HTrace completely in code base and try to make use…

Apache-HBase commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-743788913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #2748: HBASE-25373 Remove HTrace completely in code base and try to make use…

Apache-HBase commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-743771338 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #76: HBASE-25388 Using an extension of MockProducer on testing side

Apache-HBase commented on pull request #76: URL: https://github.com/apache/hbase-connectors/pull/76#issuecomment-743769409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Updated] (HBASE-25388) Replacing Producer implementation with an extension of MockProducer on testing side in hbase-connectors

[ https://issues.apache.org/jira/browse/HBASE-25388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Katona updated HBASE-25388: -- Status: Patch Available (was: Open) > Replacing Producer implementation with an extension of

[GitHub] [hbase-connectors] akatona84 commented on pull request #76: HBASE-25388 Using an extension of MockProducer on testing side

akatona84 commented on pull request #76: URL: https://github.com/apache/hbase-connectors/pull/76#issuecomment-743766553 @meszibalu , @petersomogyi Could you pls review? This is an automated message from the Apache Git Servic

[GitHub] [hbase-connectors] akatona84 opened a new pull request #76: HBASE-25388 Using an extension of MockProducer on testing side

akatona84 opened a new pull request #76: URL: https://github.com/apache/hbase-connectors/pull/76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Created] (HBASE-25388) Replacing Producer implementation with an extension of MockProducer on testing side in hbase-connectors

Andras Katona created HBASE-25388: - Summary: Replacing Producer implementation with an extension of MockProducer on testing side in hbase-connectors Key: HBASE-25388 URL: https://issues.apache.org/jira/browse/HBAS

[GitHub] [hbase] Apache9 commented on pull request #2748: HBASE-25373 Remove HTrace completely in code base and try to make use…

Apache9 commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-743759517 > Skimmed. Looks good. Export somehow so could see pretty pictures would be sweet. Could be export be dump to a new hbase servlet traces page? For me I think first we could

[jira] [Commented] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in old

[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248348#comment-17248348 ] Duo Zhang commented on HBASE-23340: --- [~Bo Cui] The master patch is not easy to apply

[jira] [Commented] (HBASE-25293) Followup jira to address the client handling issue when chaning from meta replica to non-meta-replica at the server side.

[ https://issues.apache.org/jira/browse/HBASE-25293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248347#comment-17248347 ] Hudson commented on HBASE-25293: Results for branch master [build #156 on build

[GitHub] [hbase] Apache9 closed pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

Apache9 closed pull request #2689: URL: https://github.com/apache/hbase/pull/2689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache9 merged pull request #2739: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

Apache9 merged pull request #2739: URL: https://github.com/apache/hbase/pull/2739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th