[GitHub] [hbase] Apache-HBase commented on pull request #2869: Backport "HBASE-25249 Adding StoreContext" to branch-2

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2869: URL: https://github.com/apache/hbase/pull/2869#issuecomment-757108366 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2869: Backport "HBASE-25249 Adding StoreContext" to branch-2

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2869: URL: https://github.com/apache/hbase/pull/2869#issuecomment-757106250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25249) Adding HStoreContext

2021-01-08 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261773#comment-17261773 ] Tak-Lon (Stephen) Wu commented on HBASE-25249: -- created [PR

[GitHub] [hbase] taklwu opened a new pull request #2869: Backport "HBASE-25249 Adding StoreContext" to branch-2

2021-01-08 Thread GitBox
taklwu opened a new pull request #2869: URL: https://github.com/apache/hbase/pull/2869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2855: URL: https://github.com/apache/hbase/pull/2855#issuecomment-757101059 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25473) [create-release] checkcompatibility.py failing with "KeyError: 'binary'"

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261762#comment-17261762 ] Hudson commented on HBASE-25473: Results for branch master [build #180 on

[jira] [Commented] (HBASE-25459) WAL can't be cleaned in some scenes

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261758#comment-17261758 ] Hudson commented on HBASE-25459: Results for branch master [build #180 on

[jira] [Commented] (HBASE-25434) SlowDelete & SlowPut metric value should use updateDelete & updatePut

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261756#comment-17261756 ] Hudson commented on HBASE-25434: Results for branch master [build #180 on

[jira] [Commented] (HBASE-25333) Add maven enforcer rule to ban VisibleForTesting imports

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261763#comment-17261763 ] Hudson commented on HBASE-25333: Results for branch master [build #180 on

[jira] [Commented] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261760#comment-17261760 ] Hudson commented on HBASE-25449: Results for branch master [build #180 on

[jira] [Commented] (HBASE-25483) set the loadMeta log level to debug.

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261757#comment-17261757 ] Hudson commented on HBASE-25483: Results for branch master [build #180 on

[jira] [Commented] (HBASE-25487) [create-release] changes.md update broken

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261759#comment-17261759 ] Hudson commented on HBASE-25487: Results for branch master [build #180 on

[jira] [Commented] (HBASE-25489) [git-jira-audit] improve performance of --parse-release-tags

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261761#comment-17261761 ] Hudson commented on HBASE-25489: Results for branch master [build #180 on

[jira] [Commented] (HBASE-25471) Move RegionScannerImpl out of HRegion

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261755#comment-17261755 ] Hudson commented on HBASE-25471: Results for branch master [build #180 on

[jira] [Comment Edited] (HBASE-25249) Adding HStoreContext

2021-01-08 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261749#comment-17261749 ] Tak-Lon (Stephen) Wu edited comment on HBASE-25249 at 1/9/21, 4:40 AM:

[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2855: URL: https://github.com/apache/hbase/pull/2855#issuecomment-757093725 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-08 Thread GitBox
saintstack commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-757093629 Left some advocacy for this addition up on the JIRA This is an automated message from the Apache Git Service.

[jira] [Commented] (HBASE-25375) Provide a VM-based release environment

2021-01-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261750#comment-17261750 ] Michael Stack commented on HBASE-25375: --- Just to report that this vm option is nice to have. If

[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2855: URL: https://github.com/apache/hbase/pull/2855#issuecomment-757093182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25249) Adding HStoreContext

2021-01-08 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-25249: - Fix Version/s: 3.0.0-alpha-1 > Adding HStoreContext > > >

[jira] [Commented] (HBASE-25249) Adding HStoreContext

2021-01-08 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261749#comment-17261749 ] Tak-Lon (Stephen) Wu commented on HBASE-25249: -- it has been merged as

[GitHub] [hbase] taklwu merged pull request #2800: HBASE-25249 Adding StoreContext

2021-01-08 Thread GitBox
taklwu merged pull request #2800: URL: https://github.com/apache/hbase/pull/2800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] dasanjan1296 commented on a change in pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-08 Thread GitBox
dasanjan1296 commented on a change in pull request #2855: URL: https://github.com/apache/hbase/pull/2855#discussion_r554285615 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java ## @@ -131,14 +131,14 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2868: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2868: URL: https://github.com/apache/hbase/pull/2868#issuecomment-757081366 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25434) SlowDelete & SlowPut metric value should use updateDelete & updatePut

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261723#comment-17261723 ] Hudson commented on HBASE-25434: Results for branch branch-2.4 [build #26 on

[jira] [Commented] (HBASE-25483) set the loadMeta log level to debug.

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261724#comment-17261724 ] Hudson commented on HBASE-25483: Results for branch branch-2.4 [build #26 on

[jira] [Created] (HBASE-25490) TestRollingRestart is broken

2021-01-08 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25490: - Summary: TestRollingRestart is broken Key: HBASE-25490 URL: https://issues.apache.org/jira/browse/HBASE-25490 Project: HBase Issue Type: Bug Components:

[GitHub] [hbase] Apache9 commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-08 Thread GitBox
Apache9 commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-757076173 Oh, after checking the code, I remembered what I concerned was another problem... If we do not register our znode on zookeeper after calling regionServerStartup, there is no way

[GitHub] [hbase] Apache-HBase commented on pull request #2868: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2868: URL: https://github.com/apache/hbase/pull/2868#issuecomment-757070057 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2868: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2868: URL: https://github.com/apache/hbase/pull/2868#issuecomment-757069579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2761: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2761: URL: https://github.com/apache/hbase/pull/2761#issuecomment-757069424 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] bharathv commented on a change in pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-08 Thread GitBox
bharathv commented on a change in pull request #2769: URL: https://github.com/apache/hbase/pull/2769#discussion_r554267148 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java ## @@ -111,4 +111,4 @@ public void

[GitHub] [hbase] Apache9 commented on a change in pull request #2868: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2021-01-08 Thread GitBox
Apache9 commented on a change in pull request #2868: URL: https://github.com/apache/hbase/pull/2868#discussion_r554266044 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -2388,51 +2388,56 @@ public void run(Timeout

[jira] [Commented] (HBASE-25486) Fix assembly of the hbase-shaded-testing-util*.jar; can't unzip on case-insensitive fs

2021-01-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261701#comment-17261701 ] Michael Stack commented on HBASE-25486: --- hmm... I backed up the Master branch by about a year to

[GitHub] [hbase] Apache-HBase commented on pull request #2761: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2761: URL: https://github.com/apache/hbase/pull/2761#issuecomment-757068020 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2761: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2761: URL: https://github.com/apache/hbase/pull/2761#issuecomment-757067882 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 merged pull request #2854: HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports

2021-01-08 Thread GitBox
Apache9 merged pull request #2854: URL: https://github.com/apache/hbase/pull/2854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-757064376 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-757063096 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25486) Fix assembly of the hbase-shaded-testing-util*.jar; can't unzip on case-insensitive fs

2021-01-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261689#comment-17261689 ] Michael Stack commented on HBASE-25486: --- hbase-shaded-testing-util was added here: {code} commit

[GitHub] [hbase] huaxiangsun commented on pull request #2868: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2021-01-08 Thread GitBox
huaxiangsun commented on pull request #2868: URL: https://github.com/apache/hbase/pull/2868#issuecomment-757062253 This is the update for review #2753 , it fixes the test failure in TestAdmin2. This is an automated message

[GitHub] [hbase] huaxiangsun opened a new pull request #2868: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2021-01-08 Thread GitBox
huaxiangsun opened a new pull request #2868: URL: https://github.com/apache/hbase/pull/2868 …me(byte[] regionName) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2761: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2761: URL: https://github.com/apache/hbase/pull/2761#issuecomment-757058954 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2761: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2761: URL: https://github.com/apache/hbase/pull/2761#issuecomment-757056386 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2761: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2761: URL: https://github.com/apache/hbase/pull/2761#issuecomment-757055439 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2854: HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2854: URL: https://github.com/apache/hbase/pull/2854#issuecomment-757052383 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] caroliney14 commented on pull request #2761: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-08 Thread GitBox
caroliney14 commented on pull request #2761: URL: https://github.com/apache/hbase/pull/2761#issuecomment-757045989 @virajjasani @bharathv @apurtell updated this PR to dump to logs only. any more suggestions here? if not I will also update PRs for branch-1 and branch-2. thanks!

[jira] [Resolved] (HBASE-25473) [create-release] checkcompatibility.py failing with "KeyError: 'binary'"

2021-01-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25473. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Release Note: Adds temporary

[jira] [Commented] (HBASE-25486) Fix assembly of the hbase-shaded-testing-util*.jar; can't unzip on case-insensitive fs

2021-01-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261632#comment-17261632 ] Michael Stack commented on HBASE-25486: --- When fixed, need to remove an exclude of this shaded jar

[GitHub] [hbase] saintstack merged pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
saintstack merged pull request #2862: URL: https://github.com/apache/hbase/pull/2862 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HBASE-25489) [git-jira-audit] improve performance of --parse-release-tags

2021-01-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-25489. -- Resolution: Fixed > [git-jira-audit] improve performance of --parse-release-tags >

[GitHub] [hbase] ndimiduk commented on pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
ndimiduk commented on pull request #2867: URL: https://github.com/apache/hbase/pull/2867#issuecomment-757035137 Thanks for the reviews. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ndimiduk merged pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
ndimiduk merged pull request #2867: URL: https://github.com/apache/hbase/pull/2867 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on a change in pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
saintstack commented on a change in pull request #2862: URL: https://github.com/apache/hbase/pull/2862#discussion_r554232498 ## File path: dev-support/create-release/release-util.sh ## @@ -469,8 +469,18 @@ function generate_api_report { local timing_token

[GitHub] [hbase] ndimiduk commented on a change in pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
ndimiduk commented on a change in pull request #2862: URL: https://github.com/apache/hbase/pull/2862#discussion_r554230076 ## File path: dev-support/create-release/release-util.sh ## @@ -469,8 +469,18 @@ function generate_api_report { local timing_token

[GitHub] [hbase] Apache-HBase commented on pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2862: URL: https://github.com/apache/hbase/pull/2862#issuecomment-757029432 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2862: URL: https://github.com/apache/hbase/pull/2862#issuecomment-757029157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2862: URL: https://github.com/apache/hbase/pull/2862#issuecomment-757029088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2854: HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2854: URL: https://github.com/apache/hbase/pull/2854#issuecomment-757027545 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
saintstack commented on a change in pull request #2862: URL: https://github.com/apache/hbase/pull/2862#discussion_r554224607 ## File path: dev-support/checkcompatibility.py ## @@ -241,6 +241,20 @@ def compare_results(tool_results, known_issues, compare_warnings):

[GitHub] [hbase] saintstack commented on a change in pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
saintstack commented on a change in pull request #2862: URL: https://github.com/apache/hbase/pull/2862#discussion_r554224191 ## File path: dev-support/create-release/release-util.sh ## @@ -469,8 +469,18 @@ function generate_api_report { local timing_token

[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-757026123 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-15073) Finer grained control over normalization actions for RegionNormalizer

2021-01-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-15073. -- Resolution: Won't Fix Closing old, reverted normalizer issue as "Won't Fix". > Finer grained

[GitHub] [hbase] Apache-HBase commented on pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2867: URL: https://github.com/apache/hbase/pull/2867#issuecomment-757014063 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2867: URL: https://github.com/apache/hbase/pull/2867#issuecomment-757013810 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-08 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-25449. Hadoop Flags: Reviewed Release Note: The presence of HDFS short-circuit read configuration

[jira] [Updated] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-08 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25449: --- Fix Version/s: 2.3.5 2.4.1 2.5.0 2.2.7

[GitHub] [hbase] Apache-HBase commented on pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2867: URL: https://github.com/apache/hbase/pull/2867#issuecomment-757010592 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2867: URL: https://github.com/apache/hbase/pull/2867#issuecomment-757010421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2867: URL: https://github.com/apache/hbase/pull/2867#issuecomment-757010255 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
ndimiduk commented on pull request #2867: URL: https://github.com/apache/hbase/pull/2867#issuecomment-757007860 See before and after flame graphs attached to the JIRA. This is an automated message from the Apache Git

[jira] [Updated] (HBASE-25489) [git-jira-audit] improve performance of --parse-release-tags

2021-01-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25489: - Attachment: profile_patched.svg > [git-jira-audit] improve performance of --parse-release-tags

[GitHub] [hbase] ndimiduk opened a new pull request #2867: HBASE-25489 improve performance of --parse-release-tags

2021-01-08 Thread GitBox
ndimiduk opened a new pull request #2867: URL: https://github.com/apache/hbase/pull/2867 Profiler shows a lot of time spent in the UPDATE SQL statement. Remove the tight loop and let SQL do a bulk-update instead. This is

[jira] [Work started] (HBASE-25489) [git-jira-audit] improve performance of --parse-release-tags

2021-01-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25489 started by Nick Dimiduk. > [git-jira-audit] improve performance of --parse-release-tags >

[jira] [Created] (HBASE-25489) [git-jira-audit] improve performance of --parse-release-tags

2021-01-08 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25489: Summary: [git-jira-audit] improve performance of --parse-release-tags Key: HBASE-25489 URL: https://issues.apache.org/jira/browse/HBASE-25489 Project: HBase

[GitHub] [hbase] christinefeng opened a new pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-08 Thread GitBox
christinefeng opened a new pull request #2866: URL: https://github.com/apache/hbase/pull/2866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] ndimiduk commented on a change in pull request #2862: HBASE-25473 [create-release] checkcompatibility.py failing with "KeyE…

2021-01-08 Thread GitBox
ndimiduk commented on a change in pull request #2862: URL: https://github.com/apache/hbase/pull/2862#discussion_r554189525 ## File path: dev-support/checkcompatibility.py ## @@ -241,6 +241,20 @@ def compare_results(tool_results, known_issues, compare_warnings): return

[jira] [Commented] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-08 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261583#comment-17261583 ] Josh Elser commented on HBASE-25449: Tested this on branch-2 and master, locally, just to make sure

[jira] [Resolved] (HBASE-25487) [create-release] changes.md update broken

2021-01-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25487. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Assignee: Michael Stack

[GitHub] [hbase] saintstack merged pull request #2864: HBASE-25487 [create-release] changes.md update broken

2021-01-08 Thread GitBox
saintstack merged pull request #2864: URL: https://github.com/apache/hbase/pull/2864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] joshelser commented on pull request #2849: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2021-01-08 Thread GitBox
joshelser commented on pull request #2849: URL: https://github.com/apache/hbase/pull/2849#issuecomment-756983731 > Running tests locally to make sure we don't have a similar problem to last time :) Not observing any run-away logging for replication tests in hbase-server. 

[jira] [Commented] (HBASE-25487) [create-release] changes.md update broken

2021-01-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261554#comment-17261554 ] Michael Stack commented on HBASE-25487: --- This is the change that broke the JIRA project name

[jira] [Commented] (HBASE-25483) set the loadMeta log level to debug.

2021-01-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261552#comment-17261552 ] Hudson commented on HBASE-25483: Results for branch branch-2.2 [build #147 on

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-08 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r554147880 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreContext.java ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (HBASE-25488) Clean up mess made by broken create-release in CHANGES.md

2021-01-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25488. --- Fix Version/s: 2.3.4 Hadoop Flags: Reviewed Assignee: Michael Stack

[GitHub] [hbase] saintstack merged pull request #2865: HBASE-25488 Clean up mess made by broken create-release in CHANGES.md

2021-01-08 Thread GitBox
saintstack merged pull request #2865: URL: https://github.com/apache/hbase/pull/2865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2861: HBASE-25455 Add trace support for HRegion read/write operation

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2861: URL: https://github.com/apache/hbase/pull/2861#issuecomment-756942059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2865: HBASE-25488 Clean up mess made by broken create-release in CHANGES.md

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2865: URL: https://github.com/apache/hbase/pull/2865#issuecomment-756939924 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2865: HBASE-25488 Clean up mess made by broken create-release in CHANGES.md

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2865: URL: https://github.com/apache/hbase/pull/2865#issuecomment-756938975 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2865: HBASE-25488 Clean up mess made by broken create-release in CHANGES.md

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2865: URL: https://github.com/apache/hbase/pull/2865#issuecomment-756938754 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack opened a new pull request #2865: HBASE-25488 Clean up mess made by broken create-release in CHANGES.md

2021-01-08 Thread GitBox
saintstack opened a new pull request #2865: URL: https://github.com/apache/hbase/pull/2865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2861: HBASE-25455 Add trace support for HRegion read/write operation

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2861: URL: https://github.com/apache/hbase/pull/2861#issuecomment-756936792 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] joshelser commented on a change in pull request #2849: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2021-01-08 Thread GitBox
joshelser commented on a change in pull request #2849: URL: https://github.com/apache/hbase/pull/2849#discussion_r554118044 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java ## @@ -330,4 +333,56 @@ public

[jira] [Created] (HBASE-25488) Clean up mess made by broken create-release in CHANGES.md

2021-01-08 Thread Michael Stack (Jira)
Michael Stack created HBASE-25488: - Summary: Clean up mess made by broken create-release in CHANGES.md Key: HBASE-25488 URL: https://issues.apache.org/jira/browse/HBASE-25488 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2864: HBASE-25487 [create-release] changes.md update broken

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2864: URL: https://github.com/apache/hbase/pull/2864#issuecomment-756928180 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2864: HBASE-25487 [create-release] changes.md update broken

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2864: URL: https://github.com/apache/hbase/pull/2864#issuecomment-756927932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] saintstack opened a new pull request #2864: HBASE-25487 [create-release] changes.md update broken

2021-01-08 Thread GitBox
saintstack opened a new pull request #2864: URL: https://github.com/apache/hbase/pull/2864 I did the following to test this change. $ cd dev-support/create-release $ export YETUS_HOME=~/checkouts/apache-yetus-0.12.0 $ . release-util.sh # source'd the utility file $

[jira] [Created] (HBASE-25487) [create-release] changes.md update broken

2021-01-08 Thread Michael Stack (Jira)
Michael Stack created HBASE-25487: - Summary: [create-release] changes.md update broken Key: HBASE-25487 URL: https://issues.apache.org/jira/browse/HBASE-25487 Project: HBase Issue Type: Bug

[jira] [Work started] (HBASE-25485) Nightly build uses JDK11 for branch-2.2

2021-01-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25485 started by Peter Somogyi. - > Nightly build uses JDK11 for branch-2.2 >

[GitHub] [hbase] Apache-HBase commented on pull request #2863: HBASE-25485 Nightly build uses JDK11 for branch-2.2

2021-01-08 Thread GitBox
Apache-HBase commented on pull request #2863: URL: https://github.com/apache/hbase/pull/2863#issuecomment-756910844 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

  1   2   >