[GitHub] [hbase] Apache-HBase commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-849347563 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25929) RegionServer JVM crash when compaction

2021-05-26 Thread Yi Mei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352284#comment-17352284 ] Yi Mei commented on HBASE-25929: I add a UT to reproduce the problem. And I will upload a patch later.

[GitHub] [hbase] mymeiyi opened a new pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-05-26 Thread GitBox
mymeiyi opened a new pull request #3318: URL: https://github.com/apache/hbase/pull/3318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (HBASE-25929) RegionServer JVM crash when compaction

2021-05-26 Thread Yi Mei (Jira)
Yi Mei created HBASE-25929: -- Summary: RegionServer JVM crash when compaction Key: HBASE-25929 URL: https://issues.apache.org/jira/browse/HBASE-25929 Project: HBase Issue Type: Bug

[GitHub] [hbase-operator-tools] taklwu commented on pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-26 Thread GitBox
taklwu commented on pull request #88: URL: https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-849308745 @joshelser I added unit tests to make sure we use the filesystem defined in `hbase.rootdir` instead of `fs.defaultFS`. if you're looking for end-to-end unit tests for

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #88: URL: https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-849305692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase-operator-tools] taklwu commented on a change in pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-26 Thread GitBox
taklwu commented on a change in pull request #88: URL: https://github.com/apache/hbase-operator-tools/pull/88#discussion_r640272518 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java ## @@ -1535,7 +1535,7 @@ private void loadHdfsRegioninfo(HbckInfo

[GitHub] [hbase] Apache-HBase commented on pull request #3313: HBASE-25926 Cleanup MetaTableAccessor references in FavoredNodeBalanc…

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3313: URL: https://github.com/apache/hbase/pull/3313#issuecomment-849298922 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849297546 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-26 Thread GitBox
nyl3532016 commented on a change in pull request #3266: URL: https://github.com/apache/hbase/pull/3266#discussion_r640255301 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java ## @@ -253,6 +256,12 @@ private void init(final int

[GitHub] [hbase] Apache9 commented on a change in pull request #3202: HBASE-25803 Add compaction offload switch

2021-05-26 Thread GitBox
Apache9 commented on a change in pull request #3202: URL: https://github.com/apache/hbase/pull/3202#discussion_r640254840 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SwitchCompactionOffloadProcedure.java ## @@ -0,0 +1,171 @@ +/** + *

[jira] [Work started] (HBASE-25926) Cleanup MetaTableAccessor references in FavoredNodeBalancer related code

2021-05-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25926 started by Duo Zhang. - > Cleanup MetaTableAccessor references in FavoredNodeBalancer related code >

[jira] [Commented] (HBASE-25894) Improve the performance for region load and region count related cost functions

2021-05-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352241#comment-17352241 ] Duo Zhang commented on HBASE-25894: --- No compatibility issues. The only thing is that, this patch is

[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849257102 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849215410 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3317: HBASE-25918 Upgrade hbase-thirdparty dependency to 3.5.0

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3317: URL: https://github.com/apache/hbase/pull/3317#issuecomment-849213369 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/26/21, 11:19 PM:

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/26/21, 11:18 PM:

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/26/21, 11:17 PM:

[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell commented on HBASE-25913: - Once HBASE-25911 is committed I can open a PR

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/26/21, 11:09 PM:

[jira] [Commented] (HBASE-25928) TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3

2021-05-26 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352179#comment-17352179 ] Wei-Chiu Chuang commented on HBASE-25928: - Link:

[jira] [Reopened] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-26 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reopened HBASE-25861: - Sorry to reopen. I think we need to understand the behavior change better. CC: [~snemeth]

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Attachment: 0001-HBASE-25913-Introduce-EnvironmentEdge.currentTimeAdv.patch >

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/26/21, 11:08 PM:

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Attachment: (was:

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Attachment: 0001-HBASE-25913-Introduce-EnvironmentEdge.currentTimeAdv.patch >

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/26/21, 11:37 PM:

[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-26 Thread GitBox
apurtell commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849192021 Update fixes a checkstyle nit in SimpleServerRpcConnection. The rest of them aren't mine. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/26/21, 11:22 PM:

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352181#comment-17352181 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/26/21, 11:22 PM:

[jira] [Commented] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-26 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352113#comment-17352113 ] Wei-Chiu Chuang commented on HBASE-25861: - Reproducible with

[jira] [Created] (HBASE-25928) TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3

2021-05-26 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HBASE-25928: --- Summary: TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3 Key: HBASE-25928 URL: https://issues.apache.org/jira/browse/HBASE-25928

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-849168871 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3317: HBASE-25918 Upgrade hbase-thirdparty dependency to 3.5.0

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3317: URL: https://github.com/apache/hbase/pull/3317#issuecomment-849164534 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849157911 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-849124192 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-operator-tools] taklwu commented on a change in pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-26 Thread GitBox
taklwu commented on a change in pull request #88: URL: https://github.com/apache/hbase-operator-tools/pull/88#discussion_r640115793 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java ## @@ -1535,7 +1535,7 @@ private void loadHdfsRegioninfo(HbckInfo

[GitHub] [hbase-operator-tools] taklwu commented on a change in pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-26 Thread GitBox
taklwu commented on a change in pull request #88: URL: https://github.com/apache/hbase-operator-tools/pull/88#discussion_r640115793 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java ## @@ -1535,7 +1535,7 @@ private void loadHdfsRegioninfo(HbckInfo

[GitHub] [hbase-operator-tools] taklwu commented on a change in pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-26 Thread GitBox
taklwu commented on a change in pull request #88: URL: https://github.com/apache/hbase-operator-tools/pull/88#discussion_r640115793 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java ## @@ -1535,7 +1535,7 @@ private void loadHdfsRegioninfo(HbckInfo

[GitHub] [hbase] Apache-HBase commented on pull request #3316: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3316: URL: https://github.com/apache/hbase/pull/3316#issuecomment-849101191 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-26 Thread GitBox
apurtell commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849094550 Rebase and fix TestRegionServerReportForDuty#testReportForDutyWithEnvironmentEdge. This test injected ManualEnvironmentEdge and never incremented the time. It doesn't

[GitHub] [hbase] Apache-HBase commented on pull request #3313: HBASE-25926 Cleanup MetaTableAccessor references in FavoredNodeBalanc…

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3313: URL: https://github.com/apache/hbase/pull/3313#issuecomment-849091739 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3310: URL: https://github.com/apache/hbase/pull/3310#issuecomment-849090757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3317: HBASE-25918 Upgrade hbase-thirdparty dependency to 3.5.0

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3317: URL: https://github.com/apache/hbase/pull/3317#issuecomment-849084600 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3314: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3314: URL: https://github.com/apache/hbase/pull/3314#issuecomment-849072487 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3315: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3315: URL: https://github.com/apache/hbase/pull/3315#issuecomment-849062479 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3315: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3315: URL: https://github.com/apache/hbase/pull/3315#issuecomment-849060186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Work started] (HBASE-25918) Upgrade hbase-thirdparty dependency to 3.5.0

2021-05-26 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25918 started by Pankaj Kumar. > Upgrade hbase-thirdparty dependency to 3.5.0 >

[GitHub] [hbase] pankaj72981 opened a new pull request #3317: HBASE-25918 Upgrade hbase-thirdparty dependency to 3.5.0

2021-05-26 Thread GitBox
pankaj72981 opened a new pull request #3317: URL: https://github.com/apache/hbase/pull/3317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-849039405 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25907) Move StoreFlushContext out of HStore and make it pluggable

2021-05-26 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25907. -- Resolution: Fixed > Move StoreFlushContext out of HStore and make it

[jira] [Updated] (HBASE-25907) Move StoreFlushContext out of HStore and make it pluggable

2021-05-26 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25907: - Affects Version/s: 3.0.0-alpha-1 > Move StoreFlushContext out of HStore and

[GitHub] [hbase] wchevreuil merged pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-26 Thread GitBox
wchevreuil merged pull request #3298: URL: https://github.com/apache/hbase/pull/3298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] wchevreuil commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-26 Thread GitBox
wchevreuil commented on pull request #3298: URL: https://github.com/apache/hbase/pull/3298#issuecomment-849027514 The previous UT failure was a flakey, have it passing locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3298: URL: https://github.com/apache/hbase/pull/3298#issuecomment-849026996 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3313: HBASE-25926 Cleanup MetaTableAccessor references in FavoredNodeBalanc…

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3313: URL: https://github.com/apache/hbase/pull/3313#issuecomment-849013810 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3314: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3314: URL: https://github.com/apache/hbase/pull/3314#issuecomment-849012000 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25896) Implement a Region Visualization on Master WebUI

2021-05-26 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351979#comment-17351979 ] Sean Busbey commented on HBASE-25896: - from the WIP feature branch it looks like you're relying on

[GitHub] [hbase] vli02 commented on a change in pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-26 Thread GitBox
vli02 commented on a change in pull request #3308: URL: https://github.com/apache/hbase/pull/3308#discussion_r639992175 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java ## @@ -44,16 +46,20 @@ @Test public void

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351972#comment-17351972 ] Andrew Kyle Purtell commented on HBASE-25924: - Thanks for the fix [~shahrs87] ! > Seeing a

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-26 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351973#comment-17351973 ] Rushabh Shah commented on HBASE-25924: -- Thank you [~apurtell] for the review and commit and

[jira] [Updated] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25924: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was:

[GitHub] [hbase] shahrs87 commented on pull request #3314: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
shahrs87 commented on pull request #3314: URL: https://github.com/apache/hbase/pull/3314#issuecomment-848987192 @apurtell Jenkins run for tests haven't completed yet :( Hopefully nothing will break. Will keep a watch. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] apurtell merged pull request #3316: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
apurtell merged pull request #3316: URL: https://github.com/apache/hbase/pull/3316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] apurtell merged pull request #3315: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
apurtell merged pull request #3315: URL: https://github.com/apache/hbase/pull/3315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] apurtell merged pull request #3314: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
apurtell merged pull request #3314: URL: https://github.com/apache/hbase/pull/3314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25924: Fix Version/s: 2.4.4 2.3.6 2.5.0

[GitHub] [hbase] Apache-HBase commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3298: URL: https://github.com/apache/hbase/pull/3298#issuecomment-848983386 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25924: Status: Patch Available (was: Open) > Seeing a spike in uncleanlyClosedWALs

[GitHub] [hbase] Apache-HBase commented on pull request #3315: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3315: URL: https://github.com/apache/hbase/pull/3315#issuecomment-848967295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-operator-tools] z-york commented on pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-26 Thread GitBox
z-york commented on pull request #88: URL: https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-848957542 +1 to the other changes requested, can you also do a grep of hbck to see if there are any other places being missed? This is definitely something we don't want to have

[GitHub] [hbase] Apache-HBase commented on pull request #3140: HBASE-25720 Sync WAL stuck when prepare flush cache will prevent flus…

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3140: URL: https://github.com/apache/hbase/pull/3140#issuecomment-848952481 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3140: HBASE-25720 Sync WAL stuck when prepare flush cache will prevent flus…

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3140: URL: https://github.com/apache/hbase/pull/3140#issuecomment-848949610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] shahrs87 opened a new pull request #3316: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
shahrs87 opened a new pull request #3316: URL: https://github.com/apache/hbase/pull/3316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (HBASE-25927) Fix the log messages by not stringifying the exceptions in log

2021-05-26 Thread Sandeep Pal (Jira)
Sandeep Pal created HBASE-25927: --- Summary: Fix the log messages by not stringifying the exceptions in log Key: HBASE-25927 URL: https://issues.apache.org/jira/browse/HBASE-25927 Project: HBase

[GitHub] [hbase] shahrs87 opened a new pull request #3315: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
shahrs87 opened a new pull request #3315: URL: https://github.com/apache/hbase/pull/3315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] shahrs87 commented on a change in pull request #3314: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
shahrs87 commented on a change in pull request #3314: URL: https://github.com/apache/hbase/pull/3314#discussion_r639895591 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSourceImpl.java ## @@

[GitHub] [hbase] Apache-HBase commented on pull request #3312: HBASE-25923 Region state stuck in PENDING_OPEN

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3312: URL: https://github.com/apache/hbase/pull/3312#issuecomment-848914812 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[jira] [Updated] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-26 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25924: - Description: Getting the following log line in all of our production clusters

[GitHub] [hbase] Apache-HBase commented on pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3310: URL: https://github.com/apache/hbase/pull/3310#issuecomment-848908692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3314: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3314: URL: https://github.com/apache/hbase/pull/3314#issuecomment-848908444 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3313: HBASE-25926 Cleanup MetaTableAccessor references in FavoredNodeBalanc…

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3313: URL: https://github.com/apache/hbase/pull/3313#issuecomment-848907262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-26 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25924: - Affects Version/s: 2.4.4 2.5.0

[jira] [Updated] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-26 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25924: - Component/s: wal Replication > Seeing a spike in

[jira] [Commented] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351903#comment-17351903 ] Hudson commented on HBASE-25898: Results for branch branch-1 [build #131 on

[GitHub] [hbase] bharathv commented on a change in pull request #3314: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
bharathv commented on a change in pull request #3314: URL: https://github.com/apache/hbase/pull/3314#discussion_r639880670 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSourceImpl.java ## @@

[GitHub] [hbase] Apache-HBase commented on pull request #3309: HBASE-25758 Move MetaTableAccessor out of hbase-balancer module

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3309: URL: https://github.com/apache/hbase/pull/3309#issuecomment-848898826 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3309: HBASE-25758 Move MetaTableAccessor out of hbase-balancer module

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3309: URL: https://github.com/apache/hbase/pull/3309#issuecomment-848897362 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3310: URL: https://github.com/apache/hbase/pull/3310#issuecomment-848896183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25894) Improve the performance for region load and region count related cost functions

2021-05-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351890#comment-17351890 ] Andrew Kyle Purtell commented on HBASE-25894: - Is there a compatibility issue that prevents

[GitHub] [hbase] Apache-HBase commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3298: URL: https://github.com/apache/hbase/pull/3298#issuecomment-848863305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 opened a new pull request #3314: HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream

2021-05-26 Thread GitBox
shahrs87 opened a new pull request #3314: URL: https://github.com/apache/hbase/pull/3314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache9 opened a new pull request #3313: HBASE-25926 Cleanup MetaTableAccessor references in FavoredNodeBalanc…

2021-05-26 Thread GitBox
Apache9 opened a new pull request #3313: URL: https://github.com/apache/hbase/pull/3313 …er related code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[jira] [Updated] (HBASE-25926) Cleanup MetaTableAccessor references in FavoredNodeBalancer related code

2021-05-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25926: -- Component/s: meta FavoredNodes Balancer > Cleanup MetaTableAccessor

[jira] [Assigned] (HBASE-25926) Cleanup MetaTableAccessor references in FavoredNodeBalancer related code

2021-05-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25926: - Assignee: Duo Zhang > Cleanup MetaTableAccessor references in FavoredNodeBalancer related code

[jira] [Created] (HBASE-25926) Cleanup MetaTableAccessor references in FavoredNodeBalancer related code

2021-05-26 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25926: - Summary: Cleanup MetaTableAccessor references in FavoredNodeBalancer related code Key: HBASE-25926 URL: https://issues.apache.org/jira/browse/HBASE-25926 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

2021-05-26 Thread GitBox
Apache-HBase commented on pull request #3310: URL: https://github.com/apache/hbase/pull/3310#issuecomment-848855305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351856#comment-17351856 ] Hudson commented on HBASE-25875: Results for branch branch-2.4 [build #127 on

[jira] [Resolved] (HBASE-25904) Client integration test is failing on master and branch-2

2021-05-26 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-25904. -- Resolution: Fixed > Client integration test is failing on master and branch-2 >

  1   2   >