clarax edited a comment on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894610280
> @joshelser @clarax This is ready for another look. To summarize the
changes:
>
> * All of the interface changes have been combined into the new commit I
just
clarax commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894610280
> @joshelser @clarax This is ready for another look. To summarize the
changes:
>
> * All of the interface changes have been combined into the new commit I
just added. I'll
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894610230
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
clarax opened a new pull request #3570:
URL: https://github.com/apache/hbase/pull/3570
…ate to improve computation speed for large cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
clarax commented on pull request #3500:
URL: https://github.com/apache/hbase/pull/3500#issuecomment-894609489
A parallel one was merged. Closing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
clarax closed pull request #3500:
URL: https://github.com/apache/hbase/pull/3500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HBASE-25697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395108#comment-17395108
]
ShuangQi Xia commented on HBASE-25697:
--
May be we can consider adding balance time window control,
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894603648
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894603250
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894593361
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-26178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clara Xiong updated HBASE-26178:
Description:
With ~800 node and ~500 regions per node on our large production cluster,
balancer
[
https://issues.apache.org/jira/browse/HBASE-26178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clara Xiong updated HBASE-26178:
Summary: Improve data structure and algorithm for BalanceClusterState to
improve computation
[
https://issues.apache.org/jira/browse/HBASE-26178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clara Xiong updated HBASE-26178:
Description:
With ~800 node and ~500 regions per node on our large production cluster,
balancer
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894584323
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894582737
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894582324
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
bbeaudreault commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894579338
Sorry I had to run out earlier and didn't realize that I missed removing
something that broke the build. I've fixed that up now so it should succeed and
be ready for review.
bbeaudreault edited a comment on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894486861
@joshelser @clarax This is ready for another look. To summarize the changes:
- All of the interface changes have been combined into the new commit I just
added.
[
https://issues.apache.org/jira/browse/HBASE-26178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clara Xiong updated HBASE-26178:
Description:
With ~800 node and ~500 regions per node on our large production cluster,
balancer
[
https://issues.apache.org/jira/browse/HBASE-24643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395023#comment-17395023
]
Clara Xiong commented on HBASE-24643:
-
Open https://issues.apache.org/jira/browse/HBASE-26178 to
Clara Xiong created HBASE-26178:
---
Summary: Improve data structure for BalanceClusterState to improve
computation speed for large cluster
Key: HBASE-26178
URL: https://issues.apache.org/jira/browse/HBASE-26178
[
https://issues.apache.org/jira/browse/HBASE-24643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394304#comment-17394304
]
Clara Xiong edited comment on HBASE-24643 at 8/7/21, 12:05 AM:
---
Replace
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894518841
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894513895
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894512477
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
bharathv commented on a change in pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#discussion_r684493515
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##
@@ -3046,13 +3044,18 @@ public GetMastersResponse
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894497247
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894494448
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
bbeaudreault commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894486861
@joshelser @clarax This is ready for another look. To summarize the changes:
- All of the interface changes have been combined into the new commit I just
added. I'll
Apache-HBase commented on pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#issuecomment-894478059
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#issuecomment-894474555
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3569:
URL: https://github.com/apache/hbase/pull/3569#issuecomment-894473982
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3569:
URL: https://github.com/apache/hbase/pull/3569#issuecomment-894468922
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894441746
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-26142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394939#comment-17394939
]
Hudson commented on HBASE-26142:
Results for branch branch-2
[build #315 on
[
https://issues.apache.org/jira/browse/HBASE-26177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394928#comment-17394928
]
Clara Xiong commented on HBASE-26177:
-
I was thinking about it as an emergency tool for a forced
Apache-HBase commented on pull request #3569:
URL: https://github.com/apache/hbase/pull/3569#issuecomment-894402074
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
taklwu commented on a change in pull request #3567:
URL: https://github.com/apache/hbase/pull/3567#discussion_r684378930
##
File path: dev-support/hbase-personality.sh
##
@@ -148,7 +148,7 @@ function personality_modules
# If we have HADOOP_PROFILE specified and we're on
[
https://issues.apache.org/jira/browse/HBASE-26142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394887#comment-17394887
]
Hudson commented on HBASE-26142:
Results for branch branch-2.3
[build #269 on
[
https://issues.apache.org/jira/browse/HBASE-26170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394888#comment-17394888
]
Hudson commented on HBASE-26170:
Results for branch branch-2.3
[build #269 on
Apache-HBase commented on pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#issuecomment-894374389
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3565:
URL: https://github.com/apache/hbase/pull/3565#issuecomment-894373066
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
sunhelly commented on a change in pull request #3553:
URL: https://github.com/apache/hbase/pull/3553#discussion_r684342153
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java
##
@@ -768,7 +768,7 @@ public synchronized boolean
sunhelly commented on a change in pull request #3553:
URL: https://github.com/apache/hbase/pull/3553#discussion_r684342153
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java
##
@@ -768,7 +768,7 @@ public synchronized boolean
Apache-HBase commented on pull request #3565:
URL: https://github.com/apache/hbase/pull/3565#issuecomment-894335865
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-26064.
---
Fix Version/s: HBASE-26067
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch
Apache9 commented on a change in pull request #3553:
URL: https://github.com/apache/hbase/pull/3553#discussion_r684308407
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java
##
@@ -768,7 +768,7 @@ public synchronized boolean
Apache9 commented on pull request #3460:
URL: https://github.com/apache/hbase/pull/3460#issuecomment-894324707
Pushed to branch HBASE-26067. Closed this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Apache9 closed pull request #3460:
URL: https://github.com/apache/hbase/pull/3460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on pull request #3488:
URL: https://github.com/apache/hbase/pull/3488#issuecomment-894315394
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#issuecomment-894279777
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3567:
URL: https://github.com/apache/hbase/pull/3567#issuecomment-894275118
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3567:
URL: https://github.com/apache/hbase/pull/3567#issuecomment-894275047
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3567:
URL: https://github.com/apache/hbase/pull/3567#issuecomment-894274848
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
petersomogyi commented on pull request #3567:
URL: https://github.com/apache/hbase/pull/3567#issuecomment-894274756
I've modified the PR based on the discussion in #3568.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894274406
I've modified the PR for master. Please take a look at #3567. I'll update
this PR for the feature branch once master is merged.
--
This is an automated message from the
Apache-HBase commented on pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#issuecomment-894274355
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3567:
URL: https://github.com/apache/hbase/pull/3567#issuecomment-894274269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894272227
Using `=` or `=~` is handled differently. The first uses pattern matching
the latter uses regex.
```
bash-5.1$ export PATCH_BRANCH=branch-1; if [[ "${PATCH_BRANCH}"
Apache-HBase commented on pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#issuecomment-894272260
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3565:
URL: https://github.com/apache/hbase/pull/3565#issuecomment-894262654
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894253004
I'll fix these regexes as well.
> What does the dot actually mean here? It means the dot itself or any char?
The dot means any character.
--
This is an
skyguard1 commented on a change in pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#discussion_r684221703
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
##
@@ -331,12 +331,12 @@ protected Path
wchevreuil commented on pull request #3460:
URL: https://github.com/apache/hbase/pull/3460#issuecomment-894245479
> > > Ping @wchevreuil @saintstack @z-york Any other concerns on this
approach? If worth a try, I will merge this to a feature branch and start to
implement file based
skyguard1 commented on a change in pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#discussion_r684217460
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
##
@@ -331,12 +331,12 @@ protected Path
Apache9 commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894244142
But also this
```
elif [[ "${PATCH_BRANCH}" = branch-2.* ]]; then
yetus_info "Setting Hadoop 2 versions to test based on branch-2.3+
rules."
```
I'm a
Apache9 commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894243050
> > How about branch-2? This regex will only accept branch-2.x?
>
> The regex will accept `branch-2` and `branch-2` from now on. The
previous regex was faulty and allowed
petersomogyi edited a comment on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894239912
> How about branch-2? This regex will only accept branch-2.x?
The regex will accept `branch-2` and `branch-2` from now on. The
previous regex was faulty and
Apache9 commented on a change in pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#discussion_r684213298
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
##
@@ -331,12 +331,12 @@ protected Path
petersomogyi edited a comment on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894239912
> How about branch-2? This regex will only accept branch-2.x?
The regex will accept `branch-2` and `branch-2` from now on. The
previous regex was faulty and
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894239912
> How about branch-2? This regex will only accept branch-2.x?
The regex will accept branch-2 and branch-2 from now on. The
previous regex was faulty and allowed
Apache9 commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894238514
How about branch-2? This regex will only accept branch-2.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/HBASE-26142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394744#comment-17394744
]
Hudson commented on HBASE-26142:
Results for branch master
[build #361 on
[
https://issues.apache.org/jira/browse/HBASE-26170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394745#comment-17394745
]
Hudson commented on HBASE-26170:
Results for branch master
[build #361 on
skyguard1 commented on a change in pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#discussion_r684169439
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
##
@@ -331,12 +331,12 @@ protected Path
Apache9 commented on pull request #3460:
URL: https://github.com/apache/hbase/pull/3460#issuecomment-894215554
> > Ping @wchevreuil @saintstack @z-york Any other concerns on this
approach? If worth a try, I will merge this to a feature branch and start to
implement file based tracking.
skyguard1 commented on a change in pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#discussion_r684169439
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
##
@@ -331,12 +331,12 @@ protected Path
skyguard1 commented on a change in pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#discussion_r684169439
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
##
@@ -331,12 +331,12 @@ protected Path
jojochuang commented on a change in pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#discussion_r684142758
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
##
@@ -331,12 +331,12 @@ protected Path
wchevreuil commented on pull request #3460:
URL: https://github.com/apache/hbase/pull/3460#issuecomment-894159362
> Ping @wchevreuil @saintstack @z-york Any other concerns on this approach?
If worth a try, I will merge this to a feature branch and start to implement
file based tracking.
Apache-HBase commented on pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#issuecomment-894093118
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-25947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394607#comment-17394607
]
ShuangQi Xia commented on HBASE-25947:
--
Can we ignore a small number of RIT regions?
Or set the
Apache-HBase commented on pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#issuecomment-894060433
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
83 matches
Mail list logo
