[GitHub] [hbase] Apache9 commented on a change in pull request #3682: Hbase-26178 HBaseHBASE-26178 Improve data structure and algorithm for BalanceClusterState to improve computation speed for large

2021-09-23 Thread GitBox
Apache9 commented on a change in pull request #3682: URL: https://github.com/apache/hbase/pull/3682#discussion_r715331121 ## File path: hbase-shaded/pom.xml ## @@ -451,6 +451,10 @@ net/ ${shaded.prefix}.net. +

[jira] [Commented] (HBASE-26287) the initialization of master could not be completed when hbase:namesapce' region is not online

2021-09-23 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419556#comment-17419556 ] Anoop Sam John commented on HBASE-26287: Why the SSH for the old RS (where NS region) not

[GitHub] [hbase] clarax commented on a change in pull request #3682: Hbase-26178 HBaseHBASE-26178 Improve data structure and algorithm for BalanceClusterState to improve computation speed for large

2021-09-23 Thread GitBox
clarax commented on a change in pull request #3682: URL: https://github.com/apache/hbase/pull/3682#discussion_r715306532 ## File path: hbase-shaded/pom.xml ## @@ -451,6 +451,10 @@ net/ ${shaded.prefix}.net. +

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926329487 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #3682: Hbase-26178 HBaseHBASE-26178 Improve data structure and algorithm for BalanceClusterState to improve computation speed for large

2021-09-23 Thread GitBox
Apache9 commented on a change in pull request #3682: URL: https://github.com/apache/hbase/pull/3682#discussion_r715301825 ## File path: hbase-shaded/pom.xml ## @@ -451,6 +451,10 @@ net/ ${shaded.prefix}.net. +

[jira] [Updated] (HBASE-26294) Backport "HBASE-26181 Region server and master could use itself as ConnectionRegistry" to branch-2

2021-09-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26294: -- Fix Version/s: 2.5.0 > Backport "HBASE-26181 Region server and master could use itself as >

[jira] [Created] (HBASE-26294) Backport "HBASE-26181 Region server and master could use itself as ConnectionRegistry" to branch-2

2021-09-23 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26294: - Summary: Backport "HBASE-26181 Region server and master could use itself as ConnectionRegistry" to branch-2 Key: HBASE-26294 URL: https://issues.apache.org/jira/browse/HBASE-26294

[jira] [Created] (HBASE-26293) Use reservoir sampling when selecting bootstrap nodes

2021-09-23 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26293: - Summary: Use reservoir sampling when selecting bootstrap nodes Key: HBASE-26293 URL: https://issues.apache.org/jira/browse/HBASE-26293 Project: HBase Issue Type:

[jira] [Commented] (HBASE-26274) Create an option to reintroduce BlockCache to mapreduce job

2021-09-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419529#comment-17419529 ] Hudson commented on HBASE-26274: Results for branch branch-2.4 [build #202 on

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926299500 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache9 commented on a change in pull request #3691: URL: https://github.com/apache/hbase/pull/3691#discussion_r715271788 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java ## @@ -471,4 +485,57 @@ public static byte toByte(ByteBuffer buf,

[jira] [Commented] (HBASE-26259) Fallback support to pure Java compression

2021-09-23 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419515#comment-17419515 ] Andrew Kyle Purtell commented on HBASE-26259: - I spent some time today optimizing the LZMA

[GitHub] [hbase] apurtell edited a comment on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
apurtell edited a comment on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926269774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] apurtell commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
apurtell commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926269774 I spent some time today optimizing the LZMA codec. Yes, it is a super slow compressor (by design), but actually decompression is faster than both gzip and bzip2, if... XZ for

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #93: HBASE-26257 Addendum Improve Performance of HBCK when specifying a subset of t…

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #93: URL: https://github.com/apache/hbase-operator-tools/pull/93#issuecomment-926210817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase-operator-tools] z-york opened a new pull request #93: HBASE-26257 Addendum Improve Performance of HBCK when specifying a subset of t…

2021-09-23 Thread GitBox
z-york opened a new pull request #93: URL: https://github.com/apache/hbase-operator-tools/pull/93 …ables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] Apache-HBase commented on pull request #3667: HBASE-21521 Expose master startup status via web UI

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3667: URL: https://github.com/apache/hbase/pull/3667#issuecomment-926160885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] taklwu commented on a change in pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
taklwu commented on a change in pull request #3696: URL: https://github.com/apache/hbase/pull/3696#discussion_r715144046 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -2104,28 +2107,32 @@ public boolean

[GitHub] [hbase] taklwu commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
taklwu commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926142644 the [javac warning](https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt) of

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926137453 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926136257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926133488 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926131698 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926113148 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 commented on pull request #3667: HBASE-21521 Expose master startup status via web UI

2021-09-23 Thread GitBox
shahrs87 commented on pull request #3667: URL: https://github.com/apache/hbase/pull/3667#issuecomment-926092457 Test passing on my local cluster: ``` [INFO] [INFO] --- [INFO] T E S T S [INFO]

[GitHub] [hbase] Apache-HBase commented on pull request #3697: HBASE-26220 Use P2P communicate between region servers to sync the li…

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3697: URL: https://github.com/apache/hbase/pull/3697#issuecomment-926085008 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3697: HBASE-26220 Use P2P communicate between region servers to sync the li…

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3697: URL: https://github.com/apache/hbase/pull/3697#issuecomment-926083724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926079878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926076926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on a change in pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
apurtell commented on a change in pull request #3691: URL: https://github.com/apache/hbase/pull/3691#discussion_r715072949 ## File path: hbase-compression/hbase-compression-snappy/src/main/java/org/apache/hadoop/hbase/io/compress/xerial/SnappyCodec.java ## @@ -0,0 +1,115 @@

[GitHub] [hbase] Apache-HBase commented on pull request #3694: HBASE-26044 Add CompactionServer Web UI

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3694: URL: https://github.com/apache/hbase/pull/3694#issuecomment-926072557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
virajjasani commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926071037 All good with the patch, Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] apurtell commented on a change in pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
apurtell commented on a change in pull request #3691: URL: https://github.com/apache/hbase/pull/3691#discussion_r715068165 ## File path: hbase-compression/hbase-compression-snappy/src/main/java/org/apache/hadoop/hbase/io/compress/xerial/SnappyCodec.java ## @@ -0,0 +1,115 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
apurtell commented on a change in pull request #3691: URL: https://github.com/apache/hbase/pull/3691#discussion_r715067905 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferCache.java ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (HBASE-26274) Create an option to reintroduce BlockCache to mapreduce job

2021-09-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419410#comment-17419410 ] Hudson commented on HBASE-26274: Results for branch branch-2 [build #349 on

[jira] [Commented] (HBASE-26261) Store configuration loss when use update_config

2021-09-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419409#comment-17419409 ] Hudson commented on HBASE-26261: Results for branch branch-2 [build #349 on

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926070458 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
apurtell commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926069898 Squash and rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926037315 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926036068 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
virajjasani commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-926031997 I just tried building the project with the patch and it seems some missing imports are causing build failures. ``` TestWALCompressionLz4.java:[50,47] cannot find

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-926031669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3667: HBASE-21521 Expose master startup status via web UI

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3667: URL: https://github.com/apache/hbase/pull/3667#issuecomment-926022735 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3694: HBASE-26044 Add CompactionServer Web UI

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3694: URL: https://github.com/apache/hbase/pull/3694#issuecomment-926017350 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25588) Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

2021-09-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419357#comment-17419357 ] Hudson commented on HBASE-25588: Results for branch branch-2.3 [build #297 on

[jira] [Commented] (HBASE-26274) Create an option to reintroduce BlockCache to mapreduce job

2021-09-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419356#comment-17419356 ] Hudson commented on HBASE-26274: Results for branch branch-2.3 [build #297 on

[jira] [Commented] (HBASE-26261) Store configuration loss when use update_config

2021-09-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419355#comment-17419355 ] Hudson commented on HBASE-26261: Results for branch branch-2.3 [build #297 on

[GitHub] [hbase] Apache-HBase commented on pull request #3667: HBASE-21521 Expose master startup status via web UI

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3667: URL: https://github.com/apache/hbase/pull/3667#issuecomment-926008588 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3697: HBASE-26220 Use P2P communicate between region servers to sync the li…

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3697: URL: https://github.com/apache/hbase/pull/3697#issuecomment-926005140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-26220) Use P2P communicate between region servers to sync the list for bootstrap node

2021-09-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419301#comment-17419301 ] Duo Zhang edited comment on HBASE-26220 at 9/23/21, 4:19 PM: - I think this

[jira] [Commented] (HBASE-26220) Use P2P communicate between region servers to sync the list for bootstrap node

2021-09-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419301#comment-17419301 ] Duo Zhang commented on HBASE-26220: --- I think this is a very important improvements. In the current

[jira] [Assigned] (HBASE-26220) Use P2P communicate between region servers to sync the list for bootstrap node

2021-09-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26220: - Assignee: Duo Zhang > Use P2P communicate between region servers to sync the list for

[jira] [Work started] (HBASE-26220) Use P2P communicate between region servers to sync the list for bootstrap node

2021-09-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26220 started by Duo Zhang. - > Use P2P communicate between region servers to sync the list for bootstrap node >

[GitHub] [hbase] richardantal commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …

2021-09-23 Thread GitBox
richardantal commented on pull request #3688: URL: https://github.com/apache/hbase/pull/3688#issuecomment-925955478 @Apache9 That makes sense. I tested your change, also validated the number of cells returned for each row and it seems fine. Anyway lets wait all the UTs. -- This

[GitHub] [hbase] Apache9 commented on pull request #3697: HBASE-26220 Use P2P communicate between region servers to sync the li…

2021-09-23 Thread GitBox
Apache9 commented on pull request #3697: URL: https://github.com/apache/hbase/pull/3697#issuecomment-925953261 Let's see the result for UTs. Will add UT for verifying the newly introduced BootstrapNodeManager for large cluster. The final algorithm is very simple, as I noticed

[GitHub] [hbase] Apache9 opened a new pull request #3697: HBASE-26220 Use P2P communicate between region servers to sync the li…

2021-09-23 Thread GitBox
Apache9 opened a new pull request #3697: URL: https://github.com/apache/hbase/pull/3697 …st for bootstrap node -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3694: HBASE-26044 Add CompactionServer Web UI

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3694: URL: https://github.com/apache/hbase/pull/3694#issuecomment-925930900 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3678: HBASE-26251 StochasticLoadBalancer metrics should update even if bala…

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3678: URL: https://github.com/apache/hbase/pull/3678#issuecomment-925872061 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …

2021-09-23 Thread GitBox
Apache9 commented on pull request #3688: URL: https://github.com/apache/hbase/pull/3688#issuecomment-925854591 I tried to move this block of code ``` if (storeLimit > -1 && this.countPerRow >= (storeLimit + storeOffset)) { // do what SEEK_NEXT_ROW

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-925847494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3678: HBASE-26251 StochasticLoadBalancer metrics should update even if bala…

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3678: URL: https://github.com/apache/hbase/pull/3678#issuecomment-925841602 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 13m

[GitHub] [hbase] sunhelly commented on pull request #3652: HBASE-26242 Region never split when store file count larger than the …

2021-09-23 Thread GitBox
sunhelly commented on pull request #3652: URL: https://github.com/apache/hbase/pull/3652#issuecomment-925839764 @Apache9 Did I resolve your question? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #3694: HBASE-26044 Add CompactionServer Web UI

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3694: URL: https://github.com/apache/hbase/pull/3694#issuecomment-925839637 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26261) Store configuration loss when use update_config

2021-09-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419227#comment-17419227 ] Hudson commented on HBASE-26261: Results for branch master [build #396 on

[jira] [Commented] (HBASE-26274) Create an option to reintroduce BlockCache to mapreduce job

2021-09-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419228#comment-17419228 ] Hudson commented on HBASE-26274: Results for branch master [build #396 on

[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3688: URL: https://github.com/apache/hbase/pull/3688#issuecomment-925826266 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3688: URL: https://github.com/apache/hbase/pull/3688#issuecomment-925826121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] petersomogyi commented on pull request #3692: HBASE-26291 Upgrade commons-io to 2.8.0

2021-09-23 Thread GitBox
petersomogyi commented on pull request #3692: URL: https://github.com/apache/hbase/pull/3692#issuecomment-925780364 @apurtell: Are you ok with backporting this backport of commons-io upgrade to branch-2.4 to address CVE-2021-29425? @ndimiduk: If this lands on branch-2.4 we can also

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-925764584 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …

2021-09-23 Thread GitBox
virajjasani commented on a change in pull request #3688: URL: https://github.com/apache/hbase/pull/3688#discussion_r714731179 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java ## @@ -0,0 +1,121 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3688: URL: https://github.com/apache/hbase/pull/3688#issuecomment-925708987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26263) [Rolling Upgrading] Persist the StoreFileTracker configurations to TableDescriptor for existing tables

2021-09-23 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419131#comment-17419131 ] Zhuoyue Huang commented on HBASE-26263: --- HBASE-26246 set the SFT configurations to the

[jira] [Commented] (HBASE-26263) [Rolling Upgrading] Persist the StoreFileTracker configurations to TableDescriptor for existing tables

2021-09-23 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419132#comment-17419132 ] Zhuoyue Huang commented on HBASE-26263: --- HBASE-26246 set the SFT configurations to the

[GitHub] [hbase] Apache-HBase commented on pull request #3678: HBASE-26251 StochasticLoadBalancer metrics should update even if bala…

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3678: URL: https://github.com/apache/hbase/pull/3678#issuecomment-925705242 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3694: HBASE-26044 Add CompactionServer Web UI

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3694: URL: https://github.com/apache/hbase/pull/3694#issuecomment-925685081 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-925665993 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-925665286 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache9 commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-925663454 > > We have another issue for tracing the Admin interface? > > Hey Duo, Thanks for pointing out the missing part, and I would like to confirm if the

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-925659127 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] taklwu commented on a change in pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
taklwu commented on a change in pull request #3696: URL: https://github.com/apache/hbase/pull/3696#discussion_r714578155 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -462,24 +461,30 @@ public Admin getAdmin()

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-925617323 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …

2021-09-23 Thread GitBox
virajjasani commented on a change in pull request #3688: URL: https://github.com/apache/hbase/pull/3688#discussion_r714566278 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java ## @@ -757,7 +757,7 @@ public boolean next(List

[GitHub] [hbase] Apache9 commented on a change in pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache9 commented on a change in pull request #3696: URL: https://github.com/apache/hbase/pull/3696#discussion_r714559564 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -462,24 +461,30 @@ public Admin getAdmin()

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-925586463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-925585274 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3696: URL: https://github.com/apache/hbase/pull/3696#issuecomment-925578676 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Work started] (HBASE-26289) Hbase scan setMaxResultsPerColumnFamily not giving right results

2021-09-23 Thread Jira
[ https://issues.apache.org/jira/browse/HBASE-26289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26289 started by Richárd Antal. - > Hbase scan setMaxResultsPerColumnFamily not giving right results >

[jira] [Updated] (HBASE-26141) Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26141: - Description: Split from HBASE-25853, the original change of HBASE-22120 does

[jira] [Updated] (HBASE-26141) Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26141: - Summary: Add tracing support for HTable and sync connection on branch-2 (was:

[jira] [Commented] (HBASE-26141) Add tracing support for sync client on branch-2

2021-09-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17418992#comment-17418992 ] Tak-Lon (Stephen) Wu commented on HBASE-26141: -- sorry for my late, I created the PR and

[GitHub] [hbase] taklwu opened a new pull request #3696: HBASE-26141 Add tracing support for HTable and sync connection on branch-2

2021-09-23 Thread GitBox
taklwu opened a new pull request #3696: URL: https://github.com/apache/hbase/pull/3696 * RPC and IPC tracing supported by HBASE-26125 * WAL tracing supported by HBASE-26131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-92312 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3691: HBASE-26259 Fallback support to pure Java compression

2021-09-23 Thread GitBox
Apache-HBase commented on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-925539836 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m