Apache-HBase commented on PR #5392:
URL: https://github.com/apache/hbase/pull/5392#issuecomment-1715029032
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5394:
URL: https://github.com/apache/hbase/pull/5394#issuecomment-1715025701
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
[
https://issues.apache.org/jira/browse/HBASE-28055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764012#comment-17764012
]
Sergey Soldatov commented on HBASE-28055:
-
[~bbeaudreault], I've added pull requests for
ss77892 opened a new pull request, #5393:
URL: https://github.com/apache/hbase/pull/5393
the source of OLDEST_TIMESTAMP is different in the master branch and that
has been missed during the rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ss77892 opened a new pull request, #5392:
URL: https://github.com/apache/hbase/pull/5392
the source of OLDEST_TIMESTAMP is different in the master branch and that
has been missed during the rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1714926692
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1714925029
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Nikita Pande created HBASE-28071:
Summary: [hbase-connectors] CVE-2020-15250 in
org.glassfish:javax.el:jar:3.0.1-b08
Key: HBASE-28071
URL: https://issues.apache.org/jira/browse/HBASE-28071
Project:
[
https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikita Pande updated HBASE-28070:
-
Description:
mvn dependency tree shows below
{code:java}
[INFO] | +-
Nikita Pande created HBASE-28070:
Summary: CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08
Key: HBASE-28070
URL: https://issues.apache.org/jira/browse/HBASE-28070
Project: HBase
zhuyaogai commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714859323
@bbeaudreault hi, I found that the latest unit test failures seem to be
unrelated to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Apache-HBase commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714809656
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5391:
URL: https://github.com/apache/hbase/pull/5391#issuecomment-1714804454
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714796782
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
[
https://issues.apache.org/jira/browse/HBASE-28050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-28050:
-
Description:
As discussed on the parent Jira, let's mark the remote procedures fail when we
[
https://issues.apache.org/jira/browse/HBASE-28050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HBASE-28050:
Assignee: Viraj Jasani
> RSProcedureDispatcher to fail-fast for SaslException
>
Apache-HBase commented on PR #5363:
URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714609451
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5363:
URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714595876
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5363:
URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714594299
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Bryan Beaudreault created HBASE-28069:
-
Summary: Add support for quotas on atomic operations
Key: HBASE-28069
URL: https://issues.apache.org/jira/browse/HBASE-28069
Project: HBase
Issue
Apache-HBase commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714579437
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
bbeaudreault commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714564222
@zhuyaogai unit test failures look related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Apache-HBase commented on PR #5390:
URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714535755
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714535313
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714525287
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5390:
URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714525180
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
[
https://issues.apache.org/jira/browse/HBASE-28055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763906#comment-17763906
]
Bryan Beaudreault commented on HBASE-28055:
---
[~taklwu] This broke branch-2, 2.4, and 2.5.
Apache-HBase commented on PR #5389:
URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714503081
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5389:
URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714500571
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714269350
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
[
https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763825#comment-17763825
]
Andrew Kyle Purtell edited comment on HBASE-27231 at 9/11/23 5:03 PM:
[
https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763825#comment-17763825
]
Andrew Kyle Purtell edited comment on HBASE-27231 at 9/11/23 5:03 PM:
[
https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763825#comment-17763825
]
Andrew Kyle Purtell edited comment on HBASE-27231 at 9/11/23 5:01 PM:
[
https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763825#comment-17763825
]
Andrew Kyle Purtell commented on HBASE-27231:
-
I think we can. I cherry picked the master
Apache-HBase commented on PR #5390:
URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714244301
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
zhuyaogai commented on code in PR #5228:
URL: https://github.com/apache/hbase/pull/5228#discussion_r1321804040
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -692,6 +711,13 @@ public void updateRpc(MethodDescriptor method, Message
zhuyaogai commented on PR #5228:
URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714221773
> This is looking good! One more request.
>
> Also, can you please squash and rebase this PR so that we can clear out
the `patch` warning in the pre-commit hook?
done.
--
Apache-HBase commented on PR #5389:
URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714221362
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5388:
URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714212178
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5388:
URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714204962
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5388:
URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714201162
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
[
https://issues.apache.org/jira/browse/HBASE-27993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ConfX updated HBASE-27993:
--
Description:
h2. What happened
There is no value checking for parameter
teamconfx opened a new pull request, #5389:
URL: https://github.com/apache/hbase/pull/5389
### Description of PR
https://issues.apache.org/jira/browse/HBASE-27990
This PR adds a precheck for `hbase.blockcache.minblocksize` such that it
must be positive.
### How was this patch
ndimiduk commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1321749214
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1721,14 +1765,36 @@ protected HFileBlock
readBlockDataInternal(FSDataInputStream
ndimiduk commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1321748184
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1667,7 +1688,11 @@ protected HFileBlock
readBlockDataInternal(FSDataInputStream
Apache-HBase commented on PR #5388:
URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714123549
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
bbeaudreault commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1321727477
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1721,14 +1765,36 @@ protected HFileBlock
ndimiduk commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1321725464
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1721,14 +1765,36 @@ protected HFileBlock
readBlockDataInternal(FSDataInputStream
Apache-HBase commented on PR #5388:
URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714115981
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5388:
URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714112349
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
teamconfx opened a new pull request, #5388:
URL: https://github.com/apache/hbase/pull/5388
### Description of PR
https://issues.apache.org/jira/browse/HBASE-27989
This PR prohibits setting `hbase.server.allocator.buffer.size` to 0 or
negative. A warning is also added if the minimum
bbeaudreault commented on code in PR #5228:
URL: https://github.com/apache/hbase/pull/5228#discussion_r1321620558
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -692,6 +711,13 @@ public void updateRpc(MethodDescriptor method, Message
bbeaudreault commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1321591860
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1721,14 +1765,36 @@ protected HFileBlock
bbeaudreault commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1321548711
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1667,7 +1688,11 @@ protected HFileBlock
Apache-HBase commented on PR #5384:
URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713866984
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
bbeaudreault commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1321537092
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1697,8 +1722,27 @@ protected HFileBlock
Apache-HBase commented on PR #5384:
URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713863136
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5384:
URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713859062
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
ndimiduk commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1321481778
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockHeaderCorruption.java:
##
@@ -0,0 +1,533 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/HBASE-28068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Kumar reassigned HBASE-28068:
---
Assignee: Rahul Kumar
> Normalizer should batch merging 0 sized/empty regions
>
wchevreuil commented on code in PR #5371:
URL: https://github.com/apache/hbase/pull/5371#discussion_r1321395417
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -1700,17 +1853,17 @@ public BucketEntry writeToCache(final IOEngine
[
https://issues.apache.org/jira/browse/HBASE-28060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763650#comment-17763650
]
Pankaj Kumar commented on HBASE-28060:
--
Checked ByteBuffAllocator code, couldn't find any issue
wchevreuil commented on code in PR #5371:
URL: https://github.com/apache/hbase/pull/5371#discussion_r1321378222
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -1285,12 +1320,104 @@ void persistToFile() throws IOException {
ndimiduk commented on PR #5379:
URL: https://github.com/apache/hbase/pull/5379#issuecomment-1713427095
Heya @taklwu @ss77892 this backport broke branch-2.5, maybe others. Please
address and consider using PRs for all branch backports as well, just to get
pre-commit checks. Thanks!
--
[
https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763560#comment-17763560
]
Duo Zhang commented on HBASE-27231:
---
IIRC this requires a big refactoring on FSHLog implementation so
65 matches
Mail list logo