[GitHub] [hbase] Apache-HBase commented on pull request #5392: HBASE-28055 Addendum. Fixing the compilation failure

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5392: URL: https://github.com/apache/hbase/pull/5392#issuecomment-1715029032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] Apache-HBase commented on pull request #5394: HBASE-28055 Addendum. Fixing the compilation failure

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5394: URL: https://github.com/apache/hbase/pull/5394#issuecomment-1715025701 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[jira] [Commented] (HBASE-28055) Performance improvement for scan over several stores.

2023-09-11 Thread Sergey Soldatov (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764012#comment-17764012 ] Sergey Soldatov commented on HBASE-28055: - [~bbeaudreault], I've added pull requests for

[GitHub] [hbase] ss77892 opened a new pull request, #5393: HBASE-28055 Addendum. Fixing the compilation failure

2023-09-11 Thread via GitHub
ss77892 opened a new pull request, #5393: URL: https://github.com/apache/hbase/pull/5393 the source of OLDEST_TIMESTAMP is different in the master branch and that has been missed during the rebase. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ss77892 opened a new pull request, #5392: HBASE-28055 Addendum. Fixing the compilation failure

2023-09-11 Thread via GitHub
ss77892 opened a new pull request, #5392: URL: https://github.com/apache/hbase/pull/5392 the source of OLDEST_TIMESTAMP is different in the master branch and that has been missed during the rebase. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1714926692 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1714925029 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[jira] [Created] (HBASE-28071) [hbase-connectors] CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08

2023-09-11 Thread Nikita Pande (Jira)
Nikita Pande created HBASE-28071: Summary: [hbase-connectors] CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08 Key: HBASE-28071 URL: https://issues.apache.org/jira/browse/HBASE-28071 Project:

[jira] [Updated] (HBASE-28070) CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08

2023-09-11 Thread Nikita Pande (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Pande updated HBASE-28070: - Description: mvn dependency tree shows below {code:java} [INFO] | +-

[jira] [Created] (HBASE-28070) CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08

2023-09-11 Thread Nikita Pande (Jira)
Nikita Pande created HBASE-28070: Summary: CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08 Key: HBASE-28070 URL: https://issues.apache.org/jira/browse/HBASE-28070 Project: HBase

[GitHub] [hbase] zhuyaogai commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
zhuyaogai commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714859323 @bbeaudreault hi, I found that the latest unit test failures seem to be unrelated to me? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714809656 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1714804454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714796782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[jira] [Updated] (HBASE-28050) RSProcedureDispatcher to fail-fast for SaslException

2023-09-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-28050: - Description: As discussed on the parent Jira, let's mark the remote procedures fail when we

[jira] [Assigned] (HBASE-28050) RSProcedureDispatcher to fail-fast for SaslException

2023-09-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-28050: Assignee: Viraj Jasani > RSProcedureDispatcher to fail-fast for SaslException >

[GitHub] [hbase] Apache-HBase commented on pull request #5363: HBASE-28008 Add support for netty tcnative

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5363: URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714609451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5363: HBASE-28008 Add support for netty tcnative

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5363: URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714595876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5363: HBASE-28008 Add support for netty tcnative

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5363: URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714594299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[jira] [Created] (HBASE-28069) Add support for quotas on atomic operations

2023-09-11 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-28069: - Summary: Add support for quotas on atomic operations Key: HBASE-28069 URL: https://issues.apache.org/jira/browse/HBASE-28069 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714579437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] bbeaudreault commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
bbeaudreault commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714564222 @zhuyaogai unit test failures look related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #5390: HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5390: URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714535755 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714535313 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714525287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[GitHub] [hbase] Apache-HBase commented on pull request #5390: HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5390: URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714525180 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[jira] [Commented] (HBASE-28055) Performance improvement for scan over several stores.

2023-09-11 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763906#comment-17763906 ] Bryan Beaudreault commented on HBASE-28055: --- [~taklwu] This broke branch-2, 2.4, and 2.5.

[GitHub] [hbase] Apache-HBase commented on pull request #5389: HBASE-27990. BucketCache causes ArithmeticException due to improper blockSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5389: URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714503081 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5389: HBASE-27990. BucketCache causes ArithmeticException due to improper blockSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5389: URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714500571 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714269350 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[jira] [Comment Edited] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2023-09-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763825#comment-17763825 ] Andrew Kyle Purtell edited comment on HBASE-27231 at 9/11/23 5:03 PM:

[jira] [Comment Edited] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2023-09-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763825#comment-17763825 ] Andrew Kyle Purtell edited comment on HBASE-27231 at 9/11/23 5:03 PM:

[jira] [Comment Edited] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2023-09-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763825#comment-17763825 ] Andrew Kyle Purtell edited comment on HBASE-27231 at 9/11/23 5:01 PM:

[jira] [Commented] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2023-09-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763825#comment-17763825 ] Andrew Kyle Purtell commented on HBASE-27231: - I think we can. I cherry picked the master

[GitHub] [hbase] Apache-HBase commented on pull request #5390: HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5390: URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714244301 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1321804040 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -692,6 +711,13 @@ public void updateRpc(MethodDescriptor method, Message

[GitHub] [hbase] zhuyaogai commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
zhuyaogai commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714221773 > This is looking good! One more request. > > Also, can you please squash and rebase this PR so that we can clear out the `patch` warning in the pre-commit hook? done. --

[GitHub] [hbase] Apache-HBase commented on pull request #5389: HBASE-27990. BucketCache causes ArithmeticException due to improper blockSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5389: URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714221362 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714212178 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714204962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714201162 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

[jira] [Updated] (HBASE-27993) AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking

2023-09-11 Thread ConfX (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ConfX updated HBASE-27993: -- Description: h2. What happened There is no value checking for parameter

[GitHub] [hbase] teamconfx opened a new pull request, #5389: HBASE-27990. BucketCache causes ArithmeticException due to improper blockSize value checking

2023-09-11 Thread via GitHub
teamconfx opened a new pull request, #5389: URL: https://github.com/apache/hbase/pull/5389 ### Description of PR https://issues.apache.org/jira/browse/HBASE-27990 This PR adds a precheck for `hbase.blockcache.minblocksize` such that it must be positive. ### How was this patch

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321749214 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321748184 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1667,7 +1688,11 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714123549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321727477 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321725464 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714115981 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714112349 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] teamconfx opened a new pull request, #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

2023-09-11 Thread via GitHub
teamconfx opened a new pull request, #5388: URL: https://github.com/apache/hbase/pull/5388 ### Description of PR https://issues.apache.org/jira/browse/HBASE-27989 This PR prohibits setting `hbase.server.allocator.buffer.size` to 0 or negative. A warning is also added if the minimum

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1321620558 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -692,6 +711,13 @@ public void updateRpc(MethodDescriptor method, Message

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321591860 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321548711 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1667,7 +1688,11 @@ protected HFileBlock

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713866984 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321537092 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1697,8 +1722,27 @@ protected HFileBlock

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713863136 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713859062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

2023-09-11 Thread via GitHub
ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321481778 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockHeaderCorruption.java: ## @@ -0,0 +1,533 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (HBASE-28068) Normalizer should batch merging 0 sized/empty regions

2023-09-11 Thread Rahul Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Kumar reassigned HBASE-28068: --- Assignee: Rahul Kumar > Normalizer should batch merging 0 sized/empty regions >

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-09-11 Thread via GitHub
wchevreuil commented on code in PR #5371: URL: https://github.com/apache/hbase/pull/5371#discussion_r1321395417 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1700,17 +1853,17 @@ public BucketEntry writeToCache(final IOEngine

[jira] [Commented] (HBASE-28060) Region server getting crashed during write - A fatal error has been detected by the Java Runtime Environment

2023-09-11 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763650#comment-17763650 ] Pankaj Kumar commented on HBASE-28060: -- Checked ByteBuffAllocator code, couldn't find any issue

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-09-11 Thread via GitHub
wchevreuil commented on code in PR #5371: URL: https://github.com/apache/hbase/pull/5371#discussion_r1321378222 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1285,12 +1320,104 @@ void persistToFile() throws IOException {

[GitHub] [hbase] ndimiduk commented on pull request #5379: HBASE-28055 Performance improvement for scan over several stores.

2023-09-11 Thread via GitHub
ndimiduk commented on PR #5379: URL: https://github.com/apache/hbase/pull/5379#issuecomment-1713427095 Heya @taklwu @ss77892 this backport broke branch-2.5, maybe others. Please address and consider using PRs for all branch backports as well, just to get pre-commit checks. Thanks! --

[jira] [Commented] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2023-09-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763560#comment-17763560 ] Duo Zhang commented on HBASE-27231: --- IIRC this requires a big refactoring on FSHLog implementation so