Re: [PR] HBASE-28209: Create a jmx metrics to expose the oldWALs directory size [hbase]

2023-11-19 Thread via GitHub
vinayakphegde commented on code in PR #5528: URL: https://github.com/apache/hbase/pull/5528#discussion_r1398666808 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java: ## @@ -398,4 +414,33 @@ public void archiveMetaLog(final ServerName serverName)

Re: [PR] HBASE-28209: Create a jmx metrics to expose the oldWALs directory size [hbase]

2023-11-19 Thread via GitHub
vinayakphegde commented on code in PR #5528: URL: https://github.com/apache/hbase/pull/5528#discussion_r1398666429 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java: ## @@ -398,4 +414,33 @@ public void archiveMetaLog(final ServerName serverName)

Re: [PR] HBASE-28192 Master should recover if meta region state is inconsistent [hbase]

2023-11-19 Thread via GitHub
Apache9 commented on PR #5513: URL: https://github.com/apache/hbase/pull/5513#issuecomment-1818167780 > Correct, downgrading to 2.4 does not remove meta's address from master local region's info:sn. Hence, any downgrade from 2.5 to older versions has this risk: it neither removes info CF fr

Re: [PR] HBASE-28192 Master should recover if meta region state is inconsistent [hbase]

2023-11-19 Thread via GitHub
virajjasani commented on PR #5513: URL: https://github.com/apache/hbase/pull/5513#issuecomment-1818160242 Correct, downgrading to 2.4 does not remove meta's address from master local region's info:sn. Hence, any downgrade from 2.5 to older versions has this risk: it neither removes info CF

[jira] [Commented] (HBASE-28031) TestClusterScopeQuotaThrottle is still failing with broken WAL writer

2023-11-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787782#comment-17787782 ] Duo Zhang commented on HBASE-28031: --- Merged the PR to master. Let's see if this could

[jira] [Assigned] (HBASE-28031) TestClusterScopeQuotaThrottle is still failing with broken WAL writer

2023-11-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28031: - Assignee: Duo Zhang > TestClusterScopeQuotaThrottle is still failing with broken WAL writer > -

Re: [PR] HBASE-28031 TestClusterScopeQuotaThrottle is still failing with brokeā€¦ [hbase]

2023-11-19 Thread via GitHub
Apache9 merged PR #5529: URL: https://github.com/apache/hbase/pull/5529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

Re: [PR] HBASE-28192 Master should recover if meta region state is inconsistent [hbase]

2023-11-19 Thread via GitHub
Apache9 commented on PR #5513: URL: https://github.com/apache/hbase/pull/5513#issuecomment-1818119983 > > I would definitely prefer automated solutions rather than rely on HBCK. IMO anything requiring hbck is a bug. > > I agree. > > For this case, we now know that the root caus

Re: [PR] HBASE-28192 Master should recover if meta region state is inconsistent [hbase]

2023-11-19 Thread via GitHub
virajjasani commented on PR #5513: URL: https://github.com/apache/hbase/pull/5513#issuecomment-1818097080 > I would definitely prefer automated solutions rather than rely on HBCK. IMO anything requiring hbck is a bug. I agree. For this case, we now know that the root cause was

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-19 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1817991865 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s | Docker

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-19 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1817990558 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-19 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1817938520 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-19 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1817930339 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docke

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-19 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1817928706 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-19 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1817869660 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 49s | Docke