Re: [PR] HBASE-28212 Do not need to maintain rollback step when root procedure… [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5547: URL: https://github.com/apache/hbase/pull/5547#issuecomment-1831365857 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[jira] [Comment Edited] (HBASE-28120) Provide the switch to avoid reopening regions in the alter sync command

2023-11-28 Thread Gourab Taparia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790943#comment-17790943 ] Gourab Taparia edited comment on HBASE-28120 at 11/29/23 7:34 AM: --

[jira] [Commented] (HBASE-28120) Provide the switch to avoid reopening regions in the alter sync command

2023-11-28 Thread Gourab Taparia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790943#comment-17790943 ] Gourab Taparia commented on HBASE-28120: [~bbeaudreault] Sorry running a bit late here, will be

[jira] [Commented] (HBASE-28217) PrefetchExecutor should not run for files from CFs that have disabled BLOCKCACHE

2023-11-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790932#comment-17790932 ] Hudson commented on HBASE-28217: Results for branch branch-2 [build #932 on

Re: [PR] HBASE-27795: Define RPC API for cache cleaning [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5492: URL: https://github.com/apache/hbase/pull/5492#issuecomment-1831316794 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1831314147 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[jira] [Created] (HBASE-28227) Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction.

2023-11-28 Thread longping_jie (Jira)
longping_jie created HBASE-28227: Summary: Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction. Key: HBASE-28227 URL: https://issues.apache.org/jira/browse/HBASE-28227

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1831299465 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28209: Create a jmx metrics to expose the oldWALs directory size [hbase]

2023-11-28 Thread via GitHub
vinayakphegde commented on code in PR #5528: URL: https://github.com/apache/hbase/pull/5528#discussion_r1408799214 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java: ## @@ -89,6 +89,12 @@ public boolean accept(Path p) { // create the split

Re: [PR] HBASE-27795: Define RPC API for cache cleaning [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5492: URL: https://github.com/apache/hbase/pull/5492#issuecomment-1831287256 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s |

[jira] [Commented] (HBASE-28199) Phase I: Suspend TRSP and SCP when updating meta

2023-11-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790924#comment-17790924 ] Duo Zhang commented on HBASE-28199: --- OK, great. Thanks [~luoen] for testing this with ITBLL~ > Phase

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
stoty commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1831262664 hbase-mapreduce does. But it is transitive via Hadoop, and we mark Hadoop dependencies as provided in the hbase-mapreduce-shaded uberjar, and only add netty artifacts coming via ZK.

Re: [PR] HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5548: URL: https://github.com/apache/hbase/pull/5548#issuecomment-1831257629 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[jira] [Commented] (HBASE-28217) PrefetchExecutor should not run for files from CFs that have disabled BLOCKCACHE

2023-11-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790902#comment-17790902 ] Hudson commented on HBASE-28217: Results for branch branch-2.4 [build #658 on

[PR] HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure [hbase]

2023-11-28 Thread via GitHub
hiping-tech opened a new pull request, #5548: URL: https://github.com/apache/hbase/pull/5548 …hen skip it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28212 Do not need to maintain rollback step when root procedure… [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5547: URL: https://github.com/apache/hbase/pull/5547#issuecomment-1831195520 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[jira] [Created] (HBASE-28226) The flush table operation encountered an NPE and failed.

2023-11-28 Thread Haiping lv (Jira)
Haiping lv created HBASE-28226: -- Summary: The flush table operation encountered an NPE and failed. Key: HBASE-28226 URL: https://issues.apache.org/jira/browse/HBASE-28226 Project: HBase Issue

[jira] [Commented] (HBASE-28199) Phase I: Suspend TRSP and SCP when updating meta

2023-11-28 Thread Haiping lv (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790882#comment-17790882 ] Haiping lv commented on HBASE-28199: hi, [~zhangduo] this PR has undergone ITBLL testing with tens

[PR] HBASE-28212 Do not need to maintain rollback step when root procedure… [hbase]

2023-11-28 Thread via GitHub
Apache9 opened a new pull request, #5547: URL: https://github.com/apache/hbase/pull/5547 … does not support rollback (#5538) Signed-off-by: GeorryHuang (cherry picked from commit 4b015e6a5486394d70bbf5fc0197e469c0987913) (cherry picked from commit

[jira] [Resolved] (HBASE-28225) Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit

2023-11-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28225. --- Fix Version/s: 4.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to master.

Re: [PR] HBASE-28225 Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit [hbase]

2023-11-28 Thread via GitHub
Apache9 merged PR #5544: URL: https://github.com/apache/hbase/pull/5544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (HBASE-28225) Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit

2023-11-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-28225: - Summary: Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit Key: HBASE-28225 URL: https://issues.apache.org/jira/browse/HBASE-28225 Project:

Re: [PR] HBASE-28212 Do not need to maintain rollback step when root procedure… [hbase]

2023-11-28 Thread via GitHub
Apache9 merged PR #5538: URL: https://github.com/apache/hbase/pull/5538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
Apache9 commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1831127686 Hbase-mapreduce module does not transitively depend on netty-all? Strange... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-27795: Define RPC API for cache cleaning [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5492: URL: https://github.com/apache/hbase/pull/5492#issuecomment-1831124236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[jira] [Commented] (HBASE-28222) Leak in ExportSnapshot during verifySnapshot on S3A

2023-11-28 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790871#comment-17790871 ] Bryan Beaudreault commented on HBASE-28222: --- I discovered a related issue

Re: [PR] HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on PR #5546: URL: https://github.com/apache/hbase/pull/5546#issuecomment-1831114712 I may reopen this, but actually I want to investigate a different approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A [hbase]

2023-11-28 Thread via GitHub
bbeaudreault closed pull request #5546: HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A URL: https://github.com/apache/hbase/pull/5546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1831089037 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[jira] [Commented] (HBASE-25972) Dual File Compactor

2023-11-28 Thread Kadir Ozdemir (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790843#comment-17790843 ] Kadir Ozdemir commented on HBASE-25972: --- [~apurtell], [~vjasani], please see the design doc and PR

[jira] [Updated] (HBASE-25972) Dual File Compactor

2023-11-28 Thread Kadir Ozdemir (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kadir Ozdemir updated HBASE-25972: -- Summary: Dual File Compactor (was: Single and Multi-version HFiles) > Dual File Compactor >

[jira] [Work started] (HBASE-25972) Single and Multi-version HFiles

2023-11-28 Thread Kadir Ozdemir (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25972 started by Kadir Ozdemir. - > Single and Multi-version HFiles > --- > >

[PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-28 Thread via GitHub
kadirozde opened a new pull request, #5545: URL: https://github.com/apache/hbase/pull/5545 [Design doc](https://docs.google.com/document/d/1Ea42tEBh2X2fCq0_tXSe1BgEqBz58oswJULEbA8-MfI/edit) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Assigned] (HBASE-25972) Single and Multi-version HFiles

2023-11-28 Thread Kadir Ozdemir (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kadir Ozdemir reassigned HBASE-25972: - Assignee: Kadir Ozdemir > Single and Multi-version HFiles >

Re: [PR] Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5544: URL: https://github.com/apache/hbase/pull/5544#issuecomment-1830981317 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

Re: [PR] Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5544: URL: https://github.com/apache/hbase/pull/5544#issuecomment-1830980306 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5544: URL: https://github.com/apache/hbase/pull/5544#issuecomment-1830980075 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[PR] Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit [hbase]

2023-11-28 Thread via GitHub
dependabot[bot] opened a new pull request, #5544: URL: https://github.com/apache/hbase/pull/5544 Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.4 to 41.0.6. Changelog Sourced from https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst;>cryptography's

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
wchevreuil merged PR #5543: URL: https://github.com/apache/hbase/pull/5543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-28 Thread via GitHub
wchevreuil commented on code in PR #5530: URL: https://github.com/apache/hbase/pull/5530#discussion_r1408399669 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -642,12 +643,14 @@ void blockEvicted(BlockCacheKey cacheKey, BucketEntry

Re: [PR] HBASE-28209: Create a jmx metrics to expose the oldWALs directory size [hbase]

2023-11-28 Thread via GitHub
wchevreuil commented on code in PR #5528: URL: https://github.com/apache/hbase/pull/5528#discussion_r1407961823 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java: ## @@ -89,6 +89,12 @@ public boolean accept(Path p) { // create the split log

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5534: URL: https://github.com/apache/hbase/pull/5534#issuecomment-1830665233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5534: URL: https://github.com/apache/hbase/pull/5534#issuecomment-1830652731 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
stoty commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1830638986 -1 We don't need netty-all, only netty-handler. This problem is caused by overriding the netty4 version, and HBASE-28153 already solves it in a more appropriate way. -- This is an

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5543: URL: https://github.com/apache/hbase/pull/5543#issuecomment-1830484813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 45s |

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5543: URL: https://github.com/apache/hbase/pull/5543#issuecomment-1830481175 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 50s |

[jira] [Commented] (HBASE-28120) Provide the switch to avoid reopening regions in the alter sync command

2023-11-28 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790713#comment-17790713 ] Bryan Beaudreault commented on HBASE-28120: --- Any update here? We will branch 2.6 soon, so if

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1408145896 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
rmdmattingly commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1408119641 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
rmdmattingly commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1408119641 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
rmdmattingly commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1408119641 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5534: URL: https://github.com/apache/hbase/pull/5534#issuecomment-1830280891 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
stoty commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1830279856 As discussed offline netty-all is a direct dependency of ZK, so I think this is fine after all. It would be nice if we wouldn't have to add it explicitly, and instead could take it

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1408070306 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1408061918 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1408061918 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1408058012 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

[jira] [Created] (HBASE-28224) ClientSideRegionScanner appears not to shutdown MobFileCache

2023-11-28 Thread Mark Hale (Jira)
Mark Hale created HBASE-28224: - Summary: ClientSideRegionScanner appears not to shutdown MobFileCache Key: HBASE-28224 URL: https://issues.apache.org/jira/browse/HBASE-28224 Project: HBase

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5543: URL: https://github.com/apache/hbase/pull/5543#issuecomment-1830064468 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
rmdmattingly commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1407922652 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -61,20 +69,36 @@ public class

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1407920432 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -61,20 +69,36 @@ public class

[jira] [Resolved] (HBASE-28217) PrefetchExecutor should not run for files from CFs that have disabled BLOCKCACHE

2023-11-28 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-28217. -- Resolution: Fixed Thanks for reviewing it, [~psomogyi]. I have merged it to

[jira] [Updated] (HBASE-28217) PrefetchExecutor should not run for files from CFs that have disabled BLOCKCACHE

2023-11-28 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-28217: - Fix Version/s: 2.6.0 2.4.18 3.0.0-beta-1

[jira] [Updated] (HBASE-28217) PrefetchExecutor should not run for files from CFs that have disabled BLOCKCACHE

2023-11-28 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-28217: - Affects Version/s: 2.5.6 2.4.17

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
rmdmattingly commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1407876188 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -61,20 +69,36 @@ public class

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
stoty commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1829959101 hbase-shaded-client is meant to include Hadoop, but hbase-shaded-mapreduce is not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
ragarkar closed pull request #5541: HBASE-28186 Rebase CacheAwareBalance related commits URL: https://github.com/apache/hbase/pull/5541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
ragarkar opened a new pull request, #5543: URL: https://github.com/apache/hbase/pull/5543 …… (#5339) Signed-off-by: Wellington Chevreuil Reviewew-by: Kota-SH (cherry picked from commit 364fcea01c45921b806edea80c8a01e08608dd8d) -- This is an automated message from the Apache

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
stoty commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1829926848 Shouldn't netty-all be coming from the Hadoop classpath ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1829909357 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1829905455 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 17s |

Re: [PR] HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5542: URL: https://github.com/apache/hbase/pull/5542#issuecomment-1829898171 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r140856 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

[jira] [Updated] (HBASE-28223) Include shaded netty-all in hbase-shaded-mapreduce

2023-11-28 Thread Andor Molnar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated HBASE-28223: - Affects Version/s: 2.5.6 2.4.17 3.0.0-alpha-4 >

[jira] [Created] (HBASE-28223) Including shaded netty-all in hbase-shaded-mapreduce

2023-11-28 Thread Andor Molnar (Jira)
Andor Molnar created HBASE-28223: Summary: Including shaded netty-all in hbase-shaded-mapreduce Key: HBASE-28223 URL: https://issues.apache.org/jira/browse/HBASE-28223 Project: HBase Issue

[jira] [Updated] (HBASE-28223) Include shaded netty-all in hbase-shaded-mapreduce

2023-11-28 Thread Andor Molnar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated HBASE-28223: - Summary: Include shaded netty-all in hbase-shaded-mapreduce (was: Including shaded netty-all

Re: [PR] HBASE-28217 PrefetchExecutor should not run for files from CFs that have disabled BLOCKCACHE [hbase]

2023-11-28 Thread via GitHub
wchevreuil merged PR #5535: URL: https://github.com/apache/hbase/pull/5535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-28 Thread via GitHub
Apache9 commented on code in PR #5530: URL: https://github.com/apache/hbase/pull/5530#discussion_r1407672046 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -642,12 +643,14 @@ void blockEvicted(BlockCacheKey cacheKey, BucketEntry

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
Apache9 commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1407666801 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28212 Do not need to maintain rollback step when root procedure… [hbase]

2023-11-28 Thread via GitHub
Apache9 commented on PR #5538: URL: https://github.com/apache/hbase/pull/5538#issuecomment-1829706074 Will merge tomorrow if no other concerns~ Thanks @GeorryHuang for reviewing~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5541: URL: https://github.com/apache/hbase/pull/5541#issuecomment-1829684597 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5541: URL: https://github.com/apache/hbase/pull/5541#issuecomment-1829678971 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-28 Thread via GitHub
Apache-HBase commented on PR #5541: URL: https://github.com/apache/hbase/pull/5541#issuecomment-1829674375 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1407632654 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1407617976 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-28 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1407617976 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -139,33 +170,57 @@ protected Flow

[jira] [Commented] (HBASE-28031) TestClusterScopeQuotaThrottle is still failing with broken WAL writer

2023-11-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790479#comment-17790479 ] Duo Zhang commented on HBASE-28031: --- Merge the new PR to master. Let's see if the test could

Re: [PR] HBASE-28031 TestClusterScopeQuotaThrottle is still failing with broke… [hbase]

2023-11-28 Thread via GitHub
Apache9 merged PR #5539: URL: https://github.com/apache/hbase/pull/5539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: