Re: [PR] HBASE-28401 Introduce a close method for memstore for release active … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5705: URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963513057 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

Re: [PR] HBASE-28401 Introduce a close method for memstore for release active … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5705: URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963500046 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-02-25 Thread via GitHub
pankaj72981 commented on code in PR #5691: URL: https://github.com/apache/hbase/pull/5691#discussion_r1502147908 ## hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java: ## @@ -994,4 +994,16 @@ public int getQuotaSettingCount(Admin admin) throws IOExcep

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
chrajeshbabu commented on code in PR #5689: URL: https://github.com/apache/hbase/pull/5689#discussion_r1502147916 ## dev-support/Jenkinsfile: ## @@ -628,6 +630,122 @@ pipeline { } } } + +stage ('yetus jdk17 hadoop3 checks') { + w

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
chrajeshbabu commented on code in PR #5689: URL: https://github.com/apache/hbase/pull/5689#discussion_r1502143177 ## dev-support/Jenkinsfile: ## @@ -628,6 +630,122 @@ pipeline { } } } + +stage ('yetus jdk17 hadoop3 checks') { + w

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-02-25 Thread via GitHub
pankaj72981 commented on code in PR #5691: URL: https://github.com/apache/hbase/pull/5691#discussion_r1502147908 ## hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java: ## @@ -994,4 +994,16 @@ public int getQuotaSettingCount(Admin admin) throws IOExcep

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
chrajeshbabu commented on code in PR #5689: URL: https://github.com/apache/hbase/pull/5689#discussion_r1502147916 ## dev-support/Jenkinsfile: ## @@ -628,6 +630,122 @@ pipeline { } } } + +stage ('yetus jdk17 hadoop3 checks') { + w

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
chrajeshbabu commented on code in PR #5689: URL: https://github.com/apache/hbase/pull/5689#discussion_r1502143177 ## dev-support/Jenkinsfile: ## @@ -628,6 +630,122 @@ pipeline { } } } + +stage ('yetus jdk17 hadoop3 checks') { + w

Re: [PR] HBASE-28124 Missing fields in Scan.toJSON [hbase]

2024-02-25 Thread via GitHub
chrajeshbabu commented on PR #5678: URL: https://github.com/apache/hbase/pull/5678#issuecomment-1963468433 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963467150 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963466832 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s | Docke

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963466554 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s | Docke

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
Apache9 commented on code in PR #5689: URL: https://github.com/apache/hbase/pull/5689#discussion_r1502133971 ## dev-support/Jenkinsfile_GitHub: ## @@ -470,6 +471,144 @@ pipeline { } } } +stage ('yetus

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963464411 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/H

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963464302 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/H

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963464252 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/H

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-25 Thread via GitHub
chrajeshbabu commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1963454139 From the discussion agreed to add master and branch-3 accordingly I have changed the PR. Is it good to go now? @ndimiduk @Apache9 ? -- This is an automated message from the Apache

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963356267 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963349603 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker

Re: [PR] HBASE-28401 Introduce a close method for memstore for release active … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5705: URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963290172 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

[jira] [Updated] (HBASE-28399) region size can be wrong from RegionSizeCalculator

2024-02-25 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ruanhui updated HBASE-28399: Priority: Major (was: Minor) > region size can be wrong from RegionSizeCalculator > -

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-25 Thread via GitHub
frostruan commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1501977606 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963189918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-25 Thread via GitHub
Apache9 commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1501954722 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin ad

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-25 Thread via GitHub
Apache9 commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1501953632 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin ad

[jira] [Commented] (HBASE-28398) Make sure we close all the scanners in TestHRegion

2024-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820516#comment-17820516 ] Hudson commented on HBASE-28398: Results for branch branch-3 [build #154 on bui

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963016197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1963015255 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 17s | Docke

Re: [PR] HBASE-28401 Introduce a close method for memstore for release active … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5705: URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963007062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 1s | Docker

Re: [PR] HBASE-28401 Introduce a close method for memstore for release active … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5705: URL: https://github.com/apache/hbase/pull/5705#issuecomment-1963004341 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1962959463 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docke

Re: [PR] HBASE-28401 Introduce a close method for memstore for release active … [hbase]

2024-02-25 Thread via GitHub
Apache-HBase commented on PR #5705: URL: https://github.com/apache/hbase/pull/5705#issuecomment-1962947665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 13s | Docke

[PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache9 opened a new pull request, #5707: URL: https://github.com/apache/hbase/pull/5707 …and we use different principal for master and region server (#5688) Signed-off-by: Bryan Beaudreault (cherry picked from commit c4a02f7fcd1d74385b87bb761d25b118ce080119) -- This is an autom

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache9 merged PR #5688: URL: https://github.com/apache/hbase/pull/5688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

[jira] [Commented] (HBASE-28398) Make sure we close all the scanners in TestHRegion

2024-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820462#comment-17820462 ] Hudson commented on HBASE-28398: Results for branch branch-2 [build #996 on bui

[jira] [Commented] (HBASE-28390) WAL value compression fails for cells with large values

2024-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820448#comment-17820448 ] Hudson commented on HBASE-28390: Results for branch branch-2.6 [build #62 on bu

[jira] [Commented] (HBASE-28398) Make sure we close all the scanners in TestHRegion

2024-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820449#comment-17820449 ] Hudson commented on HBASE-28398: Results for branch branch-2.6 [build #62 on bu

[jira] [Commented] (HBASE-28370) Default user quotas are refreshing too frequently

2024-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820447#comment-17820447 ] Hudson commented on HBASE-28370: Results for branch branch-2.6 [build #62 on bu

[jira] [Updated] (HBASE-28019) Bump gitpython from 3.1.30 to 3.1.32 in /dev-support/git-jira-release-audit

2024-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28019: -- Fix Version/s: 4.0.0-alpha-1 (was: 3.0.0-beta-1) > Bump gitpython from 3.1.30 t

[jira] [Resolved] (HBASE-28402) Bump cryptography from 42.0.2 to 42.0.4 in /dev-support/git-jira-release-audit

2024-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28402. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. > Bump cryptography from 42.0.2 to

[jira] [Updated] (HBASE-28402) Bump cryptography from 42.0.2 to 42.0.4 in /dev-support/git-jira-release-audit

2024-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28402: --- Labels: pull-request-available (was: ) > Bump cryptography from 42.0.2 to 42.0.4 in /dev-su

Re: [PR] HBASE-28402 Bump cryptography from 42.0.2 to 42.0.4 in /dev-support/git-jira-release-audit [hbase]

2024-02-25 Thread via GitHub
Apache9 merged PR #5694: URL: https://github.com/apache/hbase/pull/5694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

[jira] [Updated] (HBASE-28402) Bump cryptography from 42.0.2 to 42.0.4 in /dev-support/git-jira-release-audit

2024-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28402: -- Fix Version/s: 4.0.0-alpha-1 > Bump cryptography from 42.0.2 to 42.0.4 in /dev-support/git-jira-releas

[jira] [Updated] (HBASE-28309) Bump gitpython from 3.1.37 to 3.1.41 in /dev-support/git-jira-release-audit

2024-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28309: -- Fix Version/s: 4.0.0-alpha-1 (was: 3.0.0-beta-2) > Bump gitpython from 3.1.37 t

[jira] [Updated] (HBASE-28355) Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit

2024-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28355: -- Fix Version/s: 4.0.0-alpha-1 (was: 3.0.0-beta-2) > Bump cryptography from 41.0.

[jira] [Created] (HBASE-28402) Bump cryptography from 42.0.2 to 42.0.4 in /dev-support/git-jira-release-audit

2024-02-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-28402: - Summary: Bump cryptography from 42.0.2 to 42.0.4 in /dev-support/git-jira-release-audit Key: HBASE-28402 URL: https://issues.apache.org/jira/browse/HBASE-28402 Project: HBa

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-02-25 Thread via GitHub
Apache9 commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1962862133 Yes, for other store engines, we could add a check that you should not enable the 'write latest cells to separated file' flag, and open follow on issues to support this feature for other st

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache9 commented on code in PR #5688: URL: https://github.com/apache/hbase/pull/5688#discussion_r1501771630 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -201,23 +209,31 @@ private void failInit(Channel ch, IOException e) { // fai

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-25 Thread via GitHub
Apache9 commented on code in PR #5688: URL: https://github.com/apache/hbase/pull/5688#discussion_r1501771164 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -252,35 +268,99 @@ public void operationComplete(Future future) throws Exception

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-02-25 Thread via GitHub
kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1962855097 @Apache9 , Thank you for this detailed response. Based your feedback, I will integrate dual file writing into StoreFileWriter. StoreFileWriter will be able to separate cells into live and